Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 26 Jan 2018 23:10:26 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     David Woodhouse <dwmw2@infradead.org>
Cc:     Tom Lendacky <thomas.lendacky@amd.com>, x86-ml <x86@kernel.org>,
        linux-tip-commits@vger.kernel.org, hpa@zytor.com,
        gregkh@linuxfoundation.org, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, mingo@kernel.org
Subject: Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits
Message-ID: <20180126221026.hc2hk23zsqbqhkif@pd.tnic>
References: <1516896855-7642-4-git-send-email-dwmw@amazon.co.uk>
 <tip-5d10cbc91d9eb5537998b65608441b592eec65e7@git.kernel.org>
 <20180126184139.rcfbtk7dvj7kmyfn@pd.tnic>
 <1516992318.30244.271.camel@infradead.org>
 <20180126184915.ioqewp56orj2qhrt@pd.tnic>
 <7094ed9b-40f7-ba2b-55a6-cc5ab0b06bb9@amd.com>
 <20180126215209.vqdxh5p672tcdst6@pd.tnic>
 <1517003984.30244.299.camel@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1517003984.30244.299.camel@infradead.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 26, 2018 at 09:59:44PM +0000, David Woodhouse wrote:
> If we wanted to do this kind of thing, we'd do it the other way round.
> Turn the *Intel* feature into both 'IBRS' and 'IBPB' CPU-visible
> features, and have those defined in the AMD word.

You lost me here: have those defined in the AMD word?

> Then use virtual bits with "" for the software features, since we
> don't want *those* to appear in /proc/cpuinfo.

Whatever we do, I think it would be most consistent to have three
strings, *both* on Intel and AMD visible in cpuinfo: "ibrs", "ibpb" and
"stibp" so that there's no confusion what is enabled on each box.

Now, those three can be the *virtual* features which get set by the
actual CPUID features on init. And the latter, the *actual* CPUID
features don't need to be visible in cpuinfo: people shouldn't care
whether "spec_ctrl" on Intel and "pred_cmd" on AMD both mean "ibpb". It
should be simply "ibpb" on both vendors in cpuinfo.

Ditto for the others.

This way you have one unified message of what is enabled on *any* box.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.