Received: by 10.223.176.46 with SMTP id f43csp1265075wra; Fri, 26 Jan 2018 15:01:58 -0800 (PST) X-Google-Smtp-Source: AH8x226T24r84adNrRov1bPN9XKQepcnJ/z/2aozE9fH/yQ5zzMgOHA8LUEqPoq9bsP9HaI4VS7W X-Received: by 2002:a17:902:76ca:: with SMTP id j10-v6mr5807446plt.204.1517007718885; Fri, 26 Jan 2018 15:01:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517007718; cv=none; d=google.com; s=arc-20160816; b=XErrlXfr1rHJX8d+qM5PSWQ/3lQM82AqCSxZtwbHlWOY2xd8UL14vjeL6S3DaK5yiM +5uSbAjDcFluxgfPcDa8YXcRdCswed9aW/c0FI2LOn1EL/jV1Ufc3Up8GA9Dw/bnStJO 2OQ/bFkVXjaQ58pRb1w3jbKNoOkLgpZEyIIBPpmXLpOdUb1hv6fyG6j1A6KkgMPyfUsB 1cZ4bBKNiDz0D4bYXf7u6inpn9HxNx4cxdCzdLsgoqWuuw9fuhTIEVvBsSURMj++DHRs Fxytc09KsZEnytmoydn8SBj1hrJVk64PvnUNCVcR3u8+vQ5T8ZWTjp3yKRU66E0d7bsT BWVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=8H3GYexwOIjXQm15n2qAzwxxLQzQxpRehiYDhfCeLDw=; b=K8raRFVKwR16g/jdNZc7/JDzZ6Zw4cS8Y9nOsK4aZvrK8P9GR8OvM26/mYRREAFo6n vNIT59C/jQ1MqQEfoS3yiqn9F9G0ScMrplZ7sORzLYimJhO/FTK2vcAd8B8BabT6moGv p1bnFIyNRZWp4S05um6pku+tjqkKb6MPfN2kaVJVqXoFcKsxWabkFdn8PhUnztLV+mW8 T841yowKfBfXnwmj9fkrQKfoXsdUVsSmWVrBen2Hvfmr0Qv2w0lKrp+D8S6r5diVKceC f69lctYZ6Ku1FKh1nqpiffYa3sRZayY4tIt/PdWmTjiolDuEYajPrAYsqJhyr9pNPSGP xtfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 65si3581751pgh.98.2018.01.26.15.01.44; Fri, 26 Jan 2018 15:01:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbeAZXAq (ORCPT + 99 others); Fri, 26 Jan 2018 18:00:46 -0500 Received: from mga05.intel.com ([192.55.52.43]:46776 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbeAZXAp (ORCPT ); Fri, 26 Jan 2018 18:00:45 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jan 2018 15:00:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,418,1511856000"; d="scan'208";a="25782394" Received: from jfdmzpr07.jf.intel.com (HELO mherber2-mac01.jf.intel.com) ([10.7.210.28]) by fmsmga001.fm.intel.com with ESMTP; 26 Jan 2018 15:00:44 -0800 Subject: Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help To: Masahiro Yamada Cc: Thiago Macieira , Josh Triplett , Guenter Roeck , Wayne Boyer , Linux Kbuild mailing list , Linux Kernel Mailing List , Michal Marek , Sam Ravnborg References: <20171219012656.23728-1-marc.herbert@intel.com> <070e7d03-b1a7-430f-709b-bb5fe9e2a0a3@intel.com> From: Marc Herbert Message-ID: <594ca2cb-5a21-2bba-4132-73d42f3a909a@intel.com> Date: Fri, 26 Jan 2018 15:00:44 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masahiro, On 17/01/2018 20:31, Masahiro Yamada wrote: > Sorry for my late reply. I think we're even now :-) >> I'd like to keep that sentence because it's there to explain the legacy and >> confusing "--silentoldconfig" name which unfortunately still sticks out in >> the *current* conf.c interface. >> >> + printf(" --silentoldconfig Similar to oldconfig but generates configuration in\n" >> + " include/{generated/,config/} (oldconfig used to be more verbose)\n"); >> >> The purpose of this sentence is to warn people that: "silentoldconfig is >> just archeology, so you can safely ignore it" and save them time. >> >> The alternative I considered was to entirely remove "silentconfig" not just >> from the Makefile's help but from the conf.c help too. > > Another possibility might be to rename 'silentoldconfig'. > instead of explaining the background in the help message. > [...] > It is difficult to suggest a clear name, > but 'syncconfig' is the one I came up with. > > Please suggest if you have a better idea. Look like a good idea and name to me but... for a different, bigger and later commit. > Commit fb16d8912db5268f29706010ecafff74b971c58d > renamed oldnoconfig to olddefconfig... ... but it didn't remove any "now internal API" from "make help". Instead it changed the name of an external and preserved "API". > If we worry about the compatibility just in case, > we can keep 'silentoldconfig' as an alias as well. Yes - but later? In the meantime I found another instance of silentoldconfig in Documentation/admin-guide/; posting v3 with that removed too. I'm also adding some deprecation comments in the source. -- Marc