Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 27 Jan 2018 12:13:18 +0900
From:   Stafford Horne <shorne@gmail.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Palmer Dabbelt <palmer@sifive.com>, linux@armlinux.org.uk,
        catalin.marinas@arm.com, Will Deacon <will.deacon@arm.com>,
        jonas@southpole.se, stefan.kristiansson@saunalahti.fi,
        tglx@linutronix.de, Arnd Bergmann <arnd@arndb.de>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        patches@groups.riscv.org
Subject: Re: [PATCH v2 3/4] openrisc: Use the new MULTI_IRQ_HANDLER
Message-ID: <20180127031318.GA30895@lianli.shorne-pla.net>
References: <20180125030756.21787-1-palmer@sifive.com>
 <20180125030756.21787-4-palmer@sifive.com>
 <20180125074619.GC14162@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180125074619.GC14162@infradead.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 24, 2018 at 11:46:19PM -0800, Christoph Hellwig wrote:
> On Wed, Jan 24, 2018 at 07:07:55PM -0800, Palmer Dabbelt wrote:
> > It appears that openrisc copied arm64's MULTI_IRQ_HANDLER code (which
> > came from arm).  I wanted to make this generic so I could use it in the
> > RISC-V port.  This patch converts the openrisc code to use the generic
> > version.
> 
> Note that openriscv overrides previous handle_arch_irq assignments.
> We'll need to know from the openrisc folks if that was intentional.
> 
> Otherwise this looks fine to me.

This looks fine to me too.  We only assign the handle_arch_irq one time.  I
think not protecting against overrides was an oversight in the original
implementation.

Acked-by: Stafford Horne <shorne@gmail.com>

-Stafford