Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270809AbTG0O6S (ORCPT ); Sun, 27 Jul 2003 10:58:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270810AbTG0O6S (ORCPT ); Sun, 27 Jul 2003 10:58:18 -0400 Received: from bristol.phunnypharm.org ([65.207.35.130]:5038 "EHLO bristol.phunnypharm.org") by vger.kernel.org with ESMTP id S270809AbTG0O6R (ORCPT ); Sun, 27 Jul 2003 10:58:17 -0400 Date: Sun, 27 Jul 2003 11:00:42 -0400 From: Ben Collins To: dan carpenter Cc: Brad Hards , linux-kernel@vger.kernel.org Subject: Re: [bug] ieee1394/sbp2 - sleeping in invalid context Message-ID: <20030727150042.GL490@phunnypharm.org> References: <200307262224.13705.bhards@bigpond.net.au> <200307270346.50781.d_carpenter@sbcglobal.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307270346.50781.d_carpenter@sbcglobal.net> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 20 On Sun, Jul 27, 2003 at 03:46:50AM -0700, dan carpenter wrote: > I think sbp2scsi_queuecommand is called from outside interrupt context. The > obvious but possibly wrong way to fix this would be to change the calls to > hpsb_get_tlabel() to check in_atomic() instead of in_interrupt(). Preempt will be the death of me. Wish there was a can_sleep() macro to make things easier. Thanks for the report, I'll fix this. -- Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/