Received: by 10.223.176.5 with SMTP id f5csp381987wra; Sat, 27 Jan 2018 01:46:24 -0800 (PST) X-Google-Smtp-Source: AH8x224py0kbAC+qrRDXiVUXzsGWfWtv7eVxwybdkuHNiP8y0LieuuqMe9aWKATGwTQn6WIY7I6N X-Received: by 10.98.63.93 with SMTP id m90mr21533282pfa.231.1517046384400; Sat, 27 Jan 2018 01:46:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517046384; cv=none; d=google.com; s=arc-20160816; b=gHMVpWPBPcys+IAExyMEjAXOziChPePxA8kTVR7L7lkzObGAH6Oppc4CR8DDw+7HvJ B8i8Ujejnw6J58zGBuiLhHmLXobUeBXYIdmh7msV+jziTBuO2zEHsbyzCpdt83Sl2Yn2 O96QWNWLjvEMpmxhJZOdRCdyl984Q+pdD2Ue7ms46LR0Huil+7OWXyqxYxR+DGfvcTjU cnOGWhrIRdO/N4pHDY2bpRsV+faMQV7RdPt3x4qiPfMjC+1oDmwG9ADwZ+7vQrgQT6sM eSorDPKde8zP98dYY3kdCJuMwpHPNHy4hWMDZeBOQWOFnY4Wo8TorACIK+s5w21Wv/08 rjEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=Y9QDIRpnvBg23LxM1S3r38xQj2a1BCQLXMnPea1p8KI=; b=iLuMXn+s4nW075w1vvavXlg6U44gmXhdWVleVS9TafjOyfpr86ZRD5WcZpY2DPg0s2 QWJettOrXeaGfPrgB/hVTuAjddRjYEZalKH1osaaV02QpAAdEZhTTucARPcq4BkZtu2w UvnlcwjPqLeQ41RIjIcK0wYp6TT75VCy5GN2fZ4QfdScKuA8N06yYXhYjR7x9YkQ0/E7 3rwHmGKgrygAzNMGBswmFGMxLkdeV0M7NCLhfBM2kcBFh6w9WVcjZiX4fh/oJDkbAFbF jG5hCTs1L08vxQJWO7YZSA6glC8dAY6unWCJD7HBdiWLEM9AQsUpOhLlaUDti8mZEXtH SJKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b25si4192190pgn.721.2018.01.27.01.46.10; Sat, 27 Jan 2018 01:46:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbeA0JpI (ORCPT + 99 others); Sat, 27 Jan 2018 04:45:08 -0500 Received: from mail.CARNet.hr ([161.53.123.6]:37305 "EHLO mail.carnet.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbeA0JpE (ORCPT ); Sat, 27 Jan 2018 04:45:04 -0500 Received: from cnzgrivvl-t440p.carpriv.carnet.hr ([161.53.12.131]:47548 helo=gavran.carpriv.carnet.hr) by mail.carnet.hr with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1efN2j-0005F9-Vb; Sat, 27 Jan 2018 10:45:02 +0100 Received: by gavran.carpriv.carnet.hr (Postfix, from userid 1000) id CB73229850; Sat, 27 Jan 2018 10:45:01 +0100 (CET) From: Valentin Vidic To: Greg Kroah-Hartman Cc: Valentin Vidic , Marcin Ciupak , =?UTF-8?q?Simon=20Sandstr=C3=B6m?= , Marcus Wolf , Michael Panzlaff , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 27 Jan 2018 10:42:16 +0100 Message-Id: <20180127094233.20234-7-Valentin.Vidic@CARNet.hr> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180127094233.20234-1-Valentin.Vidic@CARNet.hr> References: <20180127094233.20234-1-Valentin.Vidic@CARNet.hr> X-SA-Exim-Connect-IP: 161.53.12.131 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on rigel.CARNet.hr X-Spam-Level: X-Spam-Status: No, score=-2.9 required=10.0 tests=ALL_TRUSTED,BAYES_00, T_RP_MATCHES_RCVD,URIBL_BLOCKED autolearn=ham version=3.3.2 Subject: [PATCH 7/8] staging: pi433: fix CamelCase for regValue X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Local variable storing the new value for dio register so replace with dio_value. Update regaddr to dio_addr to match. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index ef56deccd0af..42c2e1c6b386 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -505,27 +505,27 @@ int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value) { u8 mask; u8 shift; - u8 regaddr; - u8 regValue; + u8 dio_addr; + u8 dio_value; switch (DIONumber) { case 0: - mask = MASK_DIO0; shift = SHIFT_DIO0; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO0; shift = SHIFT_DIO0; dio_addr = REG_DIOMAPPING1; break; case 1: - mask = MASK_DIO1; shift = SHIFT_DIO1; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO1; shift = SHIFT_DIO1; dio_addr = REG_DIOMAPPING1; break; case 2: - mask = MASK_DIO2; shift = SHIFT_DIO2; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO2; shift = SHIFT_DIO2; dio_addr = REG_DIOMAPPING1; break; case 3: - mask = MASK_DIO3; shift = SHIFT_DIO3; regaddr = REG_DIOMAPPING1; + mask = MASK_DIO3; shift = SHIFT_DIO3; dio_addr = REG_DIOMAPPING1; break; case 4: - mask = MASK_DIO4; shift = SHIFT_DIO4; regaddr = REG_DIOMAPPING2; + mask = MASK_DIO4; shift = SHIFT_DIO4; dio_addr = REG_DIOMAPPING2; break; case 5: - mask = MASK_DIO5; shift = SHIFT_DIO5; regaddr = REG_DIOMAPPING2; + mask = MASK_DIO5; shift = SHIFT_DIO5; dio_addr = REG_DIOMAPPING2; break; default: dev_dbg(&spi->dev, "set: illegal input param"); @@ -533,13 +533,13 @@ int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value) } // read reg - regValue = rf69_read_reg(spi, regaddr); + dio_value = rf69_read_reg(spi, dio_addr); // delete old value - regValue = regValue & ~mask; + dio_value = dio_value & ~mask; // add new value - regValue = regValue | value << shift; + dio_value = dio_value | value << shift; // write back - return rf69_write_reg(spi, regaddr, regValue); + return rf69_write_reg(spi, dio_addr, dio_value); } bool rf69_get_flag(struct spi_device *spi, enum flag flag) -- 2.15.1