Received: by 10.223.176.5 with SMTP id f5csp1295067wra; Sat, 27 Jan 2018 21:26:41 -0800 (PST) X-Google-Smtp-Source: AH8x227bqc6Hfn2BzRNjxafIgQLY2htoxpNsGZO1GwmQI6BBq2w1eZCiC/dQS3t7qIMQRC6mLwVk X-Received: by 10.99.124.94 with SMTP id l30mr18535995pgn.108.1517117201839; Sat, 27 Jan 2018 21:26:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517117201; cv=none; d=google.com; s=arc-20160816; b=VTIYr9KTfPhgg7A8EjZdNzoHyTWVH2DnOD8ga7kQ1He11bDkgmY9fy2OL1FzFT6OXr q3mMJFNnltMRhymImy6GJdM1yi5rKJB6OYgGPDnUxj8qp56Pcq5PT6UIBo1iMscwqvH6 IO2pG760TKUx8udZtSkv8zgNQFsLHMBTEVUGTuzBAefx/S65DO+MiPjNX14qbjrrIhw4 emB9ExLN9fZqpi5yDP6oWZtI+lFcG6vxftNuj4VObvCYTMTHFEmZtFUCBHx/PEsDPR6A IpjCw/fv0Dz3crayVOlQNSh4XRSNZUHGM0c93U60L65/LqHGMXRyPLpuYmHlcvdzTagZ U8mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=p7EezD6SqV/X16P9f+a270gbpClqI7dLgIRLdB/ykyA=; b=Qe//61ATqXuq5ZhpcgJ7JtF+VACI4DctaeHQeB0Ygtl6fH5sLyXEA+POD/KlTezyhM MUdNmgt3UYRolBBsvDceO0XT6YDHkbT16aoNDtVGngEwe5foAT6BUgbZmqRS96HigU4S U+92zA650JiXJRq667g3V2dC6oXkrkis5K+LZnQ4lE11op7oHI6u1k8E5NR+8pf7XGlP tWtAlMwJbYt/3PGRtuqp1NGus0YmQiQF8siGQgA4Pltktr4jUfjEujkaprhnICaZsIJx bJWwZP+j1CUdwaxFaxi9H1zn7I7ae2E2EPZ3ftImOBIj9XB9p6O9bLyGo5lTynn75Sjb PYDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YNDcJJ5O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l132si9034259pfc.202.2018.01.27.21.25.59; Sat, 27 Jan 2018 21:26:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YNDcJJ5O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbeA1FZI (ORCPT + 99 others); Sun, 28 Jan 2018 00:25:08 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:38023 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbeA1FZG (ORCPT ); Sun, 28 Jan 2018 00:25:06 -0500 Received: by mail-pf0-f194.google.com with SMTP id k19so2311385pfj.5 for ; Sat, 27 Jan 2018 21:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=p7EezD6SqV/X16P9f+a270gbpClqI7dLgIRLdB/ykyA=; b=YNDcJJ5OnWdvjyRGTbjs/EJwQIXdLMARdn3zoWrT7MqLyegJ5dTSNDKIh+NUFbAvYp Dk2U2zvQ5x+12fZtg8UYvS7tucV17XMNV1gFUTff2nvVSecpu0ciqnhggVfzC6UFg4MV rycchH6JkL/F9nUnOjCfCeU3zO7SssPvCAXo9YQsnjIA987O/tYEQ7xvSU+0vcHYg3Yx IhZw45rLQPs3B2GUwYdj665fO59DTp3YOO05ijgfReyclpKYC1egbzXzWCkqGeYoF1U3 Bwgg787UKh58e//bdioX+hrctwlfkT+JZA0+UD0bMcJbW4Sw5gEfL8kvQL4/CAEhg0Bk WqgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=p7EezD6SqV/X16P9f+a270gbpClqI7dLgIRLdB/ykyA=; b=o+RecS84kygUE4XGntevdIkjFgV7a7NcgSa01QmmjxELN/RMIm81I/lxxcvzm4quUX YiPQ9Tbqz5auwzoa3oeL9LzBWQP8WvqBVDOWf6I4wCus12rGkiL1X0OqmmtUvtuenbBF Au2AdbPbNeA25zLl/jNOsfI7gs6USvVLtfLwDDEbBEKeLkei0/qUAMzjjwotaJAUvdnB Nz0RGp+VT+om6wP0Fvzx4Hnjpz1xOdfFi4RxatNYuCAUY3igzQBO4arqmAtYzMR1BpVN rWHv4sxE8dPVnKexPkHEtCBnqldJB5By26ccqpu4dXW5nMR/SVNenpGUOScGM63s2+c0 0uzw== X-Gm-Message-State: AKwxytcs5iSRa3tVO3D0sGmB3afGY/xqzjN9RkwCsgG4aZ7D4AKhKi6Z Apy6kIuCwiyZLq19vxauAXrUikqx X-Received: by 10.101.90.10 with SMTP id y10mr19292106pgs.445.1517117106029; Sat, 27 Jan 2018 21:25:06 -0800 (PST) Received: from BlackPearl ([47.31.69.88]) by smtp.gmail.com with ESMTPSA id j13sm22175396pfk.112.2018.01.27.21.25.04 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 27 Jan 2018 21:25:05 -0800 (PST) From: Sumit Pundir To: oleg.drokin@intel.com Cc: andreas.dilger@intel.com, jsimmons@infradead.org, gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: lustre: lnet: return of an error code should be negative Date: Sun, 28 Jan 2018 10:54:55 +0530 Message-Id: <1517117095-12643-1-git-send-email-pundirsumit11@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return value of error codes should typically be negative. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir --- drivers/staging/lustre/lnet/selftest/framework.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c index c7697f6..0ca1e3a 100644 --- a/drivers/staging/lustre/lnet/selftest/framework.c +++ b/drivers/staging/lustre/lnet/selftest/framework.c @@ -187,7 +187,7 @@ sfw_del_session_timer(void) return 0; } - return EBUSY; /* racing with sfw_session_expired() */ + return -EBUSY; /* racing with sfw_session_expired() */ } static void -- 2.7.4