Received: by 10.223.176.5 with SMTP id f5csp1704054wra; Sun, 28 Jan 2018 06:42:08 -0800 (PST) X-Google-Smtp-Source: AH8x225IE9+q6ZzVK5Ny6C1VtWMG2FzKQdv/OBHJOZO0mvAse4pdepm3okARxSkpG5WU/Evetc7l X-Received: by 2002:a17:902:b2c6:: with SMTP id x6-v6mr19668879plw.340.1517150528615; Sun, 28 Jan 2018 06:42:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517150528; cv=none; d=google.com; s=arc-20160816; b=tT1H99l88bgaXKrSoumY314/aa4Gucwk+NTMOzuCID6+o4XTx/aj4QgHVfqgBl4bIC rLoRc8aVeSirZGNRoQ+oP4JLHuIAFpFdiVg2FTFukuq579XKfCOjVi/4bNkvrkC74NEY +QdIlcDDwwrd/K324bwYKe9Y2h4pI3vsXtQFISTUueCF7QU3+i9dA5diUgU9IBgPWnEx /AGMt8rOWg9fv6AmgqIzbVZhv0QS8XMmuqWAeQxTsOpdDQ9id3zKVQr5S5jRm0T63rlI 50kNlfd+/Sn96oAMD+eSReEdgJ38RxK3Fj//ToqvJ+/byyKzmiL2QTC4kO78pdGFRi4J sGYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:spamdiagnosticmetadata :spamdiagnosticoutput:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:arc-authentication-results; bh=Z4lRpLfRUjV4MedPOL7UGFjZ9StuNcJbqE38ksVY1vM=; b=EGj82jTHxi6htRUGfQVmSafeZu0mNKJxj9i0AJWAaWK3vzaTLP+ZIgLuYJFs5aMB7s Y60s5PYyX7ICf8DZ9Zf95jmWzizlxg4zp8ok2s7Y8KyMrd+7pNXNNW03YWfSR9fCpJzj g2PNYK5jH12r5pY1TS4c1b8yZ741rtXLxcAgKCj8vemIzPiUpr++t3lP0U0GtY91+rc9 gSHSjYzVjgjVG5XlcJrWHE2crPRaGCv778b+53raIy8vumN+pKptBU0buvMSlXdLSt+1 XCuMrmJJOpH+XUkmwxk68t9C8BO0DxcDlO2TcYeHySPTj+u57/GBtEjMWoBVeAcOHMrD ryVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=qdBIQRTS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6-v6si7052597plx.696.2018.01.28.06.41.54; Sun, 28 Jan 2018 06:42:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=qdBIQRTS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbeA1Ol1 (ORCPT + 99 others); Sun, 28 Jan 2018 09:41:27 -0500 Received: from mail-ve1eur01on0057.outbound.protection.outlook.com ([104.47.1.57]:4440 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751496AbeA1OlY (ORCPT ); Sun, 28 Jan 2018 09:41:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Z4lRpLfRUjV4MedPOL7UGFjZ9StuNcJbqE38ksVY1vM=; b=qdBIQRTS5DsjKBFsoTpCzVgsf5mne2EpGSQUZYrxrSvDTk93+2/1b2VYwK0E1O6NH9XVNTqDpAI5TCZpJeCz/29mUCLkf4klm4lWT66VBvmKwdLJXL0/CJZplL4mb0NmtvIbWhCDSx5YRdLZtoNGzYgz7WZ1zo4kK63QUtS+a7w= Received: from AM4PR05CA0007.eurprd05.prod.outlook.com (2603:10a6:205::20) by VI1PR05MB3263.eurprd05.prod.outlook.com (2603:10a6:802:1c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Sun, 28 Jan 2018 14:41:21 +0000 Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::201) by AM4PR05CA0007.outlook.office365.com (2603:10a6:205::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.444.14 via Frontend Transport; Sun, 28 Jan 2018 14:41:21 +0000 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=pass action=none header.from=mellanox.com; Received-SPF: Pass (protection.outlook.com: domain of mellanox.com designates 193.47.165.134 as permitted sender) receiver=protection.outlook.com; client-ip=193.47.165.134; helo=mtlcas13.mtl.com; Received: from mtlcas13.mtl.com (193.47.165.134) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.444.13 via Frontend Transport; Sun, 28 Jan 2018 14:41:20 +0000 Received: from MTLCAS13.mtl.com (10.0.8.78) by mtlcas13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Sun, 28 Jan 2018 16:41:19 +0200 Received: from MTLCAS01.mtl.com (10.0.8.71) by MTLCAS13.mtl.com (10.0.8.78) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Sun, 28 Jan 2018 16:41:19 +0200 Received: from [10.223.3.143] (10.223.3.143) by MTLCAS01.mtl.com (10.0.8.71) with Microsoft SMTP Server (TLS) id 14.3.301.0; Sun, 28 Jan 2018 16:41:18 +0200 Subject: Re: [PATCH 0/3] IB-iSER: Adjustments for three function implementations To: SF Markus Elfring , , Doug Ledford , "Jason Gunthorpe" , Or Gerlitz , Roi Dayan , Sagi Grimberg CC: LKML , References: <00e8b16f-c856-8999-fe93-2724a2f6a56e@users.sourceforge.net> From: Max Gurtovoy Message-ID: <5b2d2862-5694-a10a-be3e-17d2f4687d1e@mellanox.com> Date: Sun, 28 Jan 2018 16:41:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <00e8b16f-c856-8999-fe93-2724a2f6a56e@users.sourceforge.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: he Content-Transfer-Encoding: 7bit X-Originating-IP: [10.223.3.143] X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(396003)(39380400002)(39860400002)(376002)(346002)(2980300002)(438002)(199004)(189003)(316002)(50466002)(5660300001)(58126008)(229853002)(65826007)(16576012)(478600001)(7736002)(64126003)(305945005)(356003)(2906002)(106002)(65956001)(8676002)(83506002)(106466001)(3846002)(47776003)(6116002)(86362001)(6246003)(67846002)(2486003)(23676004)(336011)(65806001)(2950100002)(110136005)(77096007)(16526019)(59450400001)(186003)(4326008)(31696002)(26005)(54906003)(36756003)(31686004)(230700001)(81166006)(8936002)(76176011)(81156014)(53546011)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB3263;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:mail13.mellanox.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM5EUR03FT064;1:zzUOweQGhkOmzKZo6OIPxrpPYTU7TpavwvQGyJxgOSxPpr7dmyC/6I3+EL9Ry7oyJf70wF+kofzFagmz+vxlBJdCBqwtX1utEreSRqEQ1yU5XTpOFh/LjFlZYoUSy4jd X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0108c5cc-5e0d-425d-eddc-08d5665d32ac X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(4608076)(2017052603307)(7153060)(7193020);SRVR:VI1PR05MB3263; X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB3263;3:hoAvW3h7L2voRvfDVNMAN6cC6GsgqwCSeqfP6HT94m7GlKEDaCvzOoZ7qYyzGHU3/29a3L30RzIIAksRnP4SImGcgZ+QNl02Fe3/l6NjEg9k4KThneoyjMQVpLic9jzpHcwqisu3B/GsYB4yCTaozjZxmXvDTYD6xa0d6J46Cgr87650vJjWYXhlsGDG+rjYuJyuH/oxjXDDqtvlriaBmRohwK0FQ8b/LEZSLlsWbkLzaZEPpPU+SoMUf2ZJQO/ktxPSCrknVDO1x1jshSpeiMtn9ugNu8nx3HTCxloPWggZorGGYLHWq5y/fk7gsOzDSvg2bcCC65OlLGonUFfnBQvXyTVZZZfxu/MOBf0IjTs=;25:HMKGo1OmZpX7uTnTaI9LicLrInjuifDDVd+qM4SaaTDwd7cRVO7Pjkwt5sG5dqK0T/v/3kAgGBVVt/n2yV41wOteX9HZrxKOucWcQsbElP6hskSYMpIMfg8psLRG4gCiDw/dO/9zZCaYPK98iR2eKrs9VUyZt2hyYAM7k/NAawNFy+gKr/TI8S2ow9ClGZAoEiVWu88+QOKvJaXv4n9Z4UUnUWn286sAd6t/kB9J9BvlAaWIZQjf9dujFtWx7DzNt2F1AY3yyYH2rMwbTBoPhP1uf6iMwjki6t59xp87E8o9QrGOK9gH7HomPYNlSuE4PIE0ybNPZHe6uk7S67SLdQ== X-MS-TrafficTypeDiagnostic: VI1PR05MB3263: X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB3263;31:5DzPMsDJ13qHIksJICrc2ikgMfsUAj1m/4opjC95kz/26ALq51d34SlGk7DYOphFeH/qELSgoIgF/Ox8H+XeALMLHB2sy31ED1xbl0fY8srWbWRVX9j7zKZiIbBpRZPW7kWqNrtgkjBWX18mp6pBul0UKysyp0DQT7jCK3fCz3MwFXIZ4nh2045hsEkGW3EA7liakTf4VXeddyJgP00SeVuK5ny6XNxElPktfcO5oZY=;20:23WmXIYS4sNmHdH8cbhgBKKp80p9NumV+Mf2wAz6ZMcMeqFgPAfV4oynyxltG+Y7jh7336fj1iU/mJ775ZH41P+faBoYv10SBfLMtMZBXgpMxLTGeXnHx7uhqcGfdj+3nhNbzvcJnxBxkWJoaPb15FZPkskar2aSKTwPrplkHT7FAUpptHxK5EAOlWGpccjBanmkMvZW0RUf9qFfHI4khRSo8uoJY1uf5B8gjUNakZ7Usg05N5lOoNRmoNGJ23z4nB6GjE8iZVwCNWP69sXVZe/cnvKm60ZbIsRNUqUAWW3aWriz/AsxlN/Vkhv4D5uQXQmG1cskAWBN775YeVckIcyCu+nYwEpQqLXv7j0Ajvgy1Itrxp6BpvSpR2zp5Q2zanbgvZljVucvReIVzst4su05mAYp6L75gUoaV+ZCIGiOCBNz69bejpPxIaF+xZu8A9a7lZvbGzHx4305S0ZNZ/3K4EOb8ELyQWd4ZBBoD1/XV7/GejsYzQoyN8Q3wYCg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42262312472803); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93004095)(3231101)(2400081)(944501161)(10201501046)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:VI1PR05MB3263;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB3263; X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB3263;4:05pS9vv/ImKba8TpVPPz7jhwdS4tC9FeX9oRGzF+04YUJMyi4aVMGRngHzY3i4KBDHKGxorkF/S9b8vqfoO2qR958wgZYXA2b/4cIP8pLcRLLK5wdwdkMwARhQ0plK3gxfvIMmc8eqURCjld7WWpX3CpWblIZqKGFwEFnflpgwo773pD0Kmuc5/12GCHoTIjMMqZnwYcobUVUcWZmyp0ummQJ4jcErXkjxcmBavKV9l/H4hDypm4dfVbPVMmYmD6MVLFh6jEPNpELwqIwQinn6wiu0HeN/d8eZiaQDihJWMhBhsD2fY/lHEykkF2/zP8 X-Forefront-PRVS: 05669A7924 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA1TUIzMjYzOzIzOmFWK2tlZXljWlI2dFNkS0hDWU9QbENoNWRG?= =?utf-8?B?d1NMN1BzUlYzK0ZQOUUwRFJIQXZLcWpmaDQyNlY4V0VTZ1pMS3E4bWUzQ1VY?= =?utf-8?B?N3hnM05wM2g5NkhuR01BZElwNTdyWWExT1RCWEhkQWY1ZGUydGR5enAyS3Nu?= =?utf-8?B?b2VqbnE4TVhBVVZVblNWZWtuYTgrdms1cHc3aEZaUGFlUnRmNzlRRUN4eXMz?= =?utf-8?B?Ymo4QVBBZktHQ3pmc0gyQnk1VGc1YVRFRjdzZklUT3FDZkw2elpxNjJzdXp6?= =?utf-8?B?cDlsWVhFZGw2UFlPWGZwZjhRei9KdG0vZUYvbFlJMHJoS1ExV2xJejRzQ2lM?= =?utf-8?B?SmZ6R0tMUE9WUHhFamtWR3JqZFJYRlBMbkJFOVI0bVZRV3hubXpvVVBNbkkz?= =?utf-8?B?aEVET201VVJVQzdlQmd3OFFlT2tFYmdhcWhsWjZYangvQnhlSVVtSHNNQTdm?= =?utf-8?B?amxnbThXTHMrcUtNRjFFZ2J2ODJESURhQ3M2VmMzZU9HbWNYVjBlcVJzR1Fu?= =?utf-8?B?L3RVaVFha3krOUVhQ3NqeDFIVGhGS3FYMU5HRGw0QlFxL2J2ZEF3czN5UVRP?= =?utf-8?B?aUFQcWVyVlgvMmNuNngzcnNDd3dneThVTFdSMC91b1k0eDV4SDVobTJsV2or?= =?utf-8?B?NWl6blpiTzlCSER0TzkxUm5NalNQc2hjLzRCMmoyV2hILzEzenUvS2l3YWo0?= =?utf-8?B?M3J3Y2FCWDhsY1dsbWRGdmxPcmMwREY1REFWWTBqa1pLNVhwNXRobzdSRHBt?= =?utf-8?B?eUVRV0ErczJkY1FGc2JKNlh4OS9BbDhNTFdZQUhqTU9WWFBJSjZJR283bEI5?= =?utf-8?B?M0I1WkxXYUs3aHZoQjI5RlREQVhOeWtqaUR2VzYxeTdGeHdObEhNUTVIN2gz?= =?utf-8?B?dHE5ajJiaEFpSjhuTWRHN24veFZ4cUhFbGtYMmhyYkNVRm5mMy9pY2xkc1Vl?= =?utf-8?B?WGg2V0hreVUvUlpUVWVVUzYyMDVZTStWcTdXMEpHVkVDTnpRQ3I1cFV3TVpl?= =?utf-8?B?b2w4ZHdZSXBISkRTbllMK0pEeWl3KzRjdFBLR3ovUmZRQS9KcEE1NWo3RU8z?= =?utf-8?B?MTltc3lBV2JHakZKREZJb1UydXcxSVpGSXhlYTkxM0JvQldQdjgrMVh6K3dX?= =?utf-8?B?eVJXRDlBYkh0SzBRcHlSciszNW5aRjJsMllldGQ5cWI5TWdEWGxlQ2t2WG5M?= =?utf-8?B?amw5VDlBdnJSckd3aTkySHlOUi9CMFd2M0dmVUlQMm5lcm9MR0V1OFNGUG0x?= =?utf-8?B?aXNEb1NKNGZDdDJkTHRPbTFlMEF5RWZLajE0N1RuNlc1RVhVWFRXRkw4bkFE?= =?utf-8?B?cFhCTWRZWG0yOFBQTGdTbW9makFVWXBTV3A5ZTErenRYdDBzYlFYS2c0emFa?= =?utf-8?B?R01sdVorVUt2VUFDMzZDbkFnZytHc2t4YVhGT2J1YWcvQmE4bVI1NlRCUEw1?= =?utf-8?B?SmRWWE5wdjdIajM5ZlJJTUF6cWNQZnJrUFB6Ym43OUlJREptMW9pVnpGTFZ4?= =?utf-8?B?OTBua3VSSVVUdXk5a3ZORnkvZ0RBN1VJS1lPYk9iOGdaTUh6UzZpRWsrZ2FR?= =?utf-8?B?dVBtTjBsd2gvZDU1TGEzbWVCR2FTQkMyWEovUG80VXJWbXNEMS9IMjlLcEtY?= =?utf-8?B?TmxLWjNmNU0zV2lqaHNNeXgycGI5enlGdTk4OUk2cTdRb1A2UjlsS2hlanZt?= =?utf-8?Q?HmrPvWNH0VPVqaNksoLFa2GOk8z2V2OFHtX2F3M?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB3263;6:Ggw1ZfFsAgOiXFZN2oGmGD2lbI/c4/Yahe1nlqBKNNEF7yaAfFB5aTAVEoYANN79oMPGxE+Am6LYUhkijovk/IozMI9v18HOinH3DA8Iist3oYGhyxQ+p9jd7NEcbWskGXr0lh5WnML1GFrlaZEDuH2ev3NWWNw9QXrM48ykTrcYuMYMDbm5Th15+GWZ6+oI5Zgmi+7bRT5+q7e1VY2rrkD4QyU/P7jn3AZOePSu7Z8wpZ3XQue5MGpq/wbjgEaiZ1dhTS68H3FWBjN3mOWavcfCwfPuAnNoF+9J9Po9z0XZjrHxEWFOgow3QKb+n8/jMurAyKM8/bD2sQd54d64yum1BYeSLaZpYt3EQZ75/pw=;5:oRvXMsO5/yfLoy3VtKJGEC1h1Ewxs1KKU9BnNaaQJnF8KipHG61eNhIQZJz0DW5Ms9jrLIlSBHI4yxzTnQ6TkR6PKwBcVwODNZn6hHjSMGhhzVqaMnX2GFUQH878D/JSncFkwM4DIPjpEZ3HOGvM9LEoR/5EfRWE5Csc/LrrIM8=;24:6mriU/kzayHnku7EWvLeRK82kUsLDB7LKuVr4vM86ZV+eSk80JIqQ3+zvUAZUamL/RNHlgvN76rarBO7lAtvbIWpTx8pviwfeIYpBO9SyYw=;7:qZ/r0RLOc1J8nDjlmGQcW5znV/6OMSxUmAO5Z7DvKmVob2JLCNiFfJ2SPHaqj1tYE/SBcvRc+V7g0jRFQPfrGODHajVI5LYQUz88chQGOuwvbtkcJb3rTJGV1emAq4Gj1pIn7EvQOndjOQ9kR38lFlS7CszQMwSDE6zYwze16Q/IeCNaDJqNxZe+YzEnu3IS2/p0Uspz5QElihWNDbhyHOpRAMqnIKxfwvcjpKEUjDWmJhtFVXF6wa/0H+50j5Id SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2018 14:41:20.8166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0108c5cc-5e0d-425d-eddc-08d5665d32ac X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3263 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/2018 8:17 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 27 Jan 2018 19:02:34 +0100 > > Three update suggestions were taken into account > from static source code analysis. > > Markus Elfring (3): > Delete an error message for a failed memory allocation in iser_send_data_out() > Delete an unnecessary variable initialisation in iser_send_data_out() > Combine substrings for three messages > > drivers/infiniband/ulp/iser/iser_initiator.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > This series looks good to me, Reviewed-by: Max Gurtovoy