Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516632388.git.meghana.madhyastha@gmail.com>
References: <cover.1516632387.git.meghana.madhyastha@gmail.com> <116d160ba78be2e6dcbdcb6855622bce67da9472.1516632388.git.meghana.madhyastha@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 28 Jan 2018 19:15:08 +0200
Message-ID: <CAHp75VcM3-D+kwzzGutoFXo9-WHK20TW=STqMku5mqcUSDCDyw@mail.gmail.com>
Subject: Re: [PATCH v18 03/10] video: backlight: Add of_find_backlight helper
 in backlight.c
To:     Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= <noralf@tronnes.org>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel@lists.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 22, 2018 at 4:51 PM, Meghana Madhyastha
<meghana.madhyastha@gmail.com> wrote:
> Add of_find_backlight, a helper function which is a generic version
> of tinydrm_of_find_backlight that can be used by other drivers to avoid
> repetition of code and simplify things.

> +struct backlight_device *of_find_backlight(struct device *dev)

It looks strange that of_ prefixed function takes struct device
instead of struct device_node.

-- 
With Best Regards,
Andy Shevchenko