Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 28 Jan 2018 14:09:03 -0700
From:   Jason Gunthorpe <jgg@ziepe.ca>
To:     Joe Perches <joe@perches.com>
Cc:     Corentin Labbe <clabbe@baylibre.com>, dledford@redhat.com,
        hal.rosenstock@gmail.com, sean.hefty@intel.com, swise@chelsio.com,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/cxgb3: remove cxio_dbg.c
Message-ID: <20180128210903.GL23869@ziepe.ca>
References: <1517152289-25052-1-git-send-email-clabbe@baylibre.com>
 <1517156662.765.10.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517156662.765.10.camel@perches.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote:
> On Sun, 2018-01-28 at 15:11 +0000, Corentin Labbe wrote:
> > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups")
> > 10 years after, we could remove it.
> 
> OK, now you could remove the prototypes and probably
> CONFIG_INFINIBAND_CXGB3_DEBUG too.
> 
> There is a DEBUG test and many uses of pr_debug
> that would have modified behavior.
> 
> The pr_debug uses would only be emitted via a
> dynamic_debug enable and the #ifdef DEBUG is
> probably not necessary or useful as it guards
> a BUG_ON.
> 
>  drivers/infiniband/hw/cxgb3/Kconfig    | 9 ---------
>  drivers/infiniband/hw/cxgb3/Makefile   | 2 --
>  drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 ---------
>  drivers/infiniband/hw/cxgb3/iwch_cq.c  | 7 -------
>  4 files changed, 27 deletions(-)

Yes, can you resend the patch with Joe's hunks as well?

Thanks,
Jason