Received: by 10.223.176.5 with SMTP id f5csp2158036wra; Sun, 28 Jan 2018 13:48:01 -0800 (PST) X-Google-Smtp-Source: AH8x227vvTQi+MtDuHeLHn9KD63u/UIKLSdwadBn5R4tAw5bwKLX3kZFcwFsDQgJUZhWxsqnBClE X-Received: by 2002:a17:902:7006:: with SMTP id y6-v6mr10032991plk.35.1517176081756; Sun, 28 Jan 2018 13:48:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517176081; cv=none; d=google.com; s=arc-20160816; b=yR3BRrynYNGjWTPDbf9TCmi1MB9yPuqJhLS/wieAiTJYy0nZYGvCLVsfote3nZZIhL b7n+VL0KIOLhl5jKCwwfcOYfRslpMdvqID7wi9fZ1qeY2lqjAJLp3xp0XX8vtMc+J+yt XajY5qj/CSWr9dJ766K2qnzH4Ai3xzXaWNVH+v7kQml0ChiCexPRhWjFeLmfaje1kMyE wZxpsyHTKGOnvOUsPn8sVvY7NID+ZLygfp5Y3V4+5AZF2FL11kOHEEVfmFflKMUTkkDW Lx9zLPoNquKcSpegihHvkUpqGemNYQP/rkFgZZsVippCBNSdf45CE+iS/2rIA6PYtaMN heCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=oE7qJ83dXEm0f3h4R9SI05SZOmM1rb66qpvYV2P6TNg=; b=HhuoOSraxWWjRk6LO/akMn2aeS1nIwUQV7NoG5uwr5Ed94pkEj9CI8gEfxSLivqPiT dYZbneuXiDx4Gf1vflW3FoZ6IgnueEar2M7Fo80pS3XWQetYv4KlrhPvHRSeaNEf5jkL Z+XDTyTVXN17/K3EmeZ6YKtslXnIZcwKoEniKbQW/p8z1EgPEHIWKsup5ysXo2T3U+tT WGfYwTkprF3KO+Uq1wBkio8zil6Wjz8FJWmm/IdqjY1BtkH4fpFD8ggGtv/0ZI9d6jMA 2EGjQ+GuXw7reImI9hBWfkkehvtWI3dOVCDW0p3njvwtxvOt+BgrCJyHhPUmR5Tzwcv0 OjFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=PeyPQA+9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d25-v6si7738938plj.188.2018.01.28.13.47.47; Sun, 28 Jan 2018 13:48:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=PeyPQA+9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbeA1VK6 (ORCPT + 99 others); Sun, 28 Jan 2018 16:10:58 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:39350 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492AbeA1VK4 (ORCPT ); Sun, 28 Jan 2018 16:10:56 -0500 Received: by mail-wr0-f195.google.com with SMTP id f6so3457076wra.6 for ; Sun, 28 Jan 2018 13:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oE7qJ83dXEm0f3h4R9SI05SZOmM1rb66qpvYV2P6TNg=; b=PeyPQA+9C1Gu3AvPOJAWP9GbdA8VyKO6SsjifnJx2c7nDUMNvqyXpL+0kCeyKac8a+ +VOPpY47A+enFUwuPmgsoP0sYub/44DNP3KZv0Pp2GrZGRj7vXEBdjbPU9e0APvIbsM8 Ao1ifAFnZO0UiSE0EHtoV21bE1hhTr14qYnY7AczReF7dK8Xhk6VD48vrjtnLANYi21u VZRbv0Qhr70F2NX0vVwuiIcksTA5qCG0OenA/ke14UjCR/U4amDy9l8k6QKKbVr+Ao8H ZzcmQhsWIuFMvWzbx8AFNuIaq4bdkyTNf0ZZ/9udRzfQlB6pYoDB3lJzxGGFQiq68B/D elUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oE7qJ83dXEm0f3h4R9SI05SZOmM1rb66qpvYV2P6TNg=; b=pHrgH+LaZZbmaUGzAmiQVFQCjhKqzgPg+Qirvg3cdwLAhK0ojwJq8uo3+pWBQk0YQT U7zCjArrjHKTL4OtMABCUI9Wc8a9VcjnaixdHxgZ/wwcpGCQxYQ8gx5S+/ZVGoctXqO6 q3l6yQxP6aBLP8kb6k203SWHja/z29BU9y4tacU/m5g9K0AIIryJ+EcoErLqAGUN4w1v FqArwwWT7qvtTyIFGFAojwfrTtUIJGzzMYcyRA3XgvgJlLbZwO4vQWHzMzxrdGiwygby pR3BE870ohEmuusQFGOE8CkE5AdXV1NzNJ7MWRVgSYnnHjUnPS9beoPiv8KFHwqOcPO5 cXJg== X-Gm-Message-State: AKwxytcHCGrsLwmcwSpb7qZy/ktzcLdgo3lBG03aN0l6ShljBt6r7wCQ 9OgAKK4VNcZ527olqux9HiopzA== X-Received: by 10.223.139.11 with SMTP id n11mr18271895wra.91.1517173854933; Sun, 28 Jan 2018 13:10:54 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [70.74.179.152]) by smtp.gmail.com with ESMTPSA id x135sm8232145wmf.35.2018.01.28.13.10.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jan 2018 13:10:54 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1efuDy-0006lZ-BO; Sun, 28 Jan 2018 14:10:50 -0700 Date: Sun, 28 Jan 2018 14:10:50 -0700 From: Jason Gunthorpe To: Max Gurtovoy Cc: SF Markus Elfring , linux-rdma@vger.kernel.org, Doug Ledford , Or Gerlitz , Roi Dayan , Sagi Grimberg , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/3] IB-iSER: Adjustments for three function implementations Message-ID: <20180128211050.GM23869@ziepe.ca> References: <00e8b16f-c856-8999-fe93-2724a2f6a56e@users.sourceforge.net> <5b2d2862-5694-a10a-be3e-17d2f4687d1e@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b2d2862-5694-a10a-be3e-17d2f4687d1e@mellanox.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 28, 2018 at 04:41:16PM +0200, Max Gurtovoy wrote: > > > On 1/27/2018 8:17 PM, SF Markus Elfring wrote: > >From: Markus Elfring > >Date: Sat, 27 Jan 2018 19:02:34 +0100 > > > >Three update suggestions were taken into account > >from static source code analysis. > > > >Markus Elfring (3): > > Delete an error message for a failed memory allocation in iser_send_data_out() > > Delete an unnecessary variable initialisation in iser_send_data_out() > > Combine substrings for three messages > > > > drivers/infiniband/ulp/iser/iser_initiator.c | 16 ++++++---------- > > 1 file changed, 6 insertions(+), 10 deletions(-) > > > > This series looks good to me, > > Reviewed-by: Max Gurtovoy Okay, applied to for-next, thanks both Jason