Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <b6a183234f0ad5a9a58c780c9cabbe29cbf40888.1516617243.git-series.maxime.ripard@free-electrons.com>
References: <cover.9e7b6a702e4d90a13d08fbe3b0a319cbf4db687f.1516617243.git-series.maxime.ripard@free-electrons.com>
 <b6a183234f0ad5a9a58c780c9cabbe29cbf40888.1516617243.git-series.maxime.ripard@free-electrons.com>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Mon, 29 Jan 2018 09:53:52 +0800
Message-ID: <CAGb2v64Ps0=vz0-Sg+UvpKABG7qjLKZ+QLV8EGUhpP+7co=WEA@mail.gmail.com>
Subject: Re: [PATCH v2 13/19] drm/sun4i: backend: Set a default zpos in our
 reset hook
To:     Maxime Ripard <maxime.ripard@free-electrons.com>
Cc:     Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        thomas@vitsch.nl
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 22, 2018 at 6:35 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The our plane state zpos value will be set only if there's an existing

      ^^^ extra word

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>

> state attached to the plane when creating the property.
>
> However, this is not the case during the probe, and we therefore need to
> put our default value in our reset hook.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  drivers/gpu/drm/sun4i/sun4i_layer.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
> index c448cb6b9fa9..03549646528a 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_layer.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
> @@ -28,6 +28,7 @@ struct sun4i_plane_desc {
>
>  static void sun4i_backend_layer_reset(struct drm_plane *plane)
>  {
> +       struct sun4i_layer *layer = plane_to_sun4i_layer(plane);
>         struct sun4i_layer_state *state;
>
>         if (plane->state) {
> @@ -43,6 +44,7 @@ static void sun4i_backend_layer_reset(struct drm_plane *plane)
>         if (state) {
>                 plane->state = &state->state;
>                 plane->state->plane = plane;
> +               plane->state->zpos = layer->id;
>         }
>  }
>
> --
> git-series 0.9.1