Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1517200880.10151.15.camel@gmx.de>
Subject: Re: [RFC PATCH V5 5/5] workqueue: introduce a way to set
 workqueue's scheduler
From:   Mike Galbraith <efault@gmx.de>
To:     Lai Jiangshan <jiangshanlai@gmail.com>,
        Wen Yang <wen.yang99@zte.com.cn>
Cc:     Tejun Heo <tj@kernel.org>, zhong.weidong@zte.com.cn,
        Jiang Biao <jiang.biao2@zte.com.cn>,
        Tan Hu <tan.hu@zte.com.cn>,
        kernel test robot <xiaolong.ye@intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Mon, 29 Jan 2018 05:41:20 +0100
In-Reply-To: <CAJhGHyACFahA2k0cX+=SngjfOV_uvCrTBbkWpGsRX4X5CGeZxQ@mail.gmail.com>
References: <1517030127-21391-1-git-send-email-wen.yang99@zte.com.cn>
         <1517030127-21391-5-git-send-email-wen.yang99@zte.com.cn>
         <CAJhGHyACFahA2k0cX+=SngjfOV_uvCrTBbkWpGsRX4X5CGeZxQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-01-29 at 12:15 +0800, Lai Jiangshan wrote:
> I think adding priority boost to workqueue(flush_work()) is the best
> way to fix the problem.

I disagree, priority boosting is needlessly invasive, takes control out
of user hands.  The kernel wanting to run a workqueue does not justify
perturbing the user's critical task.

I think "give userspace rope" is always the best option, how rope is
used is none of our business. ?Giving the user a means to draw a simple
line in the sand, above which they run only critical stuff, below
which, they can do whatever they want, sane in our opinions or not,
lets users do whatever craziness they want/need to do, and puts the
responsibility for consequences squarely on the right set of shoulders.

	-Mike