Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To:     "vinod.koul@intel.com" <vinod.koul@intel.com>
CC:     "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "awallis@codeaurora.org" <awallis@codeaurora.org>,
        "Zheng, Joey" <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH] dmaengine: dmatest: fix container_of member in
 dmatest_callback
Thread-Topic: [PATCH] dmaengine: dmatest: fix container_of member in
 dmatest_callback
Thread-Index: AQHTk1K7crr1vDON6EG8IuLHBXXE16OJy04AgAAamQA=
Date:   Mon, 29 Jan 2018 06:21:09 +0000
Message-ID: <1517206860.2845.2.camel@hxt-semitech.com>
References: <1516606108-40562-1-git-send-email-shunyong.yang@hxt-semitech.com>
         <20180129044547.GK18649@localhost>
In-Reply-To: <20180129044547.GK18649@localhost>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <7E4B5BD4395B7D4286C8CAC7276AE647@hxt-semitech.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Vinod,

On Mon, 2018-01-29 at 10:15 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 03:28:28PM +0800, Yang Shunyong wrote:
> > 
> > The type of arg passed to dmatest_callback is struct dmatest_done.
> > It refers to test_done in struct dmatest_thread, not done_wait.
> > 
> > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
> > Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> > ---
> > ?drivers/dma/dmatest.c | 2 +-
> > ?1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> > index ec5f9d2bc820..906e85d6dedc 100644
> > --- a/drivers/dma/dmatest.c
> > +++ b/drivers/dma/dmatest.c
> > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> > ?{
> > ?	struct dmatest_done *done = arg;
> > ?	struct dmatest_thread *thread =
> > -		container_of(arg, struct dmatest_thread,
> > done_wait);
> > +		container_of(arg, struct dmatest_thread,
> > test_done);
> This fixes it but one of the reason why compilers didn't catch this
> was the void arg. I just tested and used 'done' as the argument here
> rather than 'arg' and compiler was quick to point out the error.
> 
> So a better fix IMO would be:
> 
> -- >8 --
> 
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index ec5f9d2bc820..80cc2be6483c 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg)
> ?{
> ????????struct dmatest_done *done = arg;
> ????????struct dmatest_thread *thread =
> -???????????????container_of(arg, struct dmatest_thread, done_wait);
> +???????????????container_of(done, struct dmatest_thread, test_done);
> ????????if (!thread->done) {
> ????????????????done->done = true;
> ????????????????wake_up_all(done->wait);
> 

Thanks. I will send out v2 patch soon.

Shunyong