Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To:     "vinod.koul@intel.com" <vinod.koul@intel.com>
CC:     "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions
 to octal values
Thread-Topic: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic
 permissions to octal values
Thread-Index: AQHTmMofrqgtNukibE2Ncot9+9gZyA==
Date:   Mon, 29 Jan 2018 06:26:40 +0000
Message-ID: <1517207190.2845.6.camel@hxt-semitech.com>
References: <1516617881-30044-1-git-send-email-shunyong.yang@hxt-semitech.com>
         <20180129044801.GL18649@localhost>
In-Reply-To: <20180129044801.GL18649@localhost>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <373598F47E9F4E4BBB35C15FEFAA8160@hxt-semitech.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Vinod

On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote:
> On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> > 
> > Current coding style prefers octal permissions values. This patch
> > changes symbolic permissions to octal values.
> Is this preference documented anywhere?
> 

When using symbolic permissions like "S_IRUGO | S_IWUSR". The
checkpatch.pl will output some warnings to suggest to use octal values.
I quote following lines from checkpatch.pl,

# check for uses of S_<PERMS> that could be octal for readability
...
if (WARN("SYMBOLIC_PERMS",
?????????????????????????????????"Symbolic permissions '$oval' are not
preferred. Consider using octal permissions '$octal'.\n" . $herecurr)
&&
????????????????????????????$fix) {
????????????????????????????????$fixed[$fixlinenr] =~ s/$val/$octal/;
????????????????????????}

Thanks.
Shunyong