Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jan 2018 08:20:50 +0100
From:   Greg KH <greg@kroah.com>
To:     "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>,
        "marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>
Subject: Re: [PATCH v3 char-misc 1/1] Drivers: hv: vmbus: Implement Direct
 Mode for stimer0
Message-ID: <20180129072050.GA3575@kroah.com>
References: <1517173490-15112-1-git-send-email-mikelley@ntdev.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517173490-15112-1-git-send-email-mikelley@ntdev.microsoft.com>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jan 28, 2018 at 09:06:48PM +0000, Michael Kelley (EOSG) wrote:
> From: Michael Kelley <mikelley@microsoft.com>
> 
> The 2016 version of Hyper-V offers the option to operate the guest VM
> per-vcpu stimer's in Direct Mode, which means the timer interupts on its
> own vector rather than queueing a VMbus message. Direct Mode reduces
> timer processing overhead in both the hypervisor and the guest, and
> avoids having timer interrupts pollute the VMbus interrupt stream for
> the synthetic NIC and storage.  This patch enables Direct Mode by
> default on stimer0 when running on a version of Hyper-V that supports it,
> with a hv_vmbus module parameter for disabling Direct Mode and reverting
> to the old behavior.

You didn't change the text here as there is no more module parameter :(

> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -27,8 +27,9 @@
>  #include <linux/vmalloc.h>
>  #include <linux/hyperv.h>
>  #include <linux/version.h>
> -#include <linux/interrupt.h>
> +#include <linux/random.h>
>  #include <linux/clockchips.h>
> +#include <linux/module.h>

Still need this .h file?

thanks,

greg k-h