Received: by 10.223.176.5 with SMTP id f5csp2632786wra; Mon, 29 Jan 2018 01:12:46 -0800 (PST) X-Google-Smtp-Source: AH8x224WM+1NYwCZHchBtUXdvz4hoH1GGTFv2uNsXjc0GBFarOut6r9UMoz6SxGEJFf0+0GDspU+ X-Received: by 2002:a17:902:5814:: with SMTP id m20-v6mr11816128pli.434.1517217166507; Mon, 29 Jan 2018 01:12:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517217166; cv=none; d=google.com; s=arc-20160816; b=LxisRfFIACS+BASTURB+OVhIF+eRP0mFSLxo4T2BNWB91dp4EaiOMXSdKDAW2kGkB9 +6u0Lncy0v9MO8rGvGe+K2oJwc5ypdF/tWykc3TrTMEYXXAH+Fj/knINef2+II2Br93T A15alUsVZzklY0VLVWTpUD1dMQQVmACUnYMnQuJKRf1rpjDxs0ebhnK6seupGtpe5uTm PDhrq9mOqN9xNwUTq1iX2UImkEvqkXMiA/Xlh1YhhWf62Auex+ZyR/kUUx6tSmnkIAP0 XFaUKroUDHbHBqDqzYTxRPS8ScS7NnuTuzUoeoF/ZSmR9H4Vqp4pseYQT2LCfVtYrprv 222A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=fBlf8qqdL9n2J1wyZmTvGOmmo9ZesrGK4T6nOFZd5VE=; b=yDWFkC5NApkCOS/oDx5/EfBcTF1jq+gaD8rsAY4GPxRLP2WQaujYDh5slix+ftuqrW lkzGGGIkM2Db/4tVDWkvDJ52d6fRSASocYxgR6J8CZB0g4a1yv18s1EhxSmC/QOGK3hK D2i8y9PcK6pI8aRpcMg+bw/65RntlWtWb2IpDFNenmBUc9nEbpzj+z1MpOiTukMYmk3R Psf615hrq2Z74/kXClUbjTo5ZA423GavgLGMjaQQTivA6sRtkzH3IfRzrw3WONoaHx7E s/KoTa2sxc2XqqWfFguNXxVspP218rVu3U4mBVwM7qPCzLbGV/GpKKeY3j/zpecpyyD9 PlYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RIDKllML; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21-v6si3051712plo.453.2018.01.29.01.12.31; Mon, 29 Jan 2018 01:12:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RIDKllML; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751766AbeA2JL1 (ORCPT + 99 others); Mon, 29 Jan 2018 04:11:27 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:40775 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbeA2JLZ (ORCPT ); Mon, 29 Jan 2018 04:11:25 -0500 Received: by mail-wm0-f68.google.com with SMTP id v123so32138007wmd.5 for ; Mon, 29 Jan 2018 01:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=fBlf8qqdL9n2J1wyZmTvGOmmo9ZesrGK4T6nOFZd5VE=; b=RIDKllMLl2zOgqUiIWzDOZxfLHnbFoKSLQqsc0lS7ECKsou9+yhiq2xeWZgUd0vyus Nla/oz9mAc2xrvcODX2nYchx8kv/1zIgBRUqgE6MqjyJCjEjZvpjohwc4hKfVq7klFU4 GI87DQGIq5Kk80Dt15nJFlQQ/mAoa5qbJXUEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=fBlf8qqdL9n2J1wyZmTvGOmmo9ZesrGK4T6nOFZd5VE=; b=mb5MFYwVcmabspgIRQ2NVRcT9j6eaUcZhDAw0slmt0wKqZRJQ7s9B9xwxDtBx3AieJ NrndJiDEX6BfUmrsiKmek1DJkJBe1CgJ/KTrieHGpyAjUPrCMZs4CC341/4xKJH7NAOd EOa4vgRXqiGIiKdXA1yGpXi0u/Kv14YjNumvi8NFbyskpu0a5HCjfCEX/QACoPS0O28B ucU3w+gN0L0KLEBEEEPK9eNbOPLu3UomMft8cZNpc5SJdPtOLYwEZuRzbJ0i9bQQNBCL 8u6OfI63QidISyzgNs68cPmDclhyVAxH800iU4fmce4B87ucbMJE4DUWQnVxCa+rtRiw H3hA== X-Gm-Message-State: AKwxytcJKNd3S0NZUAYTiHJOsOwmcwvRAyyfXGqkeyhHzaf04hT0zjHR PSP5ANz2TfAaVX7d2ieVeFyogg== X-Received: by 10.28.126.138 with SMTP id z132mr13298430wmc.139.1517217083824; Mon, 29 Jan 2018 01:11:23 -0800 (PST) Received: from dell ([2.27.167.62]) by smtp.gmail.com with ESMTPSA id q1sm5799139wrf.40.2018.01.29.01.11.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jan 2018 01:11:22 -0800 (PST) Date: Mon, 29 Jan 2018 09:11:20 +0000 From: Lee Jones To: Randy Dunlap Cc: Meghana Madhyastha , Daniel Thompson , Jingoo Han , Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c Message-ID: <20180129091120.xs74nu75fype2amq@dell> References: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com> <20180126094839.iksjiw4xj2n62yzn@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Jan 2018, Randy Dunlap wrote: > On 01/26/2018 01:48 AM, Lee Jones wrote: > > On Wed, 24 Jan 2018, Meghana Madhyastha wrote: > > > >> Add of_find_backlight, a helper function which is a generic version > >> of tinydrm_of_find_backlight that can be used by other drivers to avoid > >> repetition of code and simplify things. > >> > >> Acked-by: Daniel Thompson > >> Reviewed-by: Noralf Trønnes > >> Reviewed-by: Sean Paul > >> Signed-off-by: Meghana Madhyastha > > > > Nit: These should be in chronological order. > > Where does that tidbit of information come from? > I have never heard or read that. Not sure it is documented anywhere. It appeared to be the widely used, most sensible approach, so I adopted it a few years ago. This method provides us with information which would otherwise be absent; including description of the patch submission/acceptance path and an idea of who did what, when. For example: Original Author sign-off Original Co-author sign-off [Additional contributions: rebase, API changes, fix-ups] Re-worker's sign-off Tester's tested-by Reviewer's acked-by/reviewed-by Level-2 Maintainer sign-off Level-1 Maintainer sign-off Are you aware of a more functional/practical/useful method? -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog