Received: by 10.223.176.5 with SMTP id f5csp2793047wra; Mon, 29 Jan 2018 04:10:10 -0800 (PST) X-Google-Smtp-Source: AH8x22482yJVZugQfJ2qCbIqcJjxsSfwg3AQH0RQmjtUiW1clsxUFKnzjR43cLoegcr82Zg95lt4 X-Received: by 10.98.155.157 with SMTP id e29mr26648231pfk.78.1517227810204; Mon, 29 Jan 2018 04:10:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517227810; cv=none; d=google.com; s=arc-20160816; b=cKXT9bjPdmpGsPZZ0d4NedLesYYBUsB/Zl8HeDdlKpTJcOAXmj5VnWaV0A71Ll9oeV 9z/Hr9qc1+/eKn2+3Ryr7TgI2DPFovbbhaHD01T+Gh/eLDAVxSDU0Rm5ZHtryiy/hYzK qPSW05JVn+ta5QxNw2RsbfAxtH+OJ3Lg0kxbbfKi5crRi0Kl1F7043sMs8W1uudABSNG zVeGPAe2Het1xvdKPuA31/UbOL3QgtML6X+WDZOhbtEwtwJR8USqDJKnTbXLfAlG6dV6 hjO61rVitA18yst8Gm3gIS6RCuTx73yP5KP53MX1eznlMOb2fuco2ZGxoN+Mfg69ZV85 R3dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=MW6qRLu2zMC4s5ZX2J/8dvUc4uY4wdsniNCIlJa0Ano=; b=FYsrYcxUMhQeNd0TWn2odn0Dlmd/M0bkQNd280h00oZnxcI0zMhShHlfprs9A6LUTK uUYKoFmG6LR8LxrVNDnZrpfp/MuHbaX9gtdBiP0sCJ4PQ8TfXCZJL0ewpF8icPsVZGr3 on/MqAJi+AT7drGA85u2ALuUf2g5DgKD9GCGf6z6zo+GYYCSrLGIO6iThfuA//1Uux/2 qvKf8WV70ylAMO+vTQ+eI3bA8TjpMhXWvwo7XDo9QPzZkH3JpvI2YXAv1caKJQVKwOsA CCI+TEJDztjg9Kac+6aW5PjCXBm+dvG3xf3CbgLGRhzaibD5eq7cxnccGJ1iIbe4a1cf lqRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=KWjeYFmv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e19si11752427pfl.212.2018.01.29.04.09.55; Mon, 29 Jan 2018 04:10:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=KWjeYFmv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbeA2MJb (ORCPT + 99 others); Mon, 29 Jan 2018 07:09:31 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:38176 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbeA2MJ3 (ORCPT ); Mon, 29 Jan 2018 07:09:29 -0500 Received: by mail-it0-f67.google.com with SMTP id w14so9050830itc.3 for ; Mon, 29 Jan 2018 04:09:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MW6qRLu2zMC4s5ZX2J/8dvUc4uY4wdsniNCIlJa0Ano=; b=KWjeYFmv2dblr1YoMTRQRqNVx+N/V6vIlH0Wgcuha+1LH9pocFUCxGnsHGNIAT0/6O BmQ4p+Lo1EuuETo+7pjFAuxAsimkrZduBeljFTcT24NJRoYUmMgy/c9B2XAkcxvsZk6Z vwBKrJaaAV1csO/bXBQRB9+PAvfQjc4DoGXNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MW6qRLu2zMC4s5ZX2J/8dvUc4uY4wdsniNCIlJa0Ano=; b=lLHUoDeny6zlGMQ8LE8OqF/3yUVs3nwFMyZkbnoSnAVkflqc4J6Yihi5usScG/fqCN zvUz+0BU5Td4WkHzEVKJQPzCcwugdmJyluj92aFXSKPnrk/41vpq4Jf8j5B6H6SaymC8 14dWQvtHLfRLvj0NcQCFcsX26ekYBHECsI5kO5UgTVpJ55a4Ihq7dpmPKNWUgM2RPw6Z 4eWo2HyZAldmAmaTW6sx8lKI812+Fbx+lXobm5rdcxI2hn8Bi6nJqo+R1+1S05kDeo3k kCUHKLcAuI+elEB0lplcbhh3M85r6o4dmOTEUo0tE1bxkyfe8ozYQdTLIUfseFoVhKPL v2qw== X-Gm-Message-State: AKwxyteocNAfRxk3VS8Lh7uk1GYej6gBRVsh6oFLoYuIO5mkzm5xjv5L H035mpF1vCb2ewJk7QAGgZXykcoRqfSIQzjlo98dBA== X-Received: by 10.36.237.200 with SMTP id r191mr19834151ith.70.1517227768873; Mon, 29 Jan 2018 04:09:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.81.4 with HTTP; Mon, 29 Jan 2018 04:08:48 -0800 (PST) In-Reply-To: References: <19c755a6-8c52-bbd5-a425-48fc08cecd4f@users.sourceforge.net> From: Devesh Sharma Date: Mon, 29 Jan 2018 17:38:48 +0530 Message-ID: Subject: Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl() To: SF Markus Elfring Cc: linux-rdma , Doug Ledford , Jason Gunthorpe , Selvin Xavier , Somnath Kotur , Sriharsha Basavapatna , LKML , kernel-janitors@vger.kernel.org, Himanshu Jha Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 3:01 PM, SF Markus Elfring wrote: >> You don't need 2 patches when changing same lines of code. > > Are these really the same? > > >> Could you squash both and send your changes in a single patch. > > I prefer to keep the deletion of questionable error messages separate > from the refactoring for a bit of exception handling. > Okay fair enough Series Acked-By: Devesh Sharma > >> The patches look good to me otherwise. > > Thanks for your constructive feedback. > > Regards, > Markus > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html