Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jan 2018 14:08:13 +0100
From:   Maxime Ripard <maxime.ripard@free-electrons.com>
To:     Chen-Yu Tsai <wens@csie.org>
Cc:     Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        thomas@vitsch.nl
Subject: Re: [PATCH v2 16/19] drm/sun4i: backend: Assign the pipes
 automatically
Message-ID: <20180129130813.rrnjzmskgjrbzxg2@flea.lan>
References: <cover.9e7b6a702e4d90a13d08fbe3b0a319cbf4db687f.1516617243.git-series.maxime.ripard@free-electrons.com>
 <d4ae26685ad75bd2dde3c3c3b7d086fb544347cc.1516617243.git-series.maxime.ripard@free-electrons.com>
 <CAGb2v662Qx6nY3Tgvnh=CRMoSDsFwNEiZwW+X8YuN8zMaNwLgw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="tos5ularur4d3or7"
Content-Disposition: inline
In-Reply-To: <CAGb2v662Qx6nY3Tgvnh=CRMoSDsFwNEiZwW+X8YuN8zMaNwLgw@mail.gmail.com>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--tos5ularur4d3or7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 29, 2018 at 10:22:54AM +0800, Chen-Yu Tsai wrote:
> On Mon, Jan 22, 2018 at 6:35 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Since we now have a way to enforce the zpos, check for the number of al=
pha
> > planes, the only missing part is to assign our pipe automatically inste=
ad
> > of hardcoding it.
> >
> > The algorithm is quite simple, but requires two iterations over the lis=
t of
> > planes.
> >
> > In the first one (which is the same one that we've had to check for alp=
ha,
> > the frontend usage, and so on), we order the planes by their zpos.
> >
> > We can then do a second iteration over that array by ascending zpos
> > starting with the pipe 0. When and if we encounter our alpha plane, we =
put
> > it and all the other subsequent planes in the second pipe.
> >
> > And since we have runtime checks and pipe assignments now, we can just
> > remove the static declaration of the planes we used to have.
>=20
> It would be slightly better if you could split this out into a separate
> patch. It's not immediately obvious to others that the changes to
> sun4i_layer.c are self-contained, while the change to sun4i_layer.h
> is part of the new pipeline tracking thing. Plus I think the way you
> structured everything means it won't break if you split it out.

You're right, I'll split this patch and resend it. I've pushed the
patches 9-15 to drm-misc, with your suggestions when you had some.

Thanks!
Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--tos5ularur4d3or7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlpvHLwACgkQ0rTAlCFN
r3QWAA/+JqxMUP+TpdaUaQJbs2bBUr0GqsVTb7Q0vVRMNPs2SdxK22VKSKsJkXvF
QIZTfTb5+C3E7I0M4GWTgkGY5qm2UuFY9GijsbpcD/Wy4pzRplY8ldJ5XMUJXgZ2
MKq8v0tJPcCxdXULmjY6ilh1vJM1pwKUpCg4gmBkPGZilL/q9usY0k6FPhHaiJVj
Wlw28vZfiTfEDHDyOh3MeLJ5ZxD5WGcwXJeRVzj2BWknRhsoLaVTlg6aKOss29uY
vJhiNSLIFrljp3BVsBl9GqZ66FJaAuXtn+F61JfEClJScxJ+nERZGoI5S5jj/Xnm
/EeopFZ3lDyARH7bsCQjsBvJQt/EuqRzT1xuu4xWjvhJWLOBqVfo8UYdXmf6Akqi
4GT9Mvb8Q4lF2KJxWZSyT4+WgkWuPC1qdrR8fdeClOUhBwFaOZSPoxWeW5Q/z9YV
eNvgeN8ERSqZDET6mEjB+NZiuljgxhpKvs3A3dBWpXunAdozF89T2TDpKkPLBzwH
6gG0kNw5bCnZwMuItCRCWPz8ChGhoE4NKZ3A0lfIAWKJzwpndL45UWi0bleAA7pu
Nq6G7WXg+rB0UoChdeRatRYDsOi12RSn8BbYIZeukeGpxGzcgpV+sDtUM0wLWDst
wBB15LsMS1ZogAiW2nXGxyqIuhRjbKd/bpi65fGL0WEAJ0PCQj0=
=oG3v
-----END PGP SIGNATURE-----

--tos5ularur4d3or7--