Received: by 10.223.176.5 with SMTP id f5csp2953418wra; Mon, 29 Jan 2018 06:44:45 -0800 (PST) X-Google-Smtp-Source: AH8x225e+CV+2ngh43hDGea/HiESjxm9PpvyMTGmsvmXjlS4+hP9wkGC9lc3lNQl9zOv8awRIpQG X-Received: by 10.101.100.132 with SMTP id e4mr4593790pgv.398.1517237085853; Mon, 29 Jan 2018 06:44:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517237085; cv=none; d=google.com; s=arc-20160816; b=XNpSGuLs1AFNQUO/IE9UsUaOITgdhbxpOWKYsaKkoC7dhu1Ksmc8d5hGOmK7V/+oL9 nJ3dTOeULnlLffcnW9GJadf52dfwUocAFgfxRKW+gpSlVFCbNMyBpwW4SbEPqutzwl7o EE52Ga70UAL18I7LVXMpLrAXeQrq4J1B4bcSHBbpSw2191YtuxT70Jj2fbC4lp34TqxG 6WVwTqLCxBEA6zwhu9TgMj4pXBI089YcMDGaLH6NOAADZHVhMMc/OCqze0u6OImxhjCa q8ZGB9hLkwBiV2oA2DSHb25s0tOFAXUGLUaZEGYme7C+3tgCspkIwSdr1XJkQIDBbPOs HwJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:references:in-reply-to:mime-version :dkim-signature:arc-authentication-results; bh=7OndPR/fkjL619C+NYirKQ2VsTZS8JAQn0Byo9aPHFc=; b=uN3wcm75Q6w3O0RqufS+ACkSWB/lyChdTRJE6WXTmdnaHV2jlkWYHY7dK5rLCs9gc7 65uZoexuEDT8VGJX1dMYYlpUHqO+ZvTt5MOABRBviiNGxFAPOJa2/7J1Ic8/0+euwzgo Mvt10p/cOKfy57S2KdfFLuNB4RYhjI/PCCrrTsuhLUcKdGqVl+3XbGeN4obzthumumw2 s4b6f2K9N+hG6lcSHBTtyZmmMSr4CbKrYrY88yqekXQFrdGPaLfax3B/O3BvNWRPumdW 3dVic57a7M8c+N6FTxgxRi3iMWkg1hyxi8YrfwMSe/JbTxNUZnlQ1Lv+Cewechr2/oYS iexQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=e+YmG6TL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si9433518plt.307.2018.01.29.06.44.31; Mon, 29 Jan 2018 06:44:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=e+YmG6TL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbeA2OoH (ORCPT + 99 others); Mon, 29 Jan 2018 09:44:07 -0500 Received: from mail-it0-f52.google.com ([209.85.214.52]:50513 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbeA2OoF (ORCPT ); Mon, 29 Jan 2018 09:44:05 -0500 Received: by mail-it0-f52.google.com with SMTP id x128so8565853ite.0 for ; Mon, 29 Jan 2018 06:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7OndPR/fkjL619C+NYirKQ2VsTZS8JAQn0Byo9aPHFc=; b=e+YmG6TL1Jg9xYAB9JaMTAYa6KEMU7lXsMlALiPr3rtYagU+NTmllsje8M4i1MHToO 7868BYGu9j5LUsl3Fes9WDJgBn2iXGQnF8ZbbDcDCTjvUUqLcgNC+/QE+X1hPJvoaL+t mhBcQ3mioscbn+PtxpSPg7W3AGKq5qu6c6mzc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7OndPR/fkjL619C+NYirKQ2VsTZS8JAQn0Byo9aPHFc=; b=R1p6egrugbfnAA7Qccv6x0K4ikjmboTyMcWd+GlpzEGdAM3n7X4+i+j3F/oAVayXwy ekz8AyRCoP7s3BKWXRY4gjRmjswvXR/6eAbuEBt9XBk2joWW9Y53tBvT5xFzQT8QTstZ GYbTCii1yZbmxpKk0piMXoaQOc1lL68X5e/aZVr0TiOLvrQ4eIBDw10xCcDed9lXmuUU kFwfvtLxuHjqHuFHREQXPCMIxnFEW6AwL2FSrQVV/LmCQgNcOWTqLQ9xxhcPIWGmoHAE TOWsFqRCTeMM6pDgpcUuDH0y32e3UKbdYTzKjKISNMxzdfCgG7KhB4GrJvVXMyIqSdXL 1V/w== X-Gm-Message-State: AKwxytcCjVldmVmPC7XOCyOcQyZsThXAupAMMZeSM4XQXOiZ+TdWd0Sr v6PCtVsShG4TuXtdeHS77HIu1hR6bfs= X-Received: by 10.36.135.132 with SMTP id f126mr6469260ite.61.1517237045196; Mon, 29 Jan 2018 06:44:05 -0800 (PST) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com. [209.85.223.178]) by smtp.gmail.com with ESMTPSA id l63sm4337127ita.44.2018.01.29.06.44.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jan 2018 06:44:04 -0800 (PST) Received: by mail-io0-f178.google.com with SMTP id z6so7840701iob.11 for ; Mon, 29 Jan 2018 06:44:03 -0800 (PST) X-Received: by 10.107.180.146 with SMTP id d140mr27878417iof.166.1517237043471; Mon, 29 Jan 2018 06:44:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.19.224 with HTTP; Mon, 29 Jan 2018 06:43:42 -0800 (PST) In-Reply-To: <20180129091120.xs74nu75fype2amq@dell> References: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com> <20180126094839.iksjiw4xj2n62yzn@dell> <20180129091120.xs74nu75fype2amq@dell> From: Sean Paul Date: Mon, 29 Jan 2018 09:43:42 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c To: Lee Jones Cc: Randy Dunlap , Meghana Madhyastha , Daniel Thompson , Jingoo Han , Thierry Reding , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Tomi Valkeinen , Daniel Vetter , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 4:11 AM, Lee Jones wrote: > On Fri, 26 Jan 2018, Randy Dunlap wrote: > >> On 01/26/2018 01:48 AM, Lee Jones wrote: >> > On Wed, 24 Jan 2018, Meghana Madhyastha wrote: >> > >> >> Add of_find_backlight, a helper function which is a generic version >> >> of tinydrm_of_find_backlight that can be used by other drivers to avo= id >> >> repetition of code and simplify things. >> >> >> >> Acked-by: Daniel Thompson >> >> Reviewed-by: Noralf Tr=C3=B8nnes >> >> Reviewed-by: Sean Paul >> >> Signed-off-by: Meghana Madhyastha >> > >> > Nit: These should be in chronological order. >> >> Where does that tidbit of information come from? >> I have never heard or read that. > > Not sure it is documented anywhere. It appeared to be the widely > used, most sensible approach, so I adopted it a few years ago. > > This method provides us with information which would otherwise be > absent; including description of the patch submission/acceptance path > and an idea of who did what, when. > > For example: > > Original Author sign-off > Original Co-author sign-off > [Additional contributions: rebase, API changes, fix-ups] > Re-worker's sign-off > Tester's tested-by > Reviewer's acked-by/reviewed-by > Level-2 Maintainer sign-off > Level-1 Maintainer sign-off > > Are you aware of a more functional/practical/useful method? Hi Lee, Our tooling adds a Link: tag to the commit message pointing back to mailing list archives. This provides more detailed patch provenance in addition to reducing the burden on contributors to order tags correctly (I had never heard of this as a requirement either). Check out [1] if you're interested. Sean [1]- https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html > > -- > Lee Jones > Linaro Services Technical Lead > Linaro.org =E2=94=82 Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog