Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jan 2018 10:21:46 -0600
From:   Rob Herring <robh@kernel.org>
To:     srinivas.kandagatla@linaro.org
Cc:     Vinod Koul <vinod.koul@intel.com>,
        Andy Gross <andy.gross@linaro.org>, dmaengine@vger.kernel.org,
        Mark Rutland <mark.rutland@arm.com>,
        David Brown <david.brown@linaro.org>,
        Dan Williams <dan.j.williams@intel.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        yanhe@quicinc.com, ramkri@qti.qualcomm.com, sdharia@quicinc.com
Subject: Re: [PATCH 4/4] dmaengine: qcom: bam_dma: Add num-ees dt binding for
 remotely controlled
Message-ID: <20180129162146.2h3kht4xhhr32mbp@rob-hp-laptop>
References: <20180116190236.14558-1-srinivas.kandagatla@linaro.org>
 <20180116190236.14558-5-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180116190236.14558-5-srinivas.kandagatla@linaro.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 16, 2018 at 07:02:36PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> When Linux is master of BAM, it can directly read registers to know number
> of supported execution enviroments, however when its remotely controlled
> reading these registers would trigger a crash if the BAM is not yet
> intialized/powered up on the remote side.
> 
> This patch adds new binding num-ees to specify supported number of
> Execution Environments when BAM is remotely controlled.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  Documentation/devicetree/bindings/dma/qcom_bam_dma.txt |  2 ++
>  drivers/dma/qcom/bam_dma.c                             | 15 ++++++++++++---
>  2 files changed, 14 insertions(+), 3 deletions(-)

The correct split is the binding changes in 1 patch. Driver changes 
separate.

> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt
> index aa6822cbb230..f0d10c2b393e 100644
> --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt
> +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt
> @@ -17,6 +17,8 @@ Required properties:
>    remote proccessor i.e. execution environment.
>  - num-channels : optional, indicates supported number of DMA channels in a
>    remotely controlled bam.
> +- num-ees : optional, indicates supported number of Execution Environments in a
> +  remotely controlled bam.

This one needs a vendor prefix as it is not a common property.

>  
>  Example:
>