Received: by 10.223.176.5 with SMTP id f5csp3355358wra; Mon, 29 Jan 2018 12:07:29 -0800 (PST) X-Google-Smtp-Source: AH8x225BTE0ytZUNM/d/YLhVR0X078CH0m0dSLPrfztnJmSgi8ggkcwtz7tCVddKrUm/zOG/gxsu X-Received: by 10.98.254.21 with SMTP id z21mr27955470pfh.48.1517256449721; Mon, 29 Jan 2018 12:07:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517256449; cv=none; d=google.com; s=arc-20160816; b=ye/IFxz5JmRESKjbF+h9g8GvXiBEKy8L3gHYjpVhyfU362AVgBw2dY4Lmz7Rt2Q5Su p0CDvOuU4SwjLuLSptaE4t7pVeCWmdaO/UprNkbcRM41CQUbxGEMMB3eYyvhoH6kRb39 YyqbM/peNeQRoVwXNPBnkZTqp8qVBCZHk1U5ePGIHDHZa8Dwos48Az28j/UXQy2tzMuy 2HzEYAyki0EvuOb+M+qmSndw5TRdStIG65bMyoQLGyQ7l5TTI3Fy4+CKDx1cJCkelSR+ z09EmOZp0pXeu0DdOrDvCJYKNEH4dv5pvnQIV19NJNc8ZgkxWtESjf44VXg/hg7UamEt jGrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=BXp40qWvkm1spguRvjTCxwaKzI22EWnBqIqFdQqhHMI=; b=mb5EWOlpVyBE+6qWy7yNNtRHQPatpFp86joq9IryavoaMsgGDlfzqXdvah0ecVEUs0 skAg89SkC1UAt3rwk+pdxejpk1Zw+/CHJ2I4SAQMAPCs8uT6RUuWwxl0jAHsj5g3ggww GlzF9WoYucmkzvBZ0GyMKyuhH0r8+vOSpX+loiGHSC1hktVTLFmUnFj+p0u3yUjOd9Gf FYnKIUhxNX1kTEUT8enYboUcCe65xTnuFvqSwRcdk85/HQcRuIDRZ4i4Ea2iIphBDgkV HBTJSYwFuPM6PyhBxtTqiyIXyYa7B8mJaZBWpr9PbQpAzuil6iBESTbFbhcg3gIDyH5e gR/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q7si414603pgt.517.2018.01.29.12.07.15; Mon, 29 Jan 2018 12:07:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbeA2UGk (ORCPT + 99 others); Mon, 29 Jan 2018 15:06:40 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:48578 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752747AbeA2UGf (ORCPT ); Mon, 29 Jan 2018 15:06:35 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8CECF2F7B; Mon, 29 Jan 2018 13:05:13 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Kosina , Andi Kleen , Thomas Gleixner , David Woodhouse , rusty@rustcorp.com.au, arjan.van.de.ven@intel.com, jeyu@kernel.org, Linus Torvalds Subject: [PATCH 4.9 26/66] Revert "module: Add retpoline tag to VERMAGIC" Date: Mon, 29 Jan 2018 13:56:50 +0100 Message-Id: <20180129123841.220014802@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123839.842860149@linuxfoundation.org> References: <20180129123839.842860149@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 5132ede0fe8092b043dae09a7cc32b8ae7272baa upstream. This reverts commit 6cfb521ac0d5b97470883ff9b7facae264b7ab12. Turns out distros do not want to make retpoline as part of their "ABI", so this patch should not have been merged. Sorry Andi, this was my fault, I suggested it when your original patch was the "correct" way of doing this instead. Reported-by: Jiri Kosina Fixes: 6cfb521ac0d5 ("module: Add retpoline tag to VERMAGIC") Acked-by: Andi Kleen Cc: Thomas Gleixner Cc: David Woodhouse Cc: rusty@rustcorp.com.au Cc: arjan.van.de.ven@intel.com Cc: jeyu@kernel.org Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/vermagic.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/include/linux/vermagic.h +++ b/include/linux/vermagic.h @@ -24,16 +24,10 @@ #ifndef MODULE_ARCH_VERMAGIC #define MODULE_ARCH_VERMAGIC "" #endif -#ifdef RETPOLINE -#define MODULE_VERMAGIC_RETPOLINE "retpoline " -#else -#define MODULE_VERMAGIC_RETPOLINE "" -#endif #define VERMAGIC_STRING \ UTS_RELEASE " " \ MODULE_VERMAGIC_SMP MODULE_VERMAGIC_PREEMPT \ MODULE_VERMAGIC_MODULE_UNLOAD MODULE_VERMAGIC_MODVERSIONS \ - MODULE_ARCH_VERMAGIC \ - MODULE_VERMAGIC_RETPOLINE + MODULE_ARCH_VERMAGIC