Received: by 10.223.176.5 with SMTP id f5csp3362847wra; Mon, 29 Jan 2018 12:11:29 -0800 (PST) X-Google-Smtp-Source: AH8x227wXWfvHU4QQJxenf732cMA0jFV8PdBiIXWS06Rd4WyO8dCzF9qqaUGvfGhv/iWUTGn5yZL X-Received: by 10.98.159.25 with SMTP id g25mr28091422pfe.224.1517256689444; Mon, 29 Jan 2018 12:11:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517256689; cv=none; d=google.com; s=arc-20160816; b=CW3MDV4s+rxRNq07HXqrlAdfyP25es6lVxZydS8GXr/a8isVnwzS9nRDniRaHxyrAj Zr62gYB1Od/5vUcjk7ZfucM6aei83PeNF6lghRnfXcE9uvmBvu+bXHo9lYbc2NJ1s6h3 9BuoKlfMbqmsLHOEx0/8MHVKPwE/NMnviCgp9mnTrfZ9W3/YVub4WQ6vm6m+qYTcrX+J GWzYzJcz99Yi5zEu5KVEUlUYv8f/eg6TSztoUN8KIRTXnsEN9NMH8/4tsOg+WqpACdwy Q0LlsD5juPbM8pknkII6/vlffesy7tuMp+gCYtoNc5maV/+QH1q7ZTysrX9FXgRMbgWx NNKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=KPfr8xWm0fgrJZCwOm2r8BRQKJiTGN0VHUGDCyrsiRk=; b=i3eOoUo2HZg3RdLmfG59u+ctyN/NJ0jk1y2RKNZFIxYPgby6EhnSoA0FVpbyOSSICy U9os9D5Dd6dSebcgSCWGB5i3j96V69S/mhBYDmyZq4/g3EyPk/74vPaG/tYNmpFQ4/uq Hc29eX3hIW7suSa/SvZlc/3KarMczN9yy2oNZiuUGcDkOaAw+DALZFT9gx4xvYIPp6+h B1L5eMa+m5Kp08V6TlZhbDjAqLMSWrBfRO2suENuIN1pA0BtEx0+d4NlTrOqRw9YYC5w VGXchIJGYcphHIqZVxbTX3zmQMWrW5rnicZTXtQFAYdW9Lpr47AKUeMgqzAPArfI3lRV SCbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6-v6si2219849plr.802.2018.01.29.12.11.14; Mon, 29 Jan 2018 12:11:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbeA2UKp (ORCPT + 99 others); Mon, 29 Jan 2018 15:10:45 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58026 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753514AbeA2UKn (ORCPT ); Mon, 29 Jan 2018 15:10:43 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5CA553001; Mon, 29 Jan 2018 13:09:03 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Kosina , Andi Kleen , Thomas Gleixner , David Woodhouse , rusty@rustcorp.com.au, arjan.van.de.ven@intel.com, jeyu@kernel.org, Linus Torvalds Subject: [PATCH 4.14 07/71] Revert "module: Add retpoline tag to VERMAGIC" Date: Mon, 29 Jan 2018 13:56:35 +0100 Message-Id: <20180129123827.808894291@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123827.271171825@linuxfoundation.org> References: <20180129123827.271171825@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 5132ede0fe8092b043dae09a7cc32b8ae7272baa upstream. This reverts commit 6cfb521ac0d5b97470883ff9b7facae264b7ab12. Turns out distros do not want to make retpoline as part of their "ABI", so this patch should not have been merged. Sorry Andi, this was my fault, I suggested it when your original patch was the "correct" way of doing this instead. Reported-by: Jiri Kosina Fixes: 6cfb521ac0d5 ("module: Add retpoline tag to VERMAGIC") Acked-by: Andi Kleen Cc: Thomas Gleixner Cc: David Woodhouse Cc: rusty@rustcorp.com.au Cc: arjan.van.de.ven@intel.com Cc: jeyu@kernel.org Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/vermagic.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/include/linux/vermagic.h +++ b/include/linux/vermagic.h @@ -31,17 +31,11 @@ #else #define MODULE_RANDSTRUCT_PLUGIN #endif -#ifdef RETPOLINE -#define MODULE_VERMAGIC_RETPOLINE "retpoline " -#else -#define MODULE_VERMAGIC_RETPOLINE "" -#endif #define VERMAGIC_STRING \ UTS_RELEASE " " \ MODULE_VERMAGIC_SMP MODULE_VERMAGIC_PREEMPT \ MODULE_VERMAGIC_MODULE_UNLOAD MODULE_VERMAGIC_MODVERSIONS \ MODULE_ARCH_VERMAGIC \ - MODULE_RANDSTRUCT_PLUGIN \ - MODULE_VERMAGIC_RETPOLINE + MODULE_RANDSTRUCT_PLUGIN