Received: by 10.223.176.5 with SMTP id f5csp3408656wra; Mon, 29 Jan 2018 12:45:33 -0800 (PST) X-Google-Smtp-Source: AH8x225Pu+LGWSzDDSy8i8Shc13Ucn/162Ft+Fsj3k7mCKkx0zoxdyAav/Di0kd6szEDpQWevrJl X-Received: by 2002:a17:902:a984:: with SMTP id bh4-v6mr2968645plb.95.1517258733636; Mon, 29 Jan 2018 12:45:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517258733; cv=none; d=google.com; s=arc-20160816; b=rMolzAy7gKmP+UPATu/QUQ9+ImBuHYMGQ8+Ke3nTx9etUVFKGlQMfwLbeFB4K09Sn8 Mq8CvuD3OOgrwRxtVSYn6BzbnrD1idaAvvNPZIt/x26/5WkcHYg2k+U8LZ3mNBD2OIdu 1B87rfhxKHwoSFQyvpi2wMhflt25xp/3eBUcC0pIxT6xLeYik4Z1kvISpciQ8nTl/PFX s5LM9leu/llrkXyAhVGNwdpZI8qXhTHjQdAWXXBLL66hb+CNHtgaVidd6M0ZHmpcMR/G RDFeIXzGNF0Mu9SZDZpUhW/tRbXFREi5vRsXS38wjVQkIuoB+36/U5SkXGE+H8FbQ08p k83A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=qA7aPfOJvAu6QHKQwUAo5gEWG6gxVshcLQRq9/VmIYU=; b=HZlyM4tFIsLyRa9/1HaOvdxhVAQ2375Z73UhdvJdaKN8kfW59fUCrSCTZoxo60u74C evJ9L4nx/b9dNron5xBiA3d97l9G77l4fqSuLaG3RVp4nlq9Z1VkZQXbDGFwziit89MD 26PzSrptgEhrUKlvUcNcQjERgwJ9/N776L4FC13rvzhuZnH+dSQyI9fV7bAEsLmTKjM/ uORIwEVKc4RqhnZb7c8J6m1DOcDkWFHmhi1qpH9eAUkAn9EmgeIRqRjjxzLSuOXxzaQx oe0qf7LXM6lmAdpKF13aqz/9xa/SHiSNKGbjY/DNLEiynvyX1N0zE68OJP/hQ+j6cWtA dcwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=R6XqoUjV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h23si2025302pfh.80.2018.01.29.12.45.19; Mon, 29 Jan 2018 12:45:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=R6XqoUjV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754068AbeA2Uoq (ORCPT + 99 others); Mon, 29 Jan 2018 15:44:46 -0500 Received: from mail-yw0-f194.google.com ([209.85.161.194]:35231 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753923AbeA2Uoo (ORCPT ); Mon, 29 Jan 2018 15:44:44 -0500 Received: by mail-yw0-f194.google.com with SMTP id u21so3202387ywc.2 for ; Mon, 29 Jan 2018 12:44:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qA7aPfOJvAu6QHKQwUAo5gEWG6gxVshcLQRq9/VmIYU=; b=R6XqoUjVskAW82b8WjXSRR9Bfli8cKcpuK09+AwGBOyC8BkUZk4js9hY7/bec9fAIl DvmBNfFsRrqTSYlN8ZHDASN0eTcB22Tv4P5hXOev9X2lT2T6jRAGf8EiRECFt3VU0u4c dMlUdcw8IBjDyLrGrps5vGrKGy0fmM1AcE97w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qA7aPfOJvAu6QHKQwUAo5gEWG6gxVshcLQRq9/VmIYU=; b=iJEj98KYViJsAiA9EmB7GJQrdDHl0b7r9afZOihG00gb7da/CNE+4D5rbT6DTFxGxw GT3/3427DFBkNE0J+b/hT/PvpES4yApHCQYvsAdvFzIoQ0hlQQb2OKObAKVo47j2Zr2W +myYvi6IAFTrA5dkkJ54VlywQ7daioRUT1SSy1CXB/f3eHvzaH+IW78zYBO3rUj+Tzov BY/01YWvLvjNLbFn34HBpiaL8xQ5Eud/1iGiQGit6LFV11EvfDsPFJKPvbMdTbTTePAZ 7Co9V2HOZxn8XnUMOe+q6Z83PmOpBcwqQzoKYrg673+LDYrNZGKbAI8oGaGoU9s6l44a JnDA== X-Gm-Message-State: AKwxyteSmr91gDZ2SfQmVc0MJahh8vC/W2hFsJr7iQ04r3r+gDrWx7aD fWAPUgdAlMuTzeu67JWodQXqrw== X-Received: by 10.13.206.193 with SMTP id q184mr19082009ywd.325.1517258683199; Mon, 29 Jan 2018 12:44:43 -0800 (PST) Received: from localhost ([2620:0:1013:11:d3af:69ac:1964:28e8]) by smtp.gmail.com with ESMTPSA id u128sm4693005ywb.49.2018.01.29.12.44.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jan 2018 12:44:42 -0800 (PST) Date: Mon, 29 Jan 2018 15:44:42 -0500 From: Sean Paul To: Thierry Escande Cc: Archit Taneja , Inki Dae , Thierry Reding , Sandy Huang , Sean Paul , David Airlie , Tomasz Figa , Haixia Shi , =?iso-8859-1?Q?=D8rjan?= Eide , Zain Wang , Yakir Yang , Lin Huang , Douglas Anderson , Mark Yao , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 01/43] drm/rockchip: Get rid of unnecessary struct fields Message-ID: <20180129204442.nwpx45aajzprjnwp@art_vandelay> References: <20180126131710.7622-1-thierry.escande@collabora.com> <20180126131710.7622-2-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180126131710.7622-2-thierry.escande@collabora.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 26, 2018 at 02:16:28PM +0100, Thierry Escande wrote: > From: Tomasz Figa > > This patch removes unused fields from vop structure. > > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande Reviewed-by: Sean Paul > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index ba7505292b78..7a137bc5708c 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -95,9 +95,6 @@ struct vop { > struct drm_device *drm_dev; > bool is_enabled; > > - /* mutex vsync_ work */ > - struct mutex vsync_mutex; > - bool vsync_work_pending; > struct completion dsp_hold_completion; > > /* protected by dev->event_lock */ > @@ -1567,8 +1564,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) > spin_lock_init(&vop->reg_lock); > spin_lock_init(&vop->irq_lock); > > - mutex_init(&vop->vsync_mutex); > - > ret = devm_request_irq(dev, vop->irq, vop_isr, > IRQF_SHARED, dev_name(dev), vop); > if (ret) > -- > 2.14.1 > -- Sean Paul, Software Engineer, Google / Chromium OS