Received: by 10.223.176.5 with SMTP id f5csp3417822wra; Mon, 29 Jan 2018 12:53:48 -0800 (PST) X-Google-Smtp-Source: AH8x227If6haJx2MDE3l48aFpav9dKuNHVwY066tnr2yJDe2zCfTEcZ8chFLpo1MDjNN/uwEeQkC X-Received: by 10.99.115.82 with SMTP id d18mr22156776pgn.312.1517259228685; Mon, 29 Jan 2018 12:53:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517259228; cv=none; d=google.com; s=arc-20160816; b=c8+mTFbwzN9c5FzRIQWCtlYhdPygLwmnQu41GuN8uBAEUjbYui50FrfSTTd0DsMawf aLvCGDBYXdkIjQkH3/THcjRU9W6egIoqkyacYgPxkqDlPOrn2doU5U+Ht2Yswc/avnov 4Ftpfqrcuxdy/rTdE+I/uJ0CK6GKAcSi3XNdPSGP/f4Coz5m9DdzzroJGj4B5dR8ct4t +qaKdowQ00fksFmLwh9l6iCt2Xj5+W3L4tslQt/OYyU6zm5g2yEtFrA7X6ehGTKamcpE fBKaRnx0lkxs/N34HF7uvZhxzKTWfUuiAGxsaM6fv76C6QrUVtQ0aTPUpBcAec2gRXH/ 7Q0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=hfyOr05nuBS0dyP5J2OSmVCXXYf11dDj/Au+zZs3SfQ=; b=l/qaAnsylkRhrU/fYMQzEBKsmONFzefytgyRPy35jtoQq/PeLo7I0v9RZaoXhnBVH6 npikfxFwkQcbbNzDy3o6z804+ABt4YTnrI6z5+V1FRQ+4897v+Xwi6dHwyCKrESEALQa qC3GMaBk/vg/o5SbywpP6CZoyy91+Sq6ZTQky2FyoSHd9O3T738r4rSNXyCTvHgzTEo/ MBMEYenUhtfaEpaewgJegnfAuUSWo6eOO5AKZvW00zZgEGZvoT5ls9A8U+02K5W6cHEw /qfTL1z3tJC1CyxiMXYg5DL0nzSAyT+wbnHCCgXoP8/MOFjstYe0scn+Tf/r3amYLv1i +BSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g129si213225pfc.338.2018.01.29.12.53.34; Mon, 29 Jan 2018 12:53:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463AbeA2UK0 (ORCPT + 99 others); Mon, 29 Jan 2018 15:10:26 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57078 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451AbeA2UKY (ORCPT ); Mon, 29 Jan 2018 15:10:24 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 20D442F1E; Mon, 29 Jan 2018 13:02:36 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiri Kosina , Andi Kleen , Thomas Gleixner , David Woodhouse , rusty@rustcorp.com.au, arjan.van.de.ven@intel.com, jeyu@kernel.org, Linus Torvalds Subject: [PATCH 4.4 47/74] Revert "module: Add retpoline tag to VERMAGIC" Date: Mon, 29 Jan 2018 13:56:52 +0100 Message-Id: <20180129123849.712624896@linuxfoundation.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180129123847.507563674@linuxfoundation.org> References: <20180129123847.507563674@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit 5132ede0fe8092b043dae09a7cc32b8ae7272baa upstream. This reverts commit 6cfb521ac0d5b97470883ff9b7facae264b7ab12. Turns out distros do not want to make retpoline as part of their "ABI", so this patch should not have been merged. Sorry Andi, this was my fault, I suggested it when your original patch was the "correct" way of doing this instead. Reported-by: Jiri Kosina Fixes: 6cfb521ac0d5 ("module: Add retpoline tag to VERMAGIC") Acked-by: Andi Kleen Cc: Thomas Gleixner Cc: David Woodhouse Cc: rusty@rustcorp.com.au Cc: arjan.van.de.ven@intel.com Cc: jeyu@kernel.org Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/vermagic.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/include/linux/vermagic.h +++ b/include/linux/vermagic.h @@ -24,16 +24,10 @@ #ifndef MODULE_ARCH_VERMAGIC #define MODULE_ARCH_VERMAGIC "" #endif -#ifdef RETPOLINE -#define MODULE_VERMAGIC_RETPOLINE "retpoline " -#else -#define MODULE_VERMAGIC_RETPOLINE "" -#endif #define VERMAGIC_STRING \ UTS_RELEASE " " \ MODULE_VERMAGIC_SMP MODULE_VERMAGIC_PREEMPT \ MODULE_VERMAGIC_MODULE_UNLOAD MODULE_VERMAGIC_MODVERSIONS \ - MODULE_ARCH_VERMAGIC \ - MODULE_VERMAGIC_RETPOLINE + MODULE_ARCH_VERMAGIC