Received: by 10.223.176.5 with SMTP id f5csp3629917wra; Mon, 29 Jan 2018 16:33:52 -0800 (PST) X-Google-Smtp-Source: AH8x226MIyLvCgds/nnwv4RD1CZ1dr6EwV72hD017xq0yYrxclRFmugOI2YQrTXiHDp966m5y0Ot X-Received: by 2002:a17:902:50e3:: with SMTP id c32-v6mr22130359plj.310.1517272432378; Mon, 29 Jan 2018 16:33:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517272432; cv=none; d=google.com; s=arc-20160816; b=E78h5kdX0r5pi3F0lppsPsBokPoUnd2Y2u7eLqzW2KishfHZ2L3qzcOZiBqBKgSKh+ +4VyoaznDjh+JWNrdSXufOeZ0ssz7uwR133/mc5vpKC8qMMFSWzkxyjgV2dG6pE4YR6u 09LIBaHYIcLQ3CIOR6yItW27DbvoseEBTKrVRYxn5+5MWEw4bW4lO8eLErxGSen4GcND +d+RMe0lhI3QJd3jrj1P05oM6PDcITtA+M/pNRRwZFWbO3QbBIeEZfemtrbz8zM7Duiz 41Pd1NWPwnDGr0Kj1c7OnQzDkuHkDgtmOiQPtkAvPrTYZYVxjIr3HYKr/b9pfm6ClEo4 0kKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ztHMLEZAAfXH+x60ACTnyM7WKg4SCw4R984hyPDLrbs=; b=0XsYslf2neRah+zurWz33caGrdqQaQXQe/W2aavdRX19AaJc4Nr1lRchqgALmZuzEL 2Lg9BokxK4i/Jp975Wp1Y+8/rjhaQ1q/69WehCrEt+Vx+JLSq+vGsiFuCnuHgPDDekAo wuujty6T9dybuPr1Zbez1Qd8w05uZEFj+tdu4eWiV1g1fmjtqHp0twObcpWxVnCBSmZs bAdXHeCCzmcJ8iXUomhZYuW5vzWj4qM/6msLxmHT9PXUVShfNuvdWJDKSxdwEyML4Eth SMyAT//CmAtb820Z19wldHneuLQvcFdleEOCI21WRa/7xvDksmbQcYMYfhRMszbGKSin /U6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q74si13029124pfk.164.2018.01.29.16.33.38; Mon, 29 Jan 2018 16:33:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbeA3AdF (ORCPT + 99 others); Mon, 29 Jan 2018 19:33:05 -0500 Received: from gateway34.websitewelcome.com ([192.185.150.114]:12501 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752282AbeA3AdE (ORCPT ); Mon, 29 Jan 2018 19:33:04 -0500 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 2D5481F0FF2 for ; Mon, 29 Jan 2018 18:33:03 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id gJrDetc0JcGlpgJrDew1DF; Mon, 29 Jan 2018 18:33:03 -0600 Received: from [189.145.57.174] (port=35466 helo=training) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1egJrB-001f7L-RO; Mon, 29 Jan 2018 18:33:01 -0600 Date: Mon, 29 Jan 2018 18:33:01 -0600 From: "Gustavo A. R. Silva" To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 7/8] platform: sh_veu: fix potential integer overflow in sh_veu_colour_offset Message-ID: <81bc1c8fa08d1643fa9b7b6630fdd42baed7d225.1517268668.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.57.174 X-Source-L: No X-Exim-ID: 1egJrB-001f7L-RO X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (training) [189.145.57.174]:35466 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 37 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cast left and top to dma_addr_t in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type dma_addr_t (u64). Addresses-Coverity-ID: 1056807 ("Unintentional integer overflow") Addresses-Coverity-ID: 1056808 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva --- drivers/media/platform/sh_veu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sh_veu.c b/drivers/media/platform/sh_veu.c index 976ea0b..e2795d0 100644 --- a/drivers/media/platform/sh_veu.c +++ b/drivers/media/platform/sh_veu.c @@ -520,8 +520,8 @@ static void sh_veu_colour_offset(struct sh_veu_dev *veu, struct sh_veu_vfmt *vfm /* dst_left and dst_top validity will be verified in CROP / COMPOSE */ unsigned int left = vfmt->frame.left & ~0x03; unsigned int top = vfmt->frame.top; - dma_addr_t offset = ((left * veu->vfmt_out.fmt->depth) >> 3) + - top * veu->vfmt_out.bytesperline; + dma_addr_t offset = (((dma_addr_t)left * veu->vfmt_out.fmt->depth) >> 3) + + (dma_addr_t)top * veu->vfmt_out.bytesperline; unsigned int y_line; vfmt->offset_y = offset; -- 2.7.4