Received: by 10.223.176.5 with SMTP id f5csp3645670wra; Mon, 29 Jan 2018 16:52:37 -0800 (PST) X-Google-Smtp-Source: AH8x226LkowXsyhJeqLKQDGZv7Doo820cufB445fg7ze2+lYAlzAQlT+0SU9gRdFPe3mIst3Rcig X-Received: by 10.98.76.150 with SMTP id e22mr28192198pfj.28.1517273557232; Mon, 29 Jan 2018 16:52:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517273557; cv=none; d=google.com; s=arc-20160816; b=z/PACAJwhiZUuJQAW1iOGRRyVpR3mjKfy/qjfC6f+gFEDvOF+tgwA4QkTmknL3Rrl/ Jsta+70okvmIAqv5PxkeanWXBhwPR4/iLc7ngDnR637n+C2Zzb2Mwtx8zxOkjsns0A0t 3znkYUbLxZyTovmchxlaS0ntcsSztv+iYmecWXz60C+l3cs9nKEwCD+8WVJKWJDcTyKP l8RYe48W8gT0sXgJ9C2qjCvYjSErPunZAQwQLkqyEnX0ARDbPAyKvaZur6f8QvaetYuH XkTB0dloGC32ztplBc38sW87Fo22Pp68+7bNs1jNaTsmJM+cXuPnLKBQ+XbGWHyrbIeE cpcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=kKys11wRXKlb6drLUzPbQXCW5IIlG3uoroapv77qPu4=; b=ewOiOB6Keh8g9HtCytdAuInBiPvI2W1wBFM65U243kaetpajKWHHJ+3TveZQ4fei0g Y0/yujKInVDODIGK4ITyc8StBDVCL3wxNQJXgFnB1iRuHsDVswOs4meT7ZrhSrF+rn94 sjfdm0XALxa49GL4+g/TABjCbhupxQplHG47fIRW78/ziF9xPOCdVgmNSptqckFmg4U3 Bua96GR+54RcEOZ1avIe3dWGthIPDLvRhuE2bYfB1RseQZVYueyGZk92t1Lnd+94idcY qc97rTyyJ3Blz9MaI1JLcWLTqFF/pSbIO2PSaIYTs/thYhRJ2w5QKMOn6dV+hWeXmUws C2Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y96-v6si836236plh.454.2018.01.29.16.52.20; Mon, 29 Jan 2018 16:52:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbeA3Av4 (ORCPT + 99 others); Mon, 29 Jan 2018 19:51:56 -0500 Received: from gateway23.websitewelcome.com ([192.185.49.184]:37989 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbeA3Avz (ORCPT ); Mon, 29 Jan 2018 19:51:55 -0500 X-Greylist: delayed 1257 seconds by postgrey-1.27 at vger.kernel.org; Mon, 29 Jan 2018 19:51:55 EST Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 0417D1532F for ; Mon, 29 Jan 2018 18:30:58 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id gJpBeO0FqODN4gJpCeJaJY; Mon, 29 Jan 2018 18:30:58 -0600 Received: from [189.145.57.174] (port=35448 helo=training) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1egJpB-001dPz-Ki; Mon, 29 Jan 2018 18:30:57 -0600 Date: Mon, 29 Jan 2018 18:30:56 -0600 From: "Gustavo A. R. Silva" To: Antti Palosaari , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 1/8] rtl2832: fix potential integer overflow in rtl2832_set_frontend Message-ID: <1c57e607fbde1e598b2ca9380889e9fc1be6daa4.1517268667.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.57.174 X-Source-L: No X-Exim-ID: 1egJpB-001dPz-Ki X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (training) [189.145.57.174]:35448 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 14 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cast dev->pdata->clk to u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1271223 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva --- drivers/media/dvb-frontends/rtl2832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c index 94bf5b7..eefc301 100644 --- a/drivers/media/dvb-frontends/rtl2832.c +++ b/drivers/media/dvb-frontends/rtl2832.c @@ -498,7 +498,7 @@ static int rtl2832_set_frontend(struct dvb_frontend *fe) * RSAMP_RATIO = floor(CrystalFreqHz * 7 * pow(2, 22) * / ConstWithBandwidthMode) */ - num = dev->pdata->clk * 7; + num = (u64)dev->pdata->clk * 7; num *= 0x400000; num = div_u64(num, bw_mode); resamp_ratio = num & 0x3ffffff; @@ -511,7 +511,7 @@ static int rtl2832_set_frontend(struct dvb_frontend *fe) * / (CrystalFreqHz * 7)) */ num = bw_mode << 20; - num2 = dev->pdata->clk * 7; + num2 = (u64)dev->pdata->clk * 7; num = div_u64(num, num2); num = -num; cfreq_off_ratio = num & 0xfffff; -- 2.7.4