Received: by 10.223.176.5 with SMTP id f5csp3648897wra; Mon, 29 Jan 2018 16:56:52 -0800 (PST) X-Google-Smtp-Source: AH8x225JWNHLsMV0+d7jQL5/okGDBOCr11X4r6zVZZsBvd9eQQraEav+dfCAU/SVMcDEJ4DJlH3J X-Received: by 10.98.28.209 with SMTP id c200mr18724562pfc.24.1517273811804; Mon, 29 Jan 2018 16:56:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517273811; cv=none; d=google.com; s=arc-20160816; b=JzspS89QCWbVYe/fOvk1FljpqpNCkEAcTiq/D3IQTGnPNeC0ibsQdcP45I/jsb3h3U 3yRz32hAdUUcXCX7WVdPCExT7dMiV4yMFPKBkx1qDDTWZRg6tzA/yuo2q96Ds1PoFwpW 9sev4zCTPG+x1VJMGrpB5BBhyd5xh215oza15rDX74YAUZE4PHMB00CrOlPWz2I94C50 kAvutqISAtH4slz9gqRSZtRl8xVTWorhnV2dfZN/hCH8HFdAmk1aFXtqsRdmrWDKXmo+ nL0dH4Eqf1hwDAnUFU8B1sQHE8c/EaVO3iIbP/+Es9JGZOYK+vxWx6qIaq6rAnEVG+uw 4PEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=1JOWi3pJOtnwMSjJWWPms5y659KIhfZs2nFsJJYLvSs=; b=zQa9N9/8UqDwSEkmPIaj02hcRaLbfqze4G3tdxPdGX1me9fXNNlS7s6iw4byPyquU2 OHevNhqxvr1qjTDFHJ82Ip1BKCut2cfPKBlPozY7X6ypjstYzM6tEyvPib3o3mkRxhtW bzL/sPvQb4BBkSt5stYkGZI2LP7bjoAF8L5E482WqMNCCJ9NaGMDF1tfM49tuXqvRICX VmpgtgYDW42it9+cvuiuls3GQJ24bQA/83xDZg/ykF7rOI6UibflmFLH7XBRmKN/vR9r bfhzSbGP9RV5/yOoNp6g5iggly5veeXG2iBubn6QvbGmbahLDVb+tQ+FrZWv19TtbVFi DOMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11-v6si556534plj.90.2018.01.29.16.56.36; Mon, 29 Jan 2018 16:56:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbeA3A4E (ORCPT + 99 others); Mon, 29 Jan 2018 19:56:04 -0500 Received: from gateway21.websitewelcome.com ([192.185.46.109]:46199 "EHLO gateway21.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbeA3A4B (ORCPT ); Mon, 29 Jan 2018 19:56:01 -0500 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 10A83400CBF9E for ; Mon, 29 Jan 2018 18:32:02 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id gJqEe2oeFmzEzgJqEe6xFC; Mon, 29 Jan 2018 18:32:02 -0600 Received: from [189.145.57.174] (port=35456 helo=training) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1egJqD-001eKX-N9; Mon, 29 Jan 2018 18:32:01 -0600 Date: Mon, 29 Jan 2018 18:32:01 -0600 From: "Gustavo A. R. Silva" To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 4/8] i2c: ov9650: fix potential integer overflow in __ov965x_set_frame_interval Message-ID: <8ccf6acf10745fd1b9f33a7cacd5365e125633bf.1517268668.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.57.174 X-Source-L: No X-Exim-ID: 1egJqD-001eKX-N9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (training) [189.145.57.174]:35456 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 24 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cast fi->interval.numerator to u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type u64. Addresses-Coverity-ID: 1324146 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva --- drivers/media/i2c/ov9650.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c index e519f27..c674a49 100644 --- a/drivers/media/i2c/ov9650.c +++ b/drivers/media/i2c/ov9650.c @@ -1130,7 +1130,7 @@ static int __ov965x_set_frame_interval(struct ov965x *ov965x, if (fi->interval.denominator == 0) return -EINVAL; - req_int = (u64)(fi->interval.numerator * 10000) / + req_int = (u64)fi->interval.numerator * 10000 / fi->interval.denominator; for (i = 0; i < ARRAY_SIZE(ov965x_intervals); i++) { -- 2.7.4