Received: by 10.223.176.5 with SMTP id f5csp3649732wra; Mon, 29 Jan 2018 16:58:02 -0800 (PST) X-Google-Smtp-Source: AH8x224yzdLG2S5m184eN+VJQgouSzc8IvJPLNidP7sjdkP9rouGCt3dbsZyH+aMGZ2xanQuwF9M X-Received: by 10.99.159.2 with SMTP id g2mr17835924pge.156.1517273882590; Mon, 29 Jan 2018 16:58:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517273882; cv=none; d=google.com; s=arc-20160816; b=iq6tz6362wJgHtwroGHm6Wa9wRYw554s/ZzBMh9KepUUnByv7iLAVi9Ki6G9QnqeWK kOhHywPGKJt/zW6Hpx/bujGkW71Bc7h9xwnqoY/lhqNsqdfdXtoFhQycUDmbZyMNQmQX psbOQ/YLE2iF5Lr6oHXrAz1Hv8FCqcd1FWOKe6qYpy8cg61hpn1/CeyEU5hYTAAMj0PU d2XLGZrY48kWu8eQLAUAL8eYSmHVxhDSoDMSCD8kL7lj4s24ih964PUT+eeqnr7MMjEs OpghWA+m7cUhhAp20SK2dXj2OkwmdPecDJ9x+7OjNWJ8d164r8ShjSmAl2Z3Fr9w1P8H fDZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ARkzzh6k3Xk+4khxf7WGUoxfdCKSUiJ3ZejcRUG80Is=; b=IOWYvwPKuvaJR5tn/RnPTN6JQW7tgi2xqU0JZmy8Uyvl0B1RKl23XPgZDVwRPjOB2j ccNDTkwz1laadyNmdw9KO8+szWXKXijLH1+pshAayxZZvzSBL+CYjYZ5QFN5AOa5yWsL RivD6UZa6n65bo+8TZ6muGaUQBpVRK2eZ7hrYxfKSpBNh50sbA+ogF4U/bOtK8QLm6YI c9P+hgb6e5PPrggUtVNQBuNPJjhQV7tp+mjfriCW9JbiAJKcwH1kEL71Z3aAu9yoYMm2 zYMPezsBvmxfZGcvYHbrb9gHvzG9zZlre1RpWK/+WHKSXef/887i2Zs82/4So84d+z3r EVVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11-v6si556534plj.90.2018.01.29.16.57.48; Mon, 29 Jan 2018 16:58:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbeA3A4k (ORCPT + 99 others); Mon, 29 Jan 2018 19:56:40 -0500 Received: from gateway21.websitewelcome.com ([192.185.46.109]:41665 "EHLO gateway21.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbeA3A4C (ORCPT ); Mon, 29 Jan 2018 19:56:02 -0500 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 7A685400CFFA6 for ; Mon, 29 Jan 2018 18:31:21 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id gJpZeO0YSODN4gJpZeJabw; Mon, 29 Jan 2018 18:31:21 -0600 Received: from [189.145.57.174] (port=35450 helo=training) by gator4166.hostgator.com with esmtpa (Exim 4.89_1) (envelope-from ) id 1egJpZ-001dlT-5j; Mon, 29 Jan 2018 18:31:21 -0600 Date: Mon, 29 Jan 2018 18:31:20 -0600 From: "Gustavo A. R. Silva" To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 2/8] dvb-frontends: ves1820: fix potential integer overflow Message-ID: <2bc8d41c5ef755fbbe3f3e06c427928b97ed4731.1517268667.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.57.174 X-Source-L: No X-Exim-ID: 1egJpZ-001dlT-5j X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (training) [189.145.57.174]:35450 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 17 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cast state->config->xin to u64 in order to avoid a potential integer overflow. This variable is being used in a context that expects an expression of type u64. Addresses-Coverity-ID: 200604 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva --- drivers/media/dvb-frontends/ves1820.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/ves1820.c b/drivers/media/dvb-frontends/ves1820.c index 1d89792..9dbd582 100644 --- a/drivers/media/dvb-frontends/ves1820.c +++ b/drivers/media/dvb-frontends/ves1820.c @@ -137,7 +137,7 @@ static int ves1820_set_symbolrate(struct ves1820_state *state, u32 symbolrate) NDEC = 3; /* yeuch! */ - fpxin = state->config->xin * 10; + fpxin = (u64)state->config->xin * 10; fptmp = fpxin; do_div(fptmp, 123); if (symbolrate < fptmp) SFIL = 1; -- 2.7.4