Received: by 10.223.176.5 with SMTP id f5csp3727055wra; Mon, 29 Jan 2018 18:31:39 -0800 (PST) X-Google-Smtp-Source: AH8x225dt84geH5uxnCz5hBR6tbdrKuoEe/PrmRd50sOfxruvLFf6dKi9e9o7pF4zU141ZAIlRbM X-Received: by 2002:a17:902:7581:: with SMTP id j1-v6mr2798109pll.86.1517279498979; Mon, 29 Jan 2018 18:31:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517279498; cv=none; d=google.com; s=arc-20160816; b=Ip7T0mEBpLKqmtVhYyuLFt2PXaJzev2hE5i9QIkG6mhL3TsbguJ1mvobNX1LBAAXOk x626RdZFrkLqTy/3HrfqfFc8+xeKCYf2BO/FvrHFcxdyY0qnDXWqo+lDsnREo/jG87O1 zdsThIfSSfJ57xkq/vPg2wRg0WX2bL9dLuPz9VrT9IcEpqLq+kZ8+h2M45zVXNUrOpVI MU89QPNaviloXOHA0Uo5sC1JdXOFt+qFvb0e71EaAh/r2t87v14Q8Fz6A90y7JTY9buC UmfYG5o1uNrfBR2iyI+yXpikBqkTpksRtMF6aLJxlakjP85VcGq1uD8Bpok5ogHQquJ/ nE9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=1ivDuVTdr29IRFVwTmYWhOlHr70/ZV5rhHTQJW0GIIc=; b=kR0vgK069YpqbHZfMJFS+W8Xsa/l64ItMEGlq63XtBK7XIH8wIgmKTLRrSrLN77AS3 OcDSRK4xnB+lp6dPl+MACewXX1dL0etZ5vlMcC5UGGY4brZ2rluK9PF9J0Sh6nSleRy1 UDI3LDs152BJz22A6aROYubZEiIeVymWb3cKoU5I17BFeJ8KXGpSZQCNTp0hYRbjKqHY wybs2buQTuQvKfXrTfklC34X1MKSxA9gOKaBru9whu5nzQK/lS3coJGaHXQ0/phbiFIm veXasE+6hGzoZhutOcr+1ZHML3/RDwxPF9KtYn2jrmYO2Sj9LDBxSDugDjD/JqDdjvRn BiQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=L9LpFsV4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b187si373316pfg.66.2018.01.29.18.31.23; Mon, 29 Jan 2018 18:31:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=L9LpFsV4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752378AbeA3CbA (ORCPT + 99 others); Mon, 29 Jan 2018 21:31:00 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:38391 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbeA3Ca7 (ORCPT ); Mon, 29 Jan 2018 21:30:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1ivDuVTdr29IRFVwTmYWhOlHr70/ZV5rhHTQJW0GIIc=; b=L9LpFsV4MJEIfIQEuMQjwQ7ve qsvQhJgsz9LZfWq7xqsIpg+QxqitjkWjTpPaIcTBYjwRx5Ku1qRG+h/XwAPMXaZOohllr80xCkCnk HhQcPigaIM43SJMwsz4bEWg4NvZeyWUeMVVVAJrizKpJv/Z8cDPEB0nj5BJIIskQnakfulp7J3Ega 5sv+cwd74dIdM1ukpDOIn+XOrDnRseDWgXCWW9VmG3rE8LK6nSr3XmyhfTwpvQXF3ImsSAlkewDpc +kkeB5rDNoslzn4wBOl2nw2DHHFfCgi3eslQsTRXPHqz2wcOzHmmsq964jYryV0euFPSmRQNmSDZl s6hVgfikA==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.site) by bombadil.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1egLhJ-00014h-O6; Tue, 30 Jan 2018 02:30:57 +0000 Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c To: Lee Jones Cc: Meghana Madhyastha , Daniel Thompson , Jingoo Han , Thierry Reding , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Tomi Valkeinen , Daniel Vetter , Sean Paul , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com> <20180126094839.iksjiw4xj2n62yzn@dell> <20180129091120.xs74nu75fype2amq@dell> From: Randy Dunlap Message-ID: Date: Mon, 29 Jan 2018 18:30:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180129091120.xs74nu75fype2amq@dell> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/2018 01:11 AM, Lee Jones wrote: > On Fri, 26 Jan 2018, Randy Dunlap wrote: > >> On 01/26/2018 01:48 AM, Lee Jones wrote: >>> On Wed, 24 Jan 2018, Meghana Madhyastha wrote: >>> >>>> Add of_find_backlight, a helper function which is a generic version >>>> of tinydrm_of_find_backlight that can be used by other drivers to avoid >>>> repetition of code and simplify things. >>>> >>>> Acked-by: Daniel Thompson >>>> Reviewed-by: Noralf Trønnes >>>> Reviewed-by: Sean Paul >>>> Signed-off-by: Meghana Madhyastha >>> >>> Nit: These should be in chronological order. >> >> Where does that tidbit of information come from? >> I have never heard or read that. > > Not sure it is documented anywhere. It appeared to be the widely > used, most sensible approach, so I adopted it a few years ago. > > This method provides us with information which would otherwise be > absent; including description of the patch submission/acceptance path > and an idea of who did what, when. > > For example: > > Original Author sign-off > Original Co-author sign-off > [Additional contributions: rebase, API changes, fix-ups] > Re-worker's sign-off > Tester's tested-by > Reviewer's acked-by/reviewed-by > Level-2 Maintainer sign-off > Level-1 Maintainer sign-off > > Are you aware of a more functional/practical/useful method? No, I'm not. Do you do anything else with this chronological order? E.g., do you verify that someone actually did Ack or Test or Review a patch? Sean: that dim tool looks interesting. I'll check it out. thanks, -- ~Randy