Received: by 10.223.176.5 with SMTP id f5csp4046743wra; Tue, 30 Jan 2018 01:03:31 -0800 (PST) X-Google-Smtp-Source: AH8x226Ii24wvhDeQK5mcyVbeqPQ5EMa4f2VAtbggS85Fdw9yt2QR4UU5qb3feoqH+YE57lP/UPD X-Received: by 2002:a17:902:12f:: with SMTP id 44-v6mr23105753plb.403.1517303011834; Tue, 30 Jan 2018 01:03:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517303011; cv=none; d=google.com; s=arc-20160816; b=qHbL3YPaLk0V5MP5LuSIE9cGxLrOPuvrOO4YyBosvcbG2w9k0w5HU+VQVYocCnYUSE DdnmPaM9iL4d5wjG6EO9OG9DaDbfMrzJkKVgxF1zR8AHa6XSnPcbmzfJRaW59w5NlCBz pq1LkZ/+WYtwDlP8Vt4pZKVLjc0LKDI59S30uvIAh1pQHpuOxtVftrl4GHZAEC8bAoNN at0wa162TZYjPS5aheAeR2GLjTHKOgQM6qbc32D1zjJx8JgQ729u4AeeYtoJny+MK5MJ hOhb/wJODiG0Z9ozMV6kkzINvg0FX8mdg1N7v6jvftQdIkfcWp9NRwMyfuw1iOYZ/mes ZxMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=TQZyxD+TCiYX6MeL7Y13/P4VEP4zDQUF0A94LFLaDQ8=; b=YR+xVbFYgofAKkOGXIi4z9/Ne5CTmxIql0W8J5ABmI1Fn9eUbUJATJ2uz4/16cCnM1 GPfJ4STezqfqrmaMZjKrzwk4V2GWgeM7mu8f5DvgKX6pDnncZ4acxOIF848gyEVfAhoT fvhL2nziHAIhnT+BVyvqjf0/VH9RJho6FQPNQKD4a1XJHcAkskmHGNiXlFRq7wKXZyyf /u2V80qRVf/k7WwKoV6IPPeOpdciqrJ5tkbLBZmQ2SWbtp4s9SKOPktk9oreh/u4+tvI NVb/XNR54VuAHYqfp2t7Z99sNtXTiRnGvkxRZ2KQXOX6tzSaQm29nEM1UxKApkd1Lj2R JPLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VXwuiCWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si13726788pfi.187.2018.01.30.01.03.17; Tue, 30 Jan 2018 01:03:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VXwuiCWp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbeA3JCi (ORCPT + 99 others); Tue, 30 Jan 2018 04:02:38 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:52276 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbeA3JCb (ORCPT ); Tue, 30 Jan 2018 04:02:31 -0500 Received: by mail-wm0-f46.google.com with SMTP id g1so19467091wmg.2 for ; Tue, 30 Jan 2018 01:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=TQZyxD+TCiYX6MeL7Y13/P4VEP4zDQUF0A94LFLaDQ8=; b=VXwuiCWp5SyL6A1ql+Dua2bTGAprqLcV+TxWVQkSgihqyA30Nuc4FADQrO1Dk/F8BK p8dPE1IiZvo8gm9/8vVMrROJb5q+yDDdGy9iV2jdwcW3C9C0gbS+dFTEMsxZmCnFwfVH RlvNMd6DbzdjgV7oL1Mfq/UtHxhQb3i/NQaDM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=TQZyxD+TCiYX6MeL7Y13/P4VEP4zDQUF0A94LFLaDQ8=; b=lpSGBC5DBM4YYyquZT1iHoVvHUIZsrgW1XK2kDcTybRG4Btd9riOZgssLjcfifTYCR 8zT0Ogh/sy2LydIvYA2u1ZWAt1cUrXKfBOSvy6ePSz2ANgGeecStBwZROhJGbxE7wEmO LaW53OuJ2+wjVPqS5maxf5I4tE0pzYMNTraoWILiCM8mpehN8Xf82LZMWnrTpDCCv5Te 2BWikO+ugvZII5z/QfO8pJdTceBPOotgjo0k7BeYiK1zBO1Ke7ufFujJKCPYh97wUJ7g gPzj6GdRyLp24e9Iu2ON3Vu1Y1muAVonP300FA6Hk6VZ5bWVKCHyU8bMc2jUW4AZlZY7 QgXA== X-Gm-Message-State: AKwxytfzvM0RFgocGijMTG81ODI5HTI2H7J8cdb4ixSUJOiT6fHqF3xu JJnL1B2XwdzCUUrgFlDKrq4BFw== X-Received: by 10.28.71.198 with SMTP id m67mr22075039wmi.40.1517302949952; Tue, 30 Jan 2018 01:02:29 -0800 (PST) Received: from dell ([2.27.167.62]) by smtp.gmail.com with ESMTPSA id m86sm15596529wmi.40.2018.01.30.01.02.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jan 2018 01:02:28 -0800 (PST) Date: Tue, 30 Jan 2018 09:02:26 +0000 From: Lee Jones To: Sean Paul Cc: Randy Dunlap , Meghana Madhyastha , Daniel Thompson , Jingoo Han , Thierry Reding , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Tomi Valkeinen , Daniel Vetter , dri-devel , Linux Kernel Mailing List Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c Message-ID: <20180130090226.d33reyxzvorvtyay@dell> References: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com> <20180126094839.iksjiw4xj2n62yzn@dell> <20180129091120.xs74nu75fype2amq@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Jan 2018, Sean Paul wrote: > On Mon, Jan 29, 2018 at 4:11 AM, Lee Jones wrote: > > On Fri, 26 Jan 2018, Randy Dunlap wrote: > > > >> On 01/26/2018 01:48 AM, Lee Jones wrote: > >> > On Wed, 24 Jan 2018, Meghana Madhyastha wrote: > >> > > >> >> Add of_find_backlight, a helper function which is a generic version > >> >> of tinydrm_of_find_backlight that can be used by other drivers to avoid > >> >> repetition of code and simplify things. > >> >> > >> >> Acked-by: Daniel Thompson > >> >> Reviewed-by: Noralf Trønnes > >> >> Reviewed-by: Sean Paul > >> >> Signed-off-by: Meghana Madhyastha > >> > > >> > Nit: These should be in chronological order. > >> > >> Where does that tidbit of information come from? > >> I have never heard or read that. > > > > Not sure it is documented anywhere. It appeared to be the widely > > used, most sensible approach, so I adopted it a few years ago. > > > > This method provides us with information which would otherwise be > > absent; including description of the patch submission/acceptance path > > and an idea of who did what, when. > > > > For example: > > > > Original Author sign-off > > Original Co-author sign-off > > [Additional contributions: rebase, API changes, fix-ups] > > Re-worker's sign-off > > Tester's tested-by > > Reviewer's acked-by/reviewed-by > > Level-2 Maintainer sign-off > > Level-1 Maintainer sign-off > > > > Are you aware of a more functional/practical/useful method? > > Our tooling adds a Link: tag to the commit message pointing back to > mailing list archives. This provides more detailed patch provenance in I've been avoiding using tooling for Maintainership for a long time. I really do not want to go via that route. The simpler the better as far as I'm concerned (KISS [no, I'm not coming on to you!]). Also, a ML link only provides you with information on the final iteration of the submitted patch, and still does not provide information on who did what, when. > addition to reducing the burden on contributors to order tags It's not really much of a burden. Just keep putting the tags at the bottom when you collect them. Fortunately this is most developer's default pattern, so I do not have to bring this up much. > correctly (I had never heard of this as a requirement either). Check > out [1] if you're interested. > > Sean > > [1]- https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html > > > -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog