Received: by 10.223.176.5 with SMTP id f5csp139833wra; Tue, 30 Jan 2018 09:11:46 -0800 (PST) X-Google-Smtp-Source: AH8x226YkldUG6Nz89GBaAAcZ9qc1ZSFhD6YWWQhR0CMGfVHVqTIeMeOl+ynXCFvS5k+s8bgTdna X-Received: by 2002:a17:902:8545:: with SMTP id d5-v6mr6004359plo.306.1517332306204; Tue, 30 Jan 2018 09:11:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517332306; cv=none; d=google.com; s=arc-20160816; b=PDaP0FMlwburKTiNm7GQMMbL/CDg7jVs+5aG1z0QODibBQXQOuD7vC0GCk7eDfgsir kAhVZQOE6xl53eLPSKcnqvyzDjd7RLc46kNmOfI+WI4n49LIu/4pnmOXbP1B3hz8tdCV Ne9yMh/Rc8c3yuwKGlpqXGEZTP7p4n5IfdOCO+trGiKBSEVhnlB5eqeAVywN3K8ySRsk UAEzsRtmyO8AANrd1hwBoMoo3g1pNIy71M9+K0WuJRwxbUXJ6qk7zT7+suwokNNLwxMg X+Ew0NNAT6ywqevHb75fP2w0vON7zWiJ8CNxC/S96z7boYQdZONLLavNykgNtRTkQzPU wjSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=gA3NHQfsjbaz0/VTlv8appJjw/05wPTQ6oPShjIvdqA=; b=GSjMRYdC0CoqDiQyiZLVssg5NJ0wbGQaBZjs5Dkqkrt69XrhIhMkV1O1YCW5fCLk4W ufcYMC0Y249MIbonpDyup531Wup65w3qcbsD/k9iQqRzZwRJL/7a63s0d2Ve51CsRbBj ceOZj9HqvZCWaoe5Qc9LbZqAPQ+sSucorqLC5amFRUQzEyRMUKxokQbX3pHsGYbQ6pv3 lt2ZWdLAXSMdAWo+EzTx4ljmhDT/rbDF4kqdO6ZnIxV3huZEi1fnD1t6PMulS1y/kH3E zB/M0hSZFHcHiUvDwfcWjd0WdDEW0BzFj47eaTSBI26YvvHN2NAgtw316wosbN6gglnx 5lHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=w2n8ZMVv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a80si14758882pfg.372.2018.01.30.09.11.31; Tue, 30 Jan 2018 09:11:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=w2n8ZMVv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbeA3QIj (ORCPT + 99 others); Tue, 30 Jan 2018 11:08:39 -0500 Received: from imap.thunk.org ([74.207.234.97]:44560 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbeA3QIh (ORCPT ); Tue, 30 Jan 2018 11:08:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gA3NHQfsjbaz0/VTlv8appJjw/05wPTQ6oPShjIvdqA=; b=w2n8ZMVvFonbMeTwNDdKueoIZW Bpkk5VqvH/z7myOJliPVNKXjr+X7+qf3jiOZUncL8AlCYJp8y0COH5pryqvwmawjqVJ3Ahv1/T7Nu NkNjFWK0DHPIqq5oA2y9AO2mUxmvyHKgPMRZI2A4LmIpRWi1QKl/U3RrZP4N2ZgtIUGM=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1egYSX-0006GK-2z; Tue, 30 Jan 2018 16:08:33 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 3B79A7A03B4; Tue, 30 Jan 2018 10:15:43 -0500 (EST) Date: Tue, 30 Jan 2018 10:15:43 -0500 From: Theodore Ts'o To: Jeff Layton Cc: Linus Torvalds , open list , "" , Al Viro , xfs , "open list:NFS, SUNRPC, AND..." , linux-btrfs , linux-integrity , Andrew Morton , "linux-ext4@vger.kernel.org" Subject: Re: [GIT PULL] inode->i_version rework for v4.16 Message-ID: <20180130151543.GB8351@thunk.org> Mail-Followup-To: Theodore Ts'o , Jeff Layton , Linus Torvalds , open list , "" , Al Viro , xfs , "open list:NFS, SUNRPC, AND..." , linux-btrfs , linux-integrity , Andrew Morton , "linux-ext4@vger.kernel.org" References: <1517228795.5965.24.camel@redhat.com> <1517313948.3658.8.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517313948.3658.8.camel@redhat.com> User-Agent: Mutt/1.9.3 (2018-01-21) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 07:05:48AM -0500, Jeff Layton wrote: > > I want to make sure I understand what's actually broken here thoug. Is > it only broken when the two values are more than 2**63 apart, or is > there something else more fundamentally wrong here? The other problem is that returning a s64 (or a u64) is extremely inefficient on a 32-bit platform. So in general, it's better to avoid returning a 64-bit type unless it's really necessary.... - Ted