Received: by 10.223.176.5 with SMTP id f5csp164373wra; Tue, 30 Jan 2018 09:34:04 -0800 (PST) X-Google-Smtp-Source: AH8x225evo/weDG9DD9wpZpQSLuKjCMr0lxVmM/0ysMHMwF5mJEIUCgeehpdnKV8wuKqN6lc+SDb X-Received: by 10.99.104.200 with SMTP id d191mr24404437pgc.98.1517333644210; Tue, 30 Jan 2018 09:34:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517333644; cv=none; d=google.com; s=arc-20160816; b=uzuvjlP4oMikzzCKZ7cOy0bHdl4pNlDiNtVSIGO3zkao5OehYcniHm0TSfS9x7CBMS dRmpS3meVPTuBqrxKUDs27rnTnDaSu7DHlpYSappe9jdIFlf3LjSlyQhWX4rgnuV8mAs jfe5uDr0VfNFAwRQpwNck0YKsG6xj9P4fdXHnR+cABJZxeuHEfzuHJDWUcr++NAez699 XVhfmJLxBUQgL6Q5jWJMG86+qriCB+C0Cv/zPQxPam7TL575FnLhnzOUvRAFOBr/Vr8o Nhpg1dY+4kMBmAcLtQgDxGzzXspk0QW37QP46M6Y6cXO1mVpOP82VY6/s9FDMx/eIJc/ ADbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=yXUVZUR45ENJdAzQ9ogFhmsJm1gTubHXcMmXbUJQzB8=; b=EU2jJigQMUDPg9tRksBUOwXoR9WX7coZHBmjJESzqbjYIU18mTTqsAIt57RZf8myjU dDig7ZXi2eXEo8zC3J6IQxS7vsmX2oKv6ZnZ59Y4m2KYwYi3jl/EeL9lN9CH4FEqrZXL XnOTe2nKNBxwHQe1pGbNwsqPgsiXXack8WOBl+sSXfpUlqzDEtdejobzbZdxyEo+ylbA E6kvtWg0vvWfRrwwzUl8iIvraMcPSBzgDTRQ/XeBwhlPLk6Z1ZARf2L/sUpMo0zs1CXg qaDMvq379aIrwYcfYI3YWtXM0FAX20pOUSAOAVrJpoUDyJsw6528ZDW+09Lpi5+aQSm6 diUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ERRDhbIP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2si73314pgv.493.2018.01.30.09.33.49; Tue, 30 Jan 2018 09:34:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ERRDhbIP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbeA3Qs0 (ORCPT + 99 others); Tue, 30 Jan 2018 11:48:26 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:38427 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbeA3QsZ (ORCPT ); Tue, 30 Jan 2018 11:48:25 -0500 Received: by mail-qk0-f196.google.com with SMTP id t134so10925947qke.5; Tue, 30 Jan 2018 08:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yXUVZUR45ENJdAzQ9ogFhmsJm1gTubHXcMmXbUJQzB8=; b=ERRDhbIPTwYQ9WYNmexbDTabFpOGB8Xi2tX+0P4gqSq2PVJeMPCHz95jB4XhWz40hI /7KiwbaZkNJEN29HFv0CbRW6Vak1ap8g2j8apPd8CAGbhjAHSTt9Hvi15h6Gh/ZTVVNF aAQoHfbl+bqFqbKK+qPdkQquKZWj4WEGaiKp6Yn5D0aMG0/BK8x5osh/Xs9e72NPHLUT D/sJgT9vedAZGmejJkAiu+z9l/m7KGiuEr6n+Vl/f01hBMCrAHSHvG8ch06/Zb4UpO1s llxckdfqi10WSw7S804xZTSaS2SuP+H9DFCFm58i6EnE5NMg19ibY17IlRkcHQqWZp57 HIoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yXUVZUR45ENJdAzQ9ogFhmsJm1gTubHXcMmXbUJQzB8=; b=pRYFIR0wb2rzhbepxvIrEq7jRe7JjtapsYuJ4Roqv2c+A/731CxKsk+54G8IBxwrQI Jumpqv9uaTML+GCXMcYsRtSLx4d1Ng3u7E2rT4K5tOoG7vN7S3D13hw9hxwzU6qYgT+v eCK4cfOhcxkMceNe42Le3nS0KBdFAocs8qkAhVikHlPKqGAmBaiwaYlpL0/VRbzx+e3z uEhnTw9Kk3+tKrJoUdwuzRxSizr/pgpnpabTQDmbGoMh0+IqDSOmD1l44UuYkQQ1ssVM p+bfCnRIDZWtvYXgE1d0X1Vuf67qDj9wDBKXkOYncqxJUuaawKRV+2EnxB6x6EfP2ExV E6LA== X-Gm-Message-State: AKwxytfCexi9jSgsARpF10G/A8h4wi6yrJWuPny+rN42kEoYS1+O6G5S TwNy3ztbiUTWjnQQlVqV9oGr3Gql06Jf1X2pSrw= X-Received: by 10.55.39.78 with SMTP id n75mr10344384qkn.24.1517330904511; Tue, 30 Jan 2018 08:48:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.175.35 with HTTP; Tue, 30 Jan 2018 08:48:23 -0800 (PST) In-Reply-To: References: <2834309f69a1ec37b84a33f153a3d0b90336bcc6.1517313987.git.baolin.wang@linaro.org> From: Andy Shevchenko Date: Tue, 30 Jan 2018 18:48:23 +0200 Message-ID: Subject: Re: [PATCH 2/2] gpio: Add GPIO driver for Spreadtrum SC9860 platform To: Baolin Wang Cc: Linus Walleij , Rob Herring , Mark Rutland , devicetree , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Mark Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 30, 2018 at 2:07 PM, Baolin Wang wrote: > The Spreadtrum SC9860 platform GPIO controller contains 16 groups and > each group contains 16 GPIOs. Each GPIO can set input/output and has > the interrupt capability. > +config GPIO_SPRD > + bool "Spreadtrum GPIO support" Either you have to put tristate here, or remove all redundant module_*() and MODULE_*() macros. Other than that looks fine to me, FWIW: Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko