Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Jan 2018 18:46:25 +0000
From:   Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Steve Presser <steve@pressers.name>,
        Hans de Goede <hdegoede@redhat.com>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Jeremy Cline <jeremy@jcline.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Lars Kellogg-Stedman <lars@oddbit.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Wolfram Sang <wsa@the-dreams.de>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio: accel: bmc150: Check for a second ACPI device
 for BOSC0200
Message-ID: <20180130184625.3ca09e82@archlinux>
In-Reply-To: <20180130183343.2bf379d0@archlinux>
References: <010001602cf53153-39ad69f1-1b39-4e6d-a748-9455a16c2fbd-000000@email.amazonses.com>
        <20171210182152.70ad8fbf@archlinux>
        <01000160dccefcb4-25edfd89-56f3-486f-88a4-cb8c07253974-000000@email.amazonses.com>
        <20180114104330.2aa7c1fd@archlinux>
        <20180128094021.572ab366@archlinux>
        <CAHp75VenBEYSZ9okZfGZUmBX+ikL236a9_qjtn-DJtSihw5X+g@mail.gmail.com>
        <20180130160107.000006df@huawei.com>
        <CAHp75VchRJzp1CM33q18e9x8Uq7bNrPZykz-GdpRgB3=y2C+KQ@mail.gmail.com>
        <CAHp75Vf==OQ=Cx4Nzrd+vAOJshT-oL6L8Y54aWt0cGyJJuacjg@mail.gmail.com>
        <CADXBfmvKF_doLv0Vg0TY4cH_rDBEP5NvJ4jHJf85iuOjJB6TzA@mail.gmail.com>
        <CAHp75VdsDAbgJ1XmhaxA5C8FTcYX7tBa4x_Y4ZYk6Sub510nqw@mail.gmail.com>
        <CAHp75Vd3pDFk5NnJrak_smS-AeHh+d-GXaOwp-8mHtyaK+y0jg@mail.gmail.com>
        <20180130183343.2bf379d0@archlinux>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 30 Jan 2018 18:33:43 +0000
Jonathan Cameron <jic23@jic23.retrosnub.co.uk> wrote:

> On Tue, 30 Jan 2018 20:08:19 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> 
> > On Tue, Jan 30, 2018 at 7:38 PM, Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:  
> > > On Tue, Jan 30, 2018 at 7:25 PM, Steve Presser <steve@pressers.name> wrote:    
> > >> Andy,
> > >>
> > >> Where did the assertion the second device is a magnetometer come from? Just
> > >> the data sheet?    
> > >
> > > Yep. See chapter 8.2. Isn't enough proof? Or you believe in two
> > > accelerometers with off-by-one conflicting address on a cheap laptop
> > > with left unused two magnetometers on the same time?
> > >
> > > And we have a driver for magnetometer separately.
> > >
> > > So, it looks like we need to move ACPI ID to a new "kinda I2C mfd" IIO
> > > driver under drivers/iio/imu/bmc150_i2c.c    
> > 
> > Even Kconfig for one of the driver states so.
> > 
> > Looking more to it, I think the patch should be reverted and new
> > driver is created instead.  
> 
> Whilst the question is still open I have dropped the patch.
> Was not yet in a non rebasing tree (just in a build test one)
> so fine to drop it.

Should have said this isn't the final decision or anything, but
whilst there are open questions we should take the time to sure
of the answer!

> 
> > 
> > I'm on it.
> >   
> > >> Steve
> > >>
> > >>
> > >> On Tue, Jan 30, 2018, 12:05 PM Andy Shevchenko <andy.shevchenko@gmail.com>
> > >> wrote:    
> > >>>
> > >>> On Tue, Jan 30, 2018 at 6:40 PM, Andy Shevchenko
> > >>> <andy.shevchenko@gmail.com> wrote:    
> > >>> > On Tue, Jan 30, 2018 at 6:01 PM, Jonathan Cameron
> > >>> > <Jonathan.Cameron@huawei.com> wrote:    
> > >>> >> On Mon, 29 Jan 2018 16:07:02 +0200
> > >>> >> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:    
> > >>> >    
> > >>> >>> > But that would take much longer.  Feel free to propose it and a
> > >>> >>> > patch
> > >>> >>> > removing the ifdef fun if you like!    
> > >>> >    
> > >>> >>> Where can I see the patch?    
> > >>> >    
> > >>> >> Doh. I clearly forgot to push out.  Should be able to push to
> > >>> >> iio.git on kernel.org later.    
> > >>> >
> > >>> > Thanks, I can see it now.
> > >>> >
> > >>> > This patch almost wrong. Not by functionality it brings, but by style.    
> > >>>
> > >>> Oy vey, the second device is *not* accelerometer, it is a magnetometer
> > >>> [1].
> > >>>
> > >>> [1]: https://www.mouser.com/ds/2/783/BST-BMC150-DS000-04-786477.pdf
> > >>>    
> > >>> > I'll send soon a series of fixes to the driver (compile tested only)
> > >>> > to provide my view on the matters.
> > >>> >
> > >>> > P.S. In the future (I have some kind of deja vu I have told this
> > >>> > already to someone), please, Cc one or more of Rafael, Mika and/or me
> > >>> > for ACPI matters.    
> > >>>
> > >>> --
> > >>> With Best Regards,
> > >>> Andy Shevchenko    
> > >
> > >
> > >
> > > --
> > > With Best Regards,
> > > Andy Shevchenko    
> > 
> > 
> >   
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html