Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] x86/speculation: Use Indirect Branch Prediction Barrier
 in context switch
To:     Borislav Petkov <bp@alien8.de>, David Woodhouse <dwmw@amazon.co.uk>
Cc:     arjan@linux.intel.com, tglx@linutronix.de, karahmed@amazon.de,
        x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org,
        pbonzini@redhat.com, ak@linux.intel.com,
        torvalds@linux-foundation.org, gregkh@linux-foundation.org,
        mingo@kernel.org, luto@kernel.org, linux@dominikbrodowski.net
References: <1517263487-3708-1-git-send-email-dwmw@amazon.co.uk>
 <20180130203836.bsgme6kf6hstgbrx@pd.tnic>
From:   Tim Chen <tim.c.chen@linux.intel.com>
Message-ID: <024dd53b-1912-34fa-deb8-550c111df521@linux.intel.com>
Date:   Tue, 30 Jan 2018 13:03:20 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20180130203836.bsgme6kf6hstgbrx@pd.tnic>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01/30/2018 12:38 PM, Borislav Petkov wrote:
> On Mon, Jan 29, 2018 at 10:04:47PM +0000, David Woodhouse wrote:
>> +		if (tsk && tsk->mm &&
>> +		    tsk->mm->context.ctx_id != last_ctx_id &&
>> +		    get_dumpable(tsk->mm) != SUID_DUMP_USER)
>> +			indirect_branch_prediction_barrier();
> 
> Ok, so while staring at this, someone just came up with the following
> sequence:
> 
> 1. Malicious process runs with UID=A, does BTB poisoning
> 2. Sensitive process (e.g. gpg) starts also with UID=A, no IBPB flush occurs since task is initially dumpable
> 3. gpg now does prctl(PR_SET_DUMPABLE, ...) to clear the dumpable flag
> 4. gpg now does sensitive stuff that it thinks is protected
> 5. gpg does indirect branches that shouldn't be influenced by the malicious process
> 
> Now, if you switch between steps 3. and 4., you're good because gpg
> became non-dumpable. But if you *don't* switch, the bad BTB entries are
> still there.

The attacker has to guarantee itself to run right before victim. And
the window of attack is very small, as only the first context switch to victim
may be vulnerable. The victim will be immune on the next switch.  
For timing attack, the attacker needs to scan one bit at a time.  
So probably the attacker could glean 1 bit of information
on the switch back to the attacker and then the attacker could not scan
further.  So it doesn't seem to be very practical attack if the victim
has set itself to be non-dumpable.

Tim

> 
> So, *actually*, we need to flush IBPB in set_dumpable() too, when we
> clear SUID_DUMP_USER.
> 
> Or, are we missing something obvious here and that is not needed because
> of reasons I haven't thought about?
> 
> I know, gpg doesn't do prctl() but disables core dumping with
> setrlimit() but there might be other processes who do that...
> 
> Thx.
>