Received: by 10.223.176.5 with SMTP id f5csp697927wra; Tue, 30 Jan 2018 18:03:07 -0800 (PST) X-Google-Smtp-Source: AH8x225PaGaJtrCsJrgkEwwbAi3Dt1szw0ce7W+3HiHYUp4a5IZkbUonl7ckQt/OM/IqkUxj8nbt X-Received: by 2002:a17:902:6e4:: with SMTP id 91-v6mr25960395plh.26.1517364187151; Tue, 30 Jan 2018 18:03:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517364187; cv=none; d=google.com; s=arc-20160816; b=vxT1QN9fRCaccrE5nD+8m9DW2awYG/e8Dn4fTWefPd38wFL1nDe7Jb4LEeERhRB75I uZX2y3XiNHkvMsfL/vlpyuzuU/tzA/e6u9FOSSW8NYLOFDlgkPQN1LDSnNbGt4IWDgvy f9MalvAuPM7XuihG3cUp4sSywubwPIWcNPUPUj6AOLVH9R1HwpMw0EQPUp9efTxOpSLc 1mlC5LaiWqnZfLnb18fZrV0kLDnKyKeQZ2XkTPG8hns/HaBcYgR4mN34I2NvCHpxL9ea YTFZMArbgAyQ2O5WtP5fDASGb0vCi8dr8FLbX42T0U5xn7GSoMUAcVkiQNleMrc+3lcv g62A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:to:cc:in-reply-to:date:subject :mime-version:message-id:from:dkim-signature :arc-authentication-results; bh=KY56YP6IG5enRSRs2Ge+trttg2KKdu28hC653tz1bzE=; b=NZSuaBI1X7OGWrwIzUp7+A2XvD3sahzk5cR+7/BmfvO/pBfYiFuw4NNTpWe+Fe6Uh+ OnE2q44KqP1ANKv9wx2LFV4rykUvautcl8m0eTYoqA8+7j/eVchn2TWxGq5NjCK0YZgo fOAI3z4/9gEDjYlRjX6Hulv15125ZIOdP7Mn+fKiGvEh6RsgR3BFiTY4RL8DFAkM9US6 BvMgaXNOSzck0fVuaJMlzuJvXk6MiS+1kAp6EVyAkmt5VtqIEragLPVr00wr5WV9S56Q 8s8x1KFQvAeWLxuLXXk9pxZltf8bZ49F1QnBmi7+1Af6p9Fylq9I0Ltouc7+p8ehhF4N 48Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=BsWnckzB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y20si574582pgv.723.2018.01.30.18.02.52; Tue, 30 Jan 2018 18:03:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=BsWnckzB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbeAaBzb (ORCPT + 99 others); Tue, 30 Jan 2018 20:55:31 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:41330 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbeAaBza (ORCPT ); Tue, 30 Jan 2018 20:55:30 -0500 Received: by mail-io0-f194.google.com with SMTP id f4so13667501ioh.8 for ; Tue, 30 Jan 2018 17:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=KY56YP6IG5enRSRs2Ge+trttg2KKdu28hC653tz1bzE=; b=BsWnckzBUUThnPPnKxIiCmEohLZq2eIWC3E5kT5IW8a0VAdnzlfE0S5ZrC5JbFyFSk 7+8gHzIXrDjHNt+bsbOwchx7s3VUYPrhDHcR6mXNNKPBQDt6ungelwii/VPgFlX+pQ9B +KitqB+d+PgrtA+lrEtp4t85tLvrgN2Wz4fjcBGJNKM07CUi2RvP9borlRhhO9LXkR7f /b4mM+BWv7gs3HaqlhvoU/R7JXPldd39M+H7VdewmjbD0jmXppeziZNzYeyHIF3RzXQY mGdPbxfvHgFQTGAYpGlVqmdglPAfTgbZ2XDdMDj2CX/YU1zMqFYlb766JUbuuAqYUlf+ O5bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=KY56YP6IG5enRSRs2Ge+trttg2KKdu28hC653tz1bzE=; b=eoPwUD5pyfz3sTuARV+tk2ukZYQOgRxuMNBCQ3iIxw6CElH/+qO5ljuW/FRaouEwTb 5ISgXGgTED4LdQwVDC6rzYS10CNvSpk5/TDg+3QKaUSwlYWIabgzkeaFAcrPfKdVEE10 j4ZG0xamZO0Gc4awNaSsgpiufFemx0HMfPX5J6UNXi19uEyPoEfes2Z0Yf6yQTpGRtDm QhotMulo99BRKC5q+bsv/0rrmgWicNEswgbhhk2W3NCJq6Nl3c3f+TUp3hNOaFweyz8J 8SqwHlEI6Sn+zovikkJM+SxWCJdavRSDeQGsHE5dhN2TobSHhs1cyo+wCoDyiqAbORUm g27A== X-Gm-Message-State: AKwxytdp1FVcv8HAAKjCHnw9q6AgLd1/cIQ9iE11inT/JSmtRqcj+1Eo 20jIyeXjTj13izGLXNpFDl8Bhg== X-Received: by 10.107.17.211 with SMTP id 80mr32644309ior.11.1517363729439; Tue, 30 Jan 2018 17:55:29 -0800 (PST) Received: from [172.31.1.2] (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id y6sm6624956iod.7.2018.01.30.17.55.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jan 2018 17:55:28 -0800 (PST) From: =?utf-8?Q?Javier_Gonz=C3=A1lez?= Message-Id: <0FC27C54-C199-4A6A-9948-E7AD9D3B86BD@lightnvm.io> Content-Type: multipart/signed; boundary="Apple-Mail=_DB1E0402-3C01-4D72-A1DD-86D2A5AFC2B2"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH] lightnvm: remove chnl_offset in nvme_nvm_identity Date: Wed, 31 Jan 2018 09:55:11 +0800 In-Reply-To: <20180130143050.18355-1-mb@lightnvm.io> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org To: =?utf-8?Q?Matias_Bj=C3=B8rling?= References: <20180130143050.18355-1-mb@lightnvm.io> X-Mailer: Apple Mail (2.3445.5.20) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Apple-Mail=_DB1E0402-3C01-4D72-A1DD-86D2A5AFC2B2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 30 Jan 2018, at 22.30, Matias Bj=C3=B8rling wrote: >=20 > The identity structure is initialized to zero in the beginning of > the nvme_nvm_identity function. The chnl_offset is separately set to > zero. Since both the variable and assignment is never changed, remove > them. >=20 > Signed-off-by: Matias Bj=C3=B8rling > --- > drivers/nvme/host/lightnvm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 Looks good. Reviewed-by: Javier Gonz=C3=A1lez --Apple-Mail=_DB1E0402-3C01-4D72-A1DD-86D2A5AFC2B2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEm1mT7zen+vs9+T8kYx8FO3WZGMoFAlpxIgAACgkQYx8FO3WZ GMowKA/9F/+E7j9dKWNC3V3RclaZ16XB2kakTmFGQSObwC/Pir2jl4BJnhGlhkwU 1CnLDyRA6M3fSHJ4mg6riwVcSJCQNsxBIUG+6tE4hHTdu85yvxNROXoMfq5dLHVW rb1wTaGULk5O3lJJS4xNd/l1GGxRhpM+r9rShSbJmHJlx7xVAWJAX39uKFT9YmOq jF2yd/i/ZF6+H/uXB9/nGOPdpoXCCzbbwAGIfQu7qhx8WVXdumDxwl8O+rvHf4M/ dslgwInOZ3sRig+TNhhlDPHk57KxtA1Dkng7OYgEV++wmq8DpgWyljW4Gs2nvr2s OIyzsBF8P52y+TaovSxQn6+qL+ZGVWOAt2qzxNzCPm9k5Nv3UIblam39MMYTrw0V 6RpxEdNW8kWzREb/R0hxKnkZWh2PhfJzwAEzNZ0QM2Ov2fFkfj0t+WHgnWCXmP5+ UneRECK9z3bygjwDaGIkgTRwTP4O+z8QqiRtePfCPpCGWlysoRjBNlRBN19c+NJY 5dllLKkVde7LW/2pGz6AJZynokjpSxUkeDrKmALvEw/zpW8JWPT5yna8qE1ZHAHI eUvz5Gx3aoji4if7r5fJbg6n6S1CkLOFRxCW1DRGYOCfgkNRmLg3ywsd/4oAZxGL b9qnMgXYLFANRaGjXeWWBxFMJ53mJODO+lKlsmqsgv6qYX/GG7s= =j6gu -----END PGP SIGNATURE----- --Apple-Mail=_DB1E0402-3C01-4D72-A1DD-86D2A5AFC2B2--