Received: by 10.223.176.5 with SMTP id f5csp1092477wra; Wed, 31 Jan 2018 00:59:29 -0800 (PST) X-Google-Smtp-Source: AH8x2275dy7XnHHit4x5pGctKdIbbLRSa3sb7UbyfKLabCjUDEc5rw4r7u0MN6tzycpU84rTetoK X-Received: by 10.98.102.4 with SMTP id a4mr32896907pfc.210.1517389169153; Wed, 31 Jan 2018 00:59:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517389169; cv=none; d=google.com; s=arc-20160816; b=xpUeeEydBFE+OLMsh8NtJEm+1ig8VrbipTZvtqTA2xeeHN/YWSLZks0llfC7NmClU/ tC6WlfkfSnhP3aj896EBMWm2EC4K9eYd9EOr0ctjCULVuWSV55N/1S9gesdmgIcaEO4g RZTue+UTnDpwoSKj3paTmOJD8Ydej94hpoShVlkU5Kcqyeh9rseZgH/CvFuUHABB7tHV WhUJEVHS+Ulg0LMXbYcLUu9RfR4njq476uVH6ySJ22BJz10Ttf51aLF888Cua3mPuYHm HNCfO4aeX6gZn8XlPzZJ94piSgW/XPSUNgQpRyblLzJCoqqM0oAC4G6zU/khtp0r4FuO Z5ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=xCjBSwcWvPY/jZBtPK/QdClJfpsPbVmlpJl6Civa+4U=; b=I4yTAq9FQpPYPclneBrq8czDpguzjQIeCWA7vYUBVR0jafeRLA44EaLSN7UBiq55BK VpB2sN4CJWDMVXUdM15pdPUd7nwg6pcOD/YlkDL0+GVHXIjMh2pHT4aVSyCcBIYTsEhY BhYy1Ny40QVsBTarZpIJmGKrwp7pmpo6Gr8wVUKO7fMBTx70RnTqvb+YcKIC17D8H1SA L1RIXGnRjiS7Z2aoew5v97bgNZ0ejNekinMtSeK64EFTxKy3dVTbrttMw5hj1QwrT+IM tDmln9OJ11rgQMwqJUK70Fhjcxx7kOgCSudag14SQgKxm9u/eqNoVb8SmOxdJYCfeepS cu1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u190si1085779pgc.432.2018.01.31.00.59.13; Wed, 31 Jan 2018 00:59:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532AbeAaIo0 (ORCPT + 99 others); Wed, 31 Jan 2018 03:44:26 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:37670 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbeAaIoZ (ORCPT ); Wed, 31 Jan 2018 03:44:25 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id DB4AC21A51; Wed, 31 Jan 2018 09:44:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id 7947521A44; Wed, 31 Jan 2018 09:43:49 +0100 (CET) Date: Wed, 31 Jan 2018 09:43:49 +0100 From: Maxime Ripard To: Giulio Benetti Cc: Chen-Yu Tsai , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: sunxi-ng: ccu-sun4i-a10: Fix mali changing dclk frequency Message-ID: <20180131084349.du2ijvhh5rxa5vvt@flea.lan> References: <1517354639-92978-1-git-send-email-giulio.benetti@micronovasrl.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2rptceoyv2kyz4nt" Content-Disposition: inline In-Reply-To: <1517354639-92978-1-git-send-email-giulio.benetti@micronovasrl.com> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2rptceoyv2kyz4nt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Jan 31, 2018 at 12:23:59AM +0100, Giulio Benetti wrote: > When mali.ko is inserted, it set default clocks and call all parent > clocks to stay into range, causing pll-video0 to change and > subsequently to change dclk to wrong frequencies. This is what you should fix. > "gpu" clock has lot of parent plls inside driver, but on sun7i > pll8-gpu does not depend on pll-video0, pll-ve, pll-video1. > > It only depends on 24Mhz main clock. I don't really know why you are mentionning that. The GPU clock has all the parents described in the driver. And the parents' parents are irrelevant to this particular issue. > Remove all pll parents from gpu_parents_sun7i except "pll-gpu". However, this is not a proper fix for your issue. What kernel version did you use? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --2rptceoyv2kyz4nt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlpxgcQACgkQ0rTAlCFN r3TUAA/5ASqMeOOzopGp1kTCZGR4LE2GpRttlYa69tnsWRy11WLH3WwsKA23Uq+K u7xtbW5vnDJjbhmcbfWoqvPh4nPciXGIxy0xhMO/PaQ89hGg9ztexP3x7NKtMaNS 71dnKosXKN2lvFHI62BgGcHmZDY2CRTwnbpgSJkPHYuG9fO2ZJxh2y6mN95ZTaSA B6a6DpAdwOnpY1MJUSAoIA2XrfD65KM/f8T0MCL0I163bLP8a/FskuC5Toeb1+c3 oRCHGd5+qnSEdBP75177y/neBjb1+Z4PUR192zl2dd6l6n6grqR/JV+m6etVvT3f DD/gVCWN1SiQeJspiiuhnsD2ACAoYK/NWLf3aGvWIMldlHbpAGPbexd+4wNelr+2 rSeUQ7P5FvgtXC4Ryz0IwYXEXvFaPkXHaJNcqgwoY9RuaMusJPyFp8X1ExX8sNrL mJWygF+Omd01b2CW7luUu/1EnGO5/ioV7h0hYcUWKzr4cXTIldE3kshIeitxEAak 7q+9SMyXaBRFDTcWuOlmHq5u3jwT8rrlBWkKq0UB5U+dyBDLOFSqTeWFv66pTQFU ldiYBku82603uR/B5penAZC5AYjJic+J9lQWfRBEgNqCS4bk32xybjaF1mwkXIFn huRvHrzXW3CPEaA5tSNWr0vvbBxFiPwnO2qjILK77LJ7euUWSMI= =hLEx -----END PGP SIGNATURE----- --2rptceoyv2kyz4nt--