Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 31 Jan 2018 12:32:29 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Yisheng Xie <xieyisheng1@huawei.com>
Cc:     devel@driverdev.osuosl.org, sumit.semwal@linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool
Message-ID: <20180131113229.GA14082@kroah.com>
References: <1517392252-20964-1-git-send-email-xieyisheng1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517392252-20964-1-git-send-email-xieyisheng1@huawei.com>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
> ion_page_pool.c now is used to apply pool APIs for system heap, which do
> not need do any initial at device_initcall.
> 
> Meanwhile, this patch also remove some useless include files.

Please only do one thing per patch, otherwise if one of the different
things you do has a problem, all of the changes have been reverted.

Yeah, it's a pain at times, but that's the way kernel development is,
sorry.

Please break this up into two patches and resend.  I will be glad to
queue them up after the merge window ends when 4.16-rc1 is released.

thanks,

greg k-h