Received: by 10.223.176.5 with SMTP id f5csp1606108wra; Wed, 31 Jan 2018 08:50:18 -0800 (PST) X-Google-Smtp-Source: AH8x2249D5xTM5o510UGI1xpW2jK8qOY+TQGf3+PbmTmSMTomr8AQkfoA7fvAePcqidjlGqZFcdC X-Received: by 10.101.97.139 with SMTP id c11mr24680015pgv.219.1517417418825; Wed, 31 Jan 2018 08:50:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517417418; cv=none; d=google.com; s=arc-20160816; b=d6wrf24+aYw0MNtm2caKmgPxWf1RDysNxUr7E3HT1hQoBRXu3F8UcDmv+M5fvUsbcy g5KjBzWA3GBBd6+c6nfOo0mCab0/4JBVb7jKQP4e3ajRLDEWoIZWM6kADtcmZdAxQ1S8 zh7X3oiGzCi2/pLVJLmo/T1bJ3r99lkJhbVDS4+L8O8rW8aySfsAHWL3NA+1EeGFC2IC 9vYnWaG07K5GZrQa2EnaJoY2PFwSB79U+UV5fCSfAdLKH23x1BFjFT8how31ebFL1YHu 1zajd5ViCuKnVREh9vMd+SI9PpzHZr2VmUCGSkxVOVpf8XlPfZTDZ1deQZwKrS+y4r9Z MVgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=T/lHVkmX60KQ5lGr7s9z0+FRmqMc9N/Y3XFaE74+p6s=; b=HSPZqZe4lzlPSVIQBGO563HYSVn1XH/st3dWEchbz49H/LsYNqnAAm0E9FlVOa/Tci JPEJdPLuKqCkdbBR1maIqF/M2uvQ9yOBgzcyHrgUaA+v9g0tyNsJMFczwLpb3hqE65nf UehWtwPSsPaSNc4SOU5QrrYqcJxkI2mHJBOEsD9taJxDpxft26FAfXVWlisqbBuepqjw GhJVCPflcWVtcrLpbi9yNtuUA0aLMcAcx2wAVsMbaYluZTY7S9ZqXYt3D3yxUYHftSxT PBNvlGHKWZzljtPvUvHQX4GGRrI82T4SPxp+/c8vuaU5TCzg+2ue8TWIDfRAokVhBDKB 9hOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a59-v6si2970353pla.366.2018.01.31.08.50.04; Wed, 31 Jan 2018 08:50:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932339AbeAaQYp (ORCPT + 99 others); Wed, 31 Jan 2018 11:24:45 -0500 Received: from mga05.intel.com ([192.55.52.43]:30662 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932287AbeAaQYn (ORCPT ); Wed, 31 Jan 2018 11:24:43 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2018 08:24:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,440,1511856000"; d="scan'208";a="15902178" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by fmsmga002.fm.intel.com with ESMTP; 31 Jan 2018 08:24:41 -0800 Date: Wed, 31 Jan 2018 09:28:26 -0700 From: Keith Busch To: Oza Pawandeep Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH] PCI/DPC: Fix INT legacy interrupt in dpc_irq Message-ID: <20180131162826.GD27735@localhost.localdomain> References: <1517415535-21850-1-git-send-email-poza@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517415535-21850-1-git-send-email-poza@codeaurora.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 31, 2018 at 09:48:55PM +0530, Oza Pawandeep wrote: > Current dpc driver acknowledge the interrupt in deferred work, which works > okay since LPI are edge triggered. > But when RP does not have MSI support, port service driver falls back to > legacy GIC SPI interrupts, and with current code we do not acknowledge the > interrupt and we get dpc interrupt storm. > This patch acknowledges the interrupt in interrupt handler. > > Signed-off-by: Oza Pawandeep Thanks, looks good to me. Reviewed-by: Keith Busch