Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>
To:     Long Li <longli@microsoft.com>, KY Srinivasan <kys@microsoft.com>,
        "Stephen Hemminger" <sthemmin@microsoft.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a
 channel for I/O requests
Thread-Topic: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a
 channel for I/O requests
Thread-Index: AQHTlWCnc+A/Qzvuo0G+StbT1Ra74KODnBOQgArbV2CAAA1m0A==
Date:   Wed, 31 Jan 2018 21:14:26 +0000
Message-ID: <DM5PR2101MB103010D03B9F6DBF15985814DCFB0@DM5PR2101MB1030.namprd21.prod.outlook.com>
References: <1516831913-26013-1-git-send-email-mikelley@ntdev.microsoft.com>
 <DM5PR2101MB1030445CF939E0C6A3BE3AC7DCE20@DM5PR2101MB1030.namprd21.prod.outlook.com>
 <MWHPR21MB084683CD3983777444DC0F77CEFB0@MWHPR21MB0846.namprd21.prod.outlook.com>
In-Reply-To: <MWHPR21MB084683CD3983777444DC0F77CEFB0@MWHPR21MB0846.namprd21.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-01-31T21:14:25.0478009Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
x-originating-ip: [24.22.167.197]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1015;7:pXtOJ7bw/cAacSCVrJM9uCo2qPKItYnRjeZd6Ol06hYbXadzqhtbEq+ChnQEWv1OOB9+yU9db+qsgC9YB789sCx51ZLByjLA3iMCfFBzJtczs4c9yStUQBbuoRZYkPSvQGrIkNgV4Vp35DRTXZnXHIDnb+RjmLcaQsZp1H4lf6w+IwBPsnRxYMfwKsrwEWIVUGRVLaBJzYDLrXtj3TSNi40f/vanQYCqcZc7KKahgOiJrcYF5SMd6qfETsnlsPEB
x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR;
x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10019020)(396003)(366004)(39380400002)(376002)(346002)(39860400002)(13464003)(199004)(189003)(33656002)(22452003)(2906002)(7696005)(478600001)(6346003)(76176011)(14454004)(99286004)(3280700002)(2900100001)(106356001)(53936002)(53546011)(74316002)(7736002)(305945005)(59450400001)(6506007)(110136005)(1511001)(6246003)(6436002)(8936002)(9686003)(55016002)(2950100002)(81156014)(81166006)(102836004)(72206003)(68736007)(8990500004)(229853002)(10090500001)(25786009)(66066001)(10290500003)(8676002)(3660700001)(2501003)(97736004)(26005)(2201001)(86612001)(316002)(105586002)(3846002)(5660300001)(6116002)(86362001)(5250100002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1015;H:DM5PR2101MB1030.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en;
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 28dbeb6f-4ce0-4d2d-6fd8-08d568ef9c1b
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:DM5PR2101MB1015;
x-ms-traffictypediagnostic: DM5PR2101MB1015:
x-microsoft-antispam-prvs: <DM5PR2101MB1015D1477E4CA2CD7FD3C31DDCFB0@DM5PR2101MB1015.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055)(104084551191319)(146099531331640);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231101)(2400082)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:DM5PR2101MB1015;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1015;
x-forefront-prvs: 056929CBB8
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Michael.H.Kelley@microsoft.com; 
x-microsoft-antispam-message-info: IzfviNVc7lDeGXjai6/rUCgG5rl+rl3G5heSCKCsRPvS/pcTOC9KOntwfp9IbTEaUrkVCB+2gZnikI3K4mox6A==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28dbeb6f-4ce0-4d2d-6fd8-08d568ef9c1b
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2018 21:14:26.6117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1015
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Long Li
> Sent: Wednesday, January 31, 2018 12:23 PM
> To: Michael Kelley (EOSG) <Michael.H.Kelley@microsoft.com>; KY Srinivasan
> <kys@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> martin.petersen@oracle.com; devel@linuxdriverproject.org; linux-kernel@vg=
er.kernel.org;
> linux-scsi@vger.kernel.org; James E . J . Bottomley <jejb@linux.vnet.ibm.=
com>
> Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a =
channel for I/O
> requests
>=20
> > Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking =
a
> > channel for I/O requests
> >
> > Updated/corrected two email addresses ...
> >
> > > -----Original Message-----
> > > From: Michael Kelley (EOSG)
> > > Sent: Wednesday, January 24, 2018 2:14 PM
> > > To: KY Srinivasan <kys@microsoft.com>; Stephen Hemminger
> > > <sthemmin@microsoft.com>; martin.petersen@oracle.com;
> > > longi@microsoft.com; JBottomley@odin.com;
> > > devel@linuxdriverproject.org; linux-kernel@vger.kernel.org;
> > > linux-scsi@vger.kernel.org
> > > Cc: Michael Kelley (EOSG) <Michael.H.Kelley@microsoft.com>
> > > Subject: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a
> > > channel for I/O requests
> > >
> > > Update the algorithm in storvsc_do_io to look for a channel starting
> > > with the current CPU + 1 and wrap around (within the current NUMA
> > > node). This spreads VMbus interrupts more evenly across CPUs. Previou=
s
> > > code always started with first CPU in the current NUMA node, skewing
> > > the interrupt load to that CPU.
> > >
> > > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
> > > ---
> > >  drivers/scsi/storvsc_drv.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > > index e07907d..f3264c4 100644
> > > --- a/drivers/scsi/storvsc_drv.c
> > > +++ b/drivers/scsi/storvsc_drv.c
> > > @@ -1310,7 +1310,8 @@ static int storvsc_do_io(struct hv_device *devi=
ce,
> > >  			 */
> > >  			cpumask_and(&alloced_mask, &stor_device-
> > >alloced_cpus,
> > >
> > cpumask_of_node(cpu_to_node(q_num)));
> > > -			for_each_cpu(tgt_cpu, &alloced_mask) {
> > > +			for_each_cpu_wrap(tgt_cpu, &alloced_mask,
> > > +					outgoing_channel->target_cpu + 1) {
>=20
> Does it work when target_cpu is the last CPU on the system?
>=20
> Otherwise, looking good.

Yes, it works.  for_each_cpu_wrap() correctly wraps in the case where
the 3rd parameter ('start') is one past the end of the mask.  Arguably,
we shouldn't rely on that, and should do the wrap to 0 before calling
for_each_cpu_wrap().

>=20
> > >  				if (tgt_cpu !=3D outgoing_channel->target_cpu)
> > {
> > >  					outgoing_channel =3D
> > >  					stor_device->stor_chns[tgt_cpu];
> > > --
> > > 1.8.3.1