Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 31 Jan 2018 13:55:09 -0800
From:   Matthew Wilcox <willy@infradead.org>
To:     Goffredo Baroncelli <kreijack@libero.it>
Cc:     Jeff Layton <jlayton@kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH] Rename make inode_cmp_iversion{+raw} to
 inode_eq_iversion{+raw}
Message-ID: <20180131215509.GD28275@bombadil.infradead.org>
References: <20180131204309.32474-1-kreijack@libero.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180131204309.32474-1-kreijack@libero.it>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 31, 2018 at 09:43:09PM +0100, Goffredo Baroncelli wrote:
> The function inode_cmp_iversion{+raw} is counter-intuitive, because it
> returns true when the counters are different and false when these are equal.
> 
> Rename it to inode_eq_iversion{+raw}, which will returns true when
> the counters are equal and false otherwise.

A lot of places use !inode_eq_iversion().  I think we should have both
inode_eq_iversion() and inode_ne_iversion().

Also, we have 'inode' in the name, why keep the 'i'?  inode_eq_version()
and inode_ne_version() are shorter.  We could even go so far as
iversion_eq() and iversion_ne() if keeping 'iversion' in the string
is important.