Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool
To:     Greg KH <gregkh@linuxfoundation.org>
References: <1517392252-20964-1-git-send-email-xieyisheng1@huawei.com>
 <20180131113229.GA14082@kroah.com>
CC:     <devel@driverdev.osuosl.org>, <sumit.semwal@linaro.org>,
        <linux-kernel@vger.kernel.org>
From:   Yisheng Xie <xieyisheng1@huawei.com>
Message-ID: <865ec1d8-a37b-2cbc-4397-3a787848c4ec@huawei.com>
Date:   Thu, 1 Feb 2018 08:57:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <20180131113229.GA14082@kroah.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greg,

On 2018/1/31 19:32, Greg KH wrote:
> On Wed, Jan 31, 2018 at 05:50:52PM +0800, Yisheng Xie wrote:
>> ion_page_pool.c now is used to apply pool APIs for system heap, which do
>> not need do any initial at device_initcall.
>>
>> Meanwhile, this patch also remove some useless include files.
> 
> Please only do one thing per patch, otherwise if one of the different
> things you do has a problem, all of the changes have been reverted.
> 
> Yeah, it's a pain at times, but that's the way kernel development is,
> sorry.

Sorry, I should always remember this.

> 
> Please break this up into two patches and resend.  I will be glad to
> queue them up after the merge window ends when 4.16-rc1 is released.

I will sent the next version ASAP.

Thanks
Yisheng
> 
> thanks,
> 
> greg k-h
> 
> .
>