Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4] vfio/type1: Adopt fast IOTLB flush interface when
 unmap IOVAs
To:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     alex.williamson@redhat.com, joro@8bytes.org, jroedel@suse.de
References: <1517391946-7830-1-git-send-email-suravee.suthikulpanit@amd.com>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Message-ID: <0fd4610a-c3ec-90f9-2d87-a7c2dd78193d@amd.com>
Date:   Thu, 1 Feb 2018 12:11:19 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <1517391946-7830-1-git-send-email-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 05:11:25.5222 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bfbda5b0-c54a-4738-fa6a-08d569323f5b
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1738
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alex,

On 1/31/18 4:45 PM, Suravee Suthikulpanit wrote:
> Currently, VFIO IOMMU type1 unmaps IOVA pages synchronously, which requires
> IOTLB flush for every IOVA unmap. This results in a large number of IOTLB
> flushes during initialization of pass-through devices.
> 
> This can be avoided using the asynchronous (fast) IOTLB flush interface.
> 
> Cc: Alex Williamson<alex.williamson@redhat.com>
> Cc: Joerg Roedel<joro@8bytes.org>
> Signed-off-by: Suravee Suthikulpanit<suravee.suthikulpanit@amd.com>
> ---
> 
> Changes from v3 (https://lkml.org/lkml/2018/1/21/244)
>   * Refactor the code to unmap_unpin_fast() and unmap_unpin_slow()
>     to improve code readability.
>   * Fix logic in vfio_unmap_unpin() to fallback to unmap_unpin_slow()
>     only for the failing iova unmapping, and continue the next unmapping
>     with the unmap_unpin_fast(). (per Alex)
>   * Fix error handling in case of failing to do fast unmapping to warn
>     only once.
>   * Remove reference to GPU in the commit message.

Please ignore v4. I found an issue in error handling logic. Also, I need to change
the return value back to size_t (as this was in a discussed in a separate thread).

Sorry for confusion. I'll clean up and send out v5.

Thanks,
Suravee