Received: by 10.223.176.5 with SMTP id f5csp2516751wra; Thu, 1 Feb 2018 01:39:58 -0800 (PST) X-Google-Smtp-Source: AH8x225x0HoeNSV5x4kyD5kS1I0yhl2VGHaVSXT1CTrR7hpl45xkCj47mXX5Fgy/FWHHLwdN3G2T X-Received: by 10.98.89.198 with SMTP id k67mr36523531pfj.110.1517477998488; Thu, 01 Feb 2018 01:39:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517477998; cv=none; d=google.com; s=arc-20160816; b=KbZvgtjeEzuIAocOH1uJF+9Zg0UfoYxMyUMDrJgPWv3Fgt+q9Z4Dp80VFKsEXIXpDj g4fTCQi1p/Ezw6zpq9+Fj2P7/9bw7SDP8FvhWzsTVCb2OB7/tuLztRHLi/hX4cCz1Bcm ZRA+IwNZjZ2FWzGQVx1Ct3waqXWaCB9gdgMxOhn5y3htD4yzPlg7872hy1ds65qec5X7 0UtmuPDK/+bU72hlVty79X0wcH42cXDdZwzCZueJ6giHNx0OCMLAvK4A6r0vrQ97ozgA plTumpEJqK/FJ4bLv3JgoyADZAMNe9XCiuhTX58pNE96Lhw/TihKRhydyVzJ4Vdnlm0m +BBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=fiD1j8jk560OyK8B+sVgh+0oQVRzBj23GTs8GQRfHjk=; b=Q9cPUObN7kwLP6OX8YZ3mSldzgKRTgB6XxDB/nJ/NT0c/ILW1ue4txuEhdIj53bPjY z445mOOoUPfmkViNH59hzEktn3eHeBHvYuqzlKyBhubcTXE2JdeKN9tW0xUMO7i69wwD e22wuwS9DIoSQesmoDT+Q+Tfq7ffz/hZY7jN3hzdTvW9aZKTq0leutCI89X6CeGo959N VfqRyvqCkA2SPXrM0xch2NU53OfUaUuLF01lTtjjY0qM0HKLP7S9+jZ2IlPMIaXkZJ9a 5RPjqbTurRW8lQhn0Qp1bcQuP8DCZuUz0IhDSvMCL81X4PW1lLOFcjD4w4bQhhyAjPg1 S4yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=1Iqsb8bG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si2997231pgi.522.2018.02.01.01.39.43; Thu, 01 Feb 2018 01:39:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=1Iqsb8bG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751936AbeBAJjC (ORCPT + 99 others); Thu, 1 Feb 2018 04:39:02 -0500 Received: from merlin.infradead.org ([205.233.59.134]:52238 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbeBAJjB (ORCPT ); Thu, 1 Feb 2018 04:39:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fiD1j8jk560OyK8B+sVgh+0oQVRzBj23GTs8GQRfHjk=; b=1Iqsb8bGVeBlgCqivuLa1upAI 0UDaFEafOd4AZCNTB5ResL/blqAHvNYw1GM3OTI5Ah7QkGMyuueiQfT4bFt5t9U7c7zzeD7HRY+lp vX572f7MQQ6d5RahXfXTb71UVWLYyMIFoD0P2kZNdrx798fBN5vHxFHs6Wc3LEGPw7L/67kL59E7f UL7jdemxCpnkuKGUaQ6iEREn6LMb5aoEt3xgosVYRwLhicvUxvMS2LFpE+5/gkwdD/LsvPor2pXdj +FyhIXIACJ7MdbCrHweE0n9YGT0QK4dMwddVSP0HT4IiMKXop/3mTr4OUr8rBe+t0icEUuAs/7T4W 4lnymo0FA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.89 #1 (Red Hat Linux)) id 1ehBKT-0005yh-7p; Thu, 01 Feb 2018 09:38:49 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C1E0D2029F9FA; Thu, 1 Feb 2018 10:38:47 +0100 (CET) Date: Thu, 1 Feb 2018 10:38:47 +0100 From: Peter Zijlstra To: Nadav Amit Cc: Dave Hansen , the arch/x86 maintainers , Andy Lutomirski , "H. Peter Anvin" , LKML , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH] x86: Align TLB invalidation info Message-ID: <20180201093847.GZ2269@hirez.programming.kicks-ass.net> References: <20180131201118.1694-1-namit@vmware.com> <8bb352bc-4e1f-4e87-80e3-a8e65d618d2a@linux.intel.com> <0E65629C-0D7D-4602-A43D-B18E62F330A6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 31, 2018 at 09:38:46PM -0800, Nadav Amit wrote: > I used ftrace to measure the execution time of flush_tlb_func_remote() on a > 2-socket Haswell machine, using a microbenchmark I wrote for some research > project. However cool ftrace is, it is _really_ bad for such uses. The cost of using ftrace is many many time higher than any change you could affect by this. A microbench and/or perf is what you should use for this.