Received: by 10.223.176.5 with SMTP id f5csp2695304wra; Thu, 1 Feb 2018 04:44:25 -0800 (PST) X-Google-Smtp-Source: AH8x224Fr6homzhAxdHs5joursor7V6djogwdSzDx1F01K4eKnV9zjVdYP/+0q7sof3HPmeC+kBX X-Received: by 10.101.80.69 with SMTP id k5mr18137606pgo.449.1517489065500; Thu, 01 Feb 2018 04:44:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517489065; cv=none; d=google.com; s=arc-20160816; b=L1yqgh0YDr2GivkwxNfWGhs0VEfHG2HAUWTUcCiHNj6+77ZPF4U8Y1UN9lEhWaBW2W TGTeHLd4cpYkylMVO8NsxhlWMbuCJ5prZDvFCf/Hf5hsbUygek1HKL5WdTW3Z58XmVBU OBYii5QCpW4aEuDca5s9gvSiH9NZSdJ+z9CMzpqmcfHK3EWVVbqcUSxys57Dc84YqauL f8n1nZaWmb9S5qoIQoY7dXcAoR+wUQnZjnAiow0XVMEtvXIzgS8DP+beD+f4yObQBhMR Td6CKv4NYGytQSl8aYn1MPsgQf6oepFnIMBRGKqD7olKwFkKuNHCDGhRIQcxGa+q2SPh dyOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=elJyXFWA5vra6WNKHTjnWd1kZPss56mL/coMvRb8/Bk=; b=zJPS5VqRX1C8qYJjQRhht9pXapboSVGs4QxO+LuxHGwd+Fzjoap/Eqn1QhHKTZQh9n ivF3ian78+q8slMZ6qhlb2ZpuldZsNKaAxwPltq0+VBImcqDOLTxd7T4UVYmjjNfPfaK 6634O2tZfv8Us9RJQJ/+XAPKdyGwT5AMItbD8hgcpt0pFkxWdNc+AAlaituG+XpKQJaY fuWWT0MHFGGSkXhPdvBNqJwqGz7MU656ePufKQ9Ow+mnLC1Y3RP1y/P7vxjcSfP5DLFg ErCwxkA59VR3cmLfP64kbUUSf7/rRGUz4rw0PqYpxMJ/9tl6iTL2JQ1GfYdZMg4LUP+K KlxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u27si1654000pfk.385.2018.02.01.04.44.10; Thu, 01 Feb 2018 04:44:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbeBAMnn (ORCPT + 99 others); Thu, 1 Feb 2018 07:43:43 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:5163 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752538AbeBAMni (ORCPT ); Thu, 1 Feb 2018 07:43:38 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 25683FDEA0236; Thu, 1 Feb 2018 20:43:22 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.361.1; Thu, 1 Feb 2018 20:43:14 +0800 From: Yisheng Xie To: CC: , , , , Yisheng Xie Subject: [PATCH 2/2] staging: android: ion: Remove lable debugfs_done Date: Thu, 1 Feb 2018 20:34:07 +0800 Message-ID: <1517488447-41252-2-git-send-email-xieyisheng1@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1517488447-41252-1-git-send-email-xieyisheng1@huawei.com> References: <1517488447-41252-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When failed to create debug_root, we will go on initail other part of ion, so we can just info this message to user and do not need a lable to jump. Signed-off-by: Yisheng Xie --- drivers/staging/android/ion/ion.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 3e41644..70a70f5 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -601,12 +601,9 @@ static int ion_device_create(void) } idev->debug_root = debugfs_create_dir("ion", NULL); - if (!idev->debug_root) { + if (!idev->debug_root) pr_err("ion: failed to create debugfs root directory.\n"); - goto debugfs_done; - } -debugfs_done: idev->buffers = RB_ROOT; mutex_init(&idev->buffer_lock); init_rwsem(&idev->lock); -- 1.7.12.4