Received: by 10.223.176.5 with SMTP id f5csp2867938wra; Thu, 1 Feb 2018 07:17:51 -0800 (PST) X-Google-Smtp-Source: AH8x224Y0Tk5a8pcHmyJg8RjxnrLYD5dSQ/Y3EAzvOuSuuhbUXD08NhZo9kpbFpecPHwidVbsXTN X-Received: by 10.101.80.130 with SMTP id r2mr28811398pgp.107.1517498271828; Thu, 01 Feb 2018 07:17:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517498271; cv=none; d=google.com; s=arc-20160816; b=snuzyjkospp+Vw4MykdpfIbBC+I+HxKwY5j7LenQWtEPsTRtXy6Iewa3wdcnXsUv/7 WzsGooaJ7s1yJ4BTeSxMmxUDg/cPeUOOTN0nblsXJTQm/6w1MG/7rVVYAc9J6tFlaG6L vHyQsN7K/cZSGnDzsq1vft2+UW6ilpiqwC92fK+oQkxGc5Ex8D+yfO0afxvM4a97kFBz VEYUOHSKV66eEQ5tcWT6nNSN/tUxTqaUIdEvh+e/E//OEOrH0+OzWLvCtXHvpymTJ+9i oTkq231asQM0iRjVuFJz+iSRtI/Ee6gN71pu4POTA7pGjzn0ix43hliCTqDBfQb7q0+G Nb3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=ua+t3Dtz+xKTTAY0AFs0f72yz69/CVRYivotdIfT404=; b=gjfK6tVp6Jmm6K5H9Q/ZI9G3Z4MeNNsTYMz+eBlEpTLyZkOla+Y2X2FVfdtbMMABit JT1di77vEixkWYkGMO8l2StiO+W2Oz9XCVa7sed5+NAMrWgxhHB5mDtS4KYs5vr66FKl igTKAQo1dNN8EW86lXr2RuV+/PFjEKL7GaPHJG719Em7yl9dvmYL4qwEjNaw0cvgNhBe 5PUmGtzJCTf6DMWublcF9agyR8YOKVLJio99gpexwh01bcTksEPhFax7EBHGa+tbNptn FNapR/D3KZJl/k4w+qbX+o8lh5Z3cl9XRz3ve4ieyObBEUQEet7umuwr2bVkgkJJoT/S qd4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o17si1663555pge.371.2018.02.01.07.17.36; Thu, 01 Feb 2018 07:17:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbeBAPRC (ORCPT + 99 others); Thu, 1 Feb 2018 10:17:02 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:44620 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbeBAPQ4 (ORCPT ); Thu, 1 Feb 2018 10:16:56 -0500 Received: from localhost (pool-173-77-163-229.nycmny.fios.verizon.net [173.77.163.229]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 26E89109669C6; Thu, 1 Feb 2018 07:16:56 -0800 (PST) Date: Thu, 01 Feb 2018 10:16:55 -0500 (EST) Message-Id: <20180201.101655.1316424669256047119.davem@davemloft.net> To: guro@fb.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, edumazet@google.com, hannes@cmpxchg.org, tj@kernel.org Subject: Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc() From: David Miller In-Reply-To: <20180131215401.GA8956@castle> References: <20180125001911.15597-1-guro@fb.com> <20180125.120302.1117695034222616751.davem@davemloft.net> <20180131215401.GA8956@castle> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 01 Feb 2018 07:16:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Roman Gushchin Date: Wed, 31 Jan 2018 21:54:08 +0000 > So I really start thinking that reverting 9f1c2674b328 > ("net: memcontrol: defer call to mem_cgroup_sk_alloc()") > and fixing the original issue differently might be easier > and a proper way to go. Does it makes sense? You'll need to work that out with Eric Dumazet who added the change in question which you think we should revert.