Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of nokia.com designates
 131.228.2.241 as permitted sender) receiver=protection.outlook.com;
 client-ip=131.228.2.241; helo=mailrelay.int.nokia.com;
Subject: Re: [PATCH] i2c-mux-reg: Delete an error message for a failed memory
 allocation in i2c_mux_reg_probe_dt()
To:     SF Markus Elfring <elfring@users.sourceforge.net>,
        <linux-i2c@vger.kernel.org>, Peter Rosin <peda@axentia.se>,
        Wolfram Sang <wsa@the-dreams.de>,
        York Sun <yorksun@freescale.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>
References: <224a8918-f882-9ab1-218c-83df93d4cb2f@users.sourceforge.net>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
Message-ID: <7b0fcef4-d0b2-e12d-c369-ac6704e16a09@nokia.com>
Date:   Thu, 1 Feb 2018 17:46:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <224a8918-f882-9ab1-218c-83df93d4cb2f@users.sourceforge.net>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 16:47:00.3163
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a5e578d7-5f5d-44d4-ee57-08d569936a35
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0;Ip=[131.228.2.241];Helo=[mailrelay.int.nokia.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR07MB0756
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/02/18 17:24, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

> ---
>  drivers/i2c/muxes/i2c-mux-reg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
> index c948e5a4cb04..f624ed64a47b 100644
> --- a/drivers/i2c/muxes/i2c-mux-reg.c
> +++ b/drivers/i2c/muxes/i2c-mux-reg.c
> @@ -127,10 +127,8 @@ static int i2c_mux_reg_probe_dt(struct regmux *mux,
>  	values = devm_kzalloc(&pdev->dev,
>  			      sizeof(*mux->data.values) * mux->data.n_values,
>  			      GFP_KERNEL);
> -	if (!values) {
> -		dev_err(&pdev->dev, "Cannot allocate values array");
> +	if (!values)
>  		return -ENOMEM;
> -	}
>  
>  	for_each_child_of_node(np, child) {
>  		of_property_read_u32(child, "reg", values + i);

-- 
Best regards,
Alexander Sverdlin.