Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 1 Feb 2018 18:04:47 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Mark Salyzyn <salyzyn@android.com>
Cc:     Paul Moore <paul@paul-moore.com>, linux-kernel@vger.kernel.org,
        Paul Moore <paul@linuxfoundation.org>,
        Eric Dumazet <edumazet@google.com>,
        Stephen Smalley <sds@tycho.nsa.gov>, selinux@tycho.nsa.gov,
        linux-security-module@vger.kernel.org,
        Eric Paris <eparis@parisplace.org>,
        "Serge E . Hallyn" <serge@hallyn.com>,
        stable <stable@vger.kernel.org>, James Morris <jmorris@namei.org>
Subject: Re: [PATCH v2] general protection fault in sock_has_perm
Message-ID: <20180201170447.GE12838@kroah.com>
References: <20180201153708.63506-1-salyzyn@android.com>
 <CAHC9VhSdR9UGpYhod5xhA76EbSKHzTW5rEiYWMovC0t6gfowig@mail.gmail.com>
 <5fb5622d-e58b-c174-3d5c-bfe55569b88e@android.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5fb5622d-e58b-c174-3d5c-bfe55569b88e@android.com>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 01, 2018 at 08:20:13AM -0800, Mark Salyzyn wrote:
> On 02/01/2018 08:00 AM, Paul Moore wrote:
> > On Thu, Feb 1, 2018 at 10:37 AM, Mark Salyzyn <salyzyn@android.com> wrote:
> > > In the absence of commit a4298e4522d6 ("net: add SOCK_RCU_FREE socket
> > > flag") and all the associated infrastructure changes to take advantage
> > > of a RCU grace period before freeing, there is a heightened
> > > possibility that a security check is performed while an ill-timed
> > > setsockopt call races in from user space.  It then is prudent to null
> > > check sk_security, and if the case, reject the permissions.
> > > 
> > > . . .
> > > ---[ end trace 7b5aaf788fef6174 ]---
> > > 
> > > Signed-off-by: Mark Salyzyn <salyzyn@android.com>
> > > Signed-off-by: Paul Moore <paul@linuxfoundation.org>
> > No, in the previous thread I gave my ack, not my sign-off; please be
> > more careful in the future.  It may seem silly, especially in this
> > particular case, but it is an important distinction when things like
> > the DCO are concerned.
> > 
> > Anyway, here is my ack again.
> > 
> > Acked-by: Paul Moore <paul@paul-moore.com>
> > 
> Ok, both Greg KH and yours should be considered Acked-By. Been overstepping
> this boundary for _years_. AFAIK Signed-off-by is still pending from Stephen
> Smalley <sds@tycho.nsa.gov> before this can roll in.

An ack is all I need here, or I can just rely on Paul's :)
I'll edit up Paul's when I apply this.

thanks,

greg k-h