Received: by 10.223.176.5 with SMTP id f5csp3146592wra; Thu, 1 Feb 2018 11:31:00 -0800 (PST) X-Google-Smtp-Source: AH8x226lEHWeO1LPci+Y6D/VHpuU7rtjOPJ795LgSILMhv4Z4EqpmHrqfPlDPUqOXMkSQyRViiWW X-Received: by 10.99.143.2 with SMTP id n2mr31244258pgd.14.1517513459896; Thu, 01 Feb 2018 11:30:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517513459; cv=none; d=google.com; s=arc-20160816; b=RofxHTkljzW+tcrnazBHifwV1M5yMDxpW8e8v8u+JpHt4kkFw/vGCRNhOP91P4/McS e3cVo+E+Di0ewAHDi4xqNCcz3HABrmrnP9EhzkWytuGVqFha/8hID7rAME/yrKZXaf/l EqqmMjbX2lZUeIH85ZcNjZWModRZsbGHiKV43A/pOULXLVJlgvUsSc/TtVDQc/WrxjhR YCp40CoKtQZmx0dzHCGaiG+6JzJBZITD2t4wMm2fthXlFbZJkYeK/iUP/hpO1fpxbtUq xCRd7MPBfNfRnpbTkmpjBSoOQAeXJJEz2Nawe7qpA0QMuMwcVJcsv5mdsmkqHKD8I0ns Uzgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=wHWrVxcZmW/bHhODvq3hQK2nyWmTFQLd/EwJus8JrXI=; b=PI/IiaUN6jLGym06wBqAM/06Tm9f/tFFurHPvkznEBzYuVNz7zpfiImV3lgv3oz9s+ wOlrc9qHYECX/Li0MGoSiM+lTtu0uY5LNEnYuqti4gN5ZvP4TFWo3h9t2TGF/KYXPONH HHtaSN/d4Mkv3RIYuQ8bj7Awiof1GDmRJuIboKhM4z0tWaLVwXmLhl976q0aWD1Q5KO3 6vKuFmybzUrVofQUmeZ/xS3MRGvHwe7USqWkMg9bB9CIAgwjdkMg6mOj6zHp0hgCd5mu R9u8MGRd83tYJhpZg8DXNhGtdYK4YtJ/WJzAcKyfAsJNrGWwTYreAQB/VL/5lN4iCbHJ m81w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si173855pgv.91.2018.02.01.11.30.44; Thu, 01 Feb 2018 11:30:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbeBAT3C (ORCPT + 99 others); Thu, 1 Feb 2018 14:29:02 -0500 Received: from ex13-edg-ou-002.vmware.com ([208.91.0.190]:12867 "EHLO EX13-EDG-OU-002.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753368AbeBAT2x (ORCPT ); Thu, 1 Feb 2018 14:28:53 -0500 Received: from sc9-mailhost3.vmware.com (10.113.161.73) by EX13-EDG-OU-002.vmware.com (10.113.208.156) with Microsoft SMTP Server id 15.0.1156.6; Thu, 1 Feb 2018 11:28:48 -0800 Received: from shri-linux.eng.vmware.com (shri-linux.eng.vmware.com [10.33.72.16]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id 171774089A; Thu, 1 Feb 2018 11:28:53 -0800 (PST) Date: Thu, 1 Feb 2018 11:28:52 -0800 From: Shrikrishna Khare To: Colin King CC: Shrikrishna Khare , , , , Subject: Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq' In-Reply-To: <20180201172921.22770-1-colin.king@canonical.com> Message-ID: References: <20180201172921.22770-1-colin.king@canonical.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Received-SPF: None (EX13-EDG-OU-002.vmware.com: skhare@shri-linux.eng.vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Feb 2018, Colin King wrote: > From: Colin Ian King > > Pointer rq is being initialized but this value is never read, it > is being updated inside a for-loop. Remove the initialization and > move it into the scope of the for-loop. > > Cleans up clang warning: > drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored > to 'rq' during its initialization is never read > > Signed-off-by: Colin Ian King Acked-by: Shrikrishna Khare