Received: by 10.223.176.5 with SMTP id f5csp3170572wra; Thu, 1 Feb 2018 11:56:35 -0800 (PST) X-Google-Smtp-Source: AH8x224vAlgv050Iq4Y5wt8Dw6dxxTItnsxSWUifbj5IvLBrXxvexn8jvWUwHiA9yXlcV0AFB8XH X-Received: by 10.99.159.2 with SMTP id g2mr24942936pge.156.1517514994868; Thu, 01 Feb 2018 11:56:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517514994; cv=none; d=google.com; s=arc-20160816; b=dAlF4ezcRu18TL0xMYU2Eyy0YTcfQRru9nAjWEdnDfk7900fXLnvjMtgGJM4CIl3mj UniZ06UAkCQrthttFPn4IBoFX4Somlg4VteffWNg2TTD760I8LfI2PG+r0Qm36574iK8 vqPoHzLzf/0q1VRo1qJQh8VTpAK1BkKcyN53X7Qn9lWbXB0C1av1JPHZKvKSFcgr4Ro6 05Sz2cA1ukWrYOqeg4n9IXU5FyGgj7OeAjM/QZesvLUqgMdZ2oGih4i/pOhpgPu7N+SY yynGbxqU4m7W8u6JHAy9q89M/yXV8cxKk6nMTX5D1PXawQW7SnaK9O8mv/Nd27FIlUK8 LBjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=1sqWkWkyduqdK0hFbpn5jIaeLqw5yHmPmdKqrs0rHDU=; b=OWWAbO6ZZyCSLdXAxbpCgzC0pXBN4kjY40vlRUKmZDhq5ye89Gdm0ahTlPf++7GnKU PVF2w0G5ZZqhB9z8WSBl17iAnKeY4cCvraca6Fg70+PbS5PQx3/koaPFUpxh9DN+h+6d pW2iBlFDyVvAkpyEDeXT49H9PEFhPl0as4ehoxG0MqZZtS27bKx84jVhcFncA1HlIr5m B+Hjt8C0aObFeShJzXWS7glOXiX/VLChskFDnGe+Z33WiLDTOFdZHnFt0+EeVcyJmf4k PbHPVeOVCASNVScxDHyl9lWJtGVkDvIj0PvV866li4Bmye3eAsNVuwtChZTpnkQV03El AcgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a33-v6si233450pli.154.2018.02.01.11.56.20; Thu, 01 Feb 2018 11:56:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754919AbeBATzZ (ORCPT + 99 others); Thu, 1 Feb 2018 14:55:25 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50028 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754594AbeBATy6 (ORCPT ); Thu, 1 Feb 2018 14:54:58 -0500 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B91361162AEA0; Thu, 1 Feb 2018 11:54:57 -0800 (PST) Date: Thu, 01 Feb 2018 14:54:56 -0500 (EST) Message-Id: <20180201.145456.251900509374837057.davem@davemloft.net> To: colin.king@canonical.com Cc: skhare@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq' From: David Miller In-Reply-To: <20180201172921.22770-1-colin.king@canonical.com> References: <20180201172921.22770-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 01 Feb 2018 11:54:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 1 Feb 2018 17:29:21 +0000 > From: Colin Ian King > > Pointer rq is being initialized but this value is never read, it > is being updated inside a for-loop. Remove the initialization and > move it into the scope of the for-loop. > > Cleans up clang warning: > drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored > to 'rq' during its initialization is never read > > Signed-off-by: Colin Ian King Applied.