Received: by 10.223.176.5 with SMTP id f5csp113917wra; Thu, 1 Feb 2018 16:38:02 -0800 (PST) X-Google-Smtp-Source: AH8x224GESp+rh4R0/LivSncOTjscLACJHa6wMa3PkFY7X+yiOYpeqL2+a+vxVI9OvcCghjTxmb5 X-Received: by 10.98.55.3 with SMTP id e3mr39180964pfa.119.1517531882361; Thu, 01 Feb 2018 16:38:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517531882; cv=none; d=google.com; s=arc-20160816; b=uaLHMPl/++dWlwkP4JCC1Q1EFkMjzUnVLBiGCFSDsDxltBQPH8ocV/hkYU3pzciB6e IlU6NoHgC4XZvRaPZqBY+O7hyvyj9pk9BR5VDvU59yA1KoPYRKGSar2jpJZJlxT43SNI 7D7abiG7MgFH3e03HDythlZPfLfGASqMaoUGUbZmsBItwotqnCdvss2okysJmcRrzwcm ADZG26eDIrfnt/v8XEC1rsu3t4R/dnWdJ++VeHRwwFwdC5OAs7RyC5niIZXl3TPBXQap lpO+MFORrDfifuaEJ85K2H91KZvl5BJyA25JnYmmKN7DH940eMUEXY1h/Td0fSDAaPLF yd7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Gjyi/E06TUaaR6sZ725jnqPEMGJ7cjIAfvh5twhzi4A=; b=QzAU0lsaBnFHfoT1vPkA7weD/hoGm7GAPsfQy9fyrNFMzPejm0cMu1DtFycgRvmKq9 Vk4nHpICWbSAFtV48HAir0Spe842lorAkv7zPBPjatCAZcDVBAIzoe21mM0PyX/bWDvn jWylNCzl8HPrO4hc1Qd67+y3B6L2n5LeD3fTHLHu7V+NZDQwtlSH5U0OyGQqd+VcXO3v GsI1zCmdebdiXY4XeMSdhbVpVbunXv8B8tPS1JcfPejHCTvRmg3qr3V5MZsv+GBXreRJ p0ZrNXVOlfLah1q+DDayf/URb0VU6ClfyRJAceF1XeQ/RnOROnnHOXQRMu+JGWwwn5HS LQ7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=itw5fc/S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e90-v6si589225plb.749.2018.02.01.16.37.47; Thu, 01 Feb 2018 16:38:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=itw5fc/S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751666AbeBBAgc (ORCPT + 99 others); Thu, 1 Feb 2018 19:36:32 -0500 Received: from mail-it0-f46.google.com ([209.85.214.46]:34899 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbeBBAg0 (ORCPT ); Thu, 1 Feb 2018 19:36:26 -0500 Received: by mail-it0-f46.google.com with SMTP id e1so6008591ita.0; Thu, 01 Feb 2018 16:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Gjyi/E06TUaaR6sZ725jnqPEMGJ7cjIAfvh5twhzi4A=; b=itw5fc/SgGDQ+7+t51DrR2bJGN8D/r75eF4loz3Qv8EgYFOsJIwBk7FHlexsweTFhC kwP05lw386/h+SQL0z+GK7bTm02qllWtb9XT3S96hN2RX/7lyhzSiqoSRCADOT5HiX0d Bi/1S/z0I9sMjX0+XYYuXq1RQzR1UHHW8B4u9QNzAovJ+mOR32Lfs7BO7splZEfH3/U7 Ffc2wfKlgVhbStENZ6I9v93zJfvhkkpfQrdqwkcVb8ogEHZRQw8P9EF4V8tmppiwP8vn 5VH8I2mhhLSC2NW+v1OMP8GDxNnfHDbwu+bZVspcky8z6HrcuH/KozqQ/hPPuNR7t82T K0qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Gjyi/E06TUaaR6sZ725jnqPEMGJ7cjIAfvh5twhzi4A=; b=U8LjTzbDrTbUIUU3Lrg4AJFLry7GXUSuamoxrrKNZYabXFKXasKIp2icCxFw0kvzGq d6CQjhSdK/mKkh4NQbLdBY/+06CfS7fQlEJkpaF592GYDqf6Tt9Oc6zxcwnBL/C8SNqZ pMiCxlWcG0tQiEfnS0n0uf1vUbCIhcMIFfZ8nlb4qdUFNyg546rKVslCZ+gU7GdL5lgt hTDmxz5bo/DGHxxW2nJQbkmtoeujb6GSLi3RKk9gIZDalpxrSAjJHnGrsLfe9qrgr8nL u8638+B90l1E2uXMnqVRcUcWZ37NiHhfnCTi8ySbump/A4Dyc3FTgHZDFiZ29Pbx0Pgo SeGg== X-Gm-Message-State: AKwxytegz/fmKn6d+rMBTGWrnHM2v3CUVtr4/l7BawHNVNTCbYqRNWbS 962J+TLmkGn3HaNnGL1F96uCxiqz5cNLxuqrm7cByA== X-Received: by 10.36.131.194 with SMTP id d185mr25007953ite.31.1517531785718; Thu, 01 Feb 2018 16:36:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.17.69 with HTTP; Thu, 1 Feb 2018 16:36:05 -0800 (PST) In-Reply-To: References: <20180201124019.11693-1-jgross@suse.com> From: Chris Patterson Date: Thu, 1 Feb 2018 19:36:05 -0500 Message-ID: Subject: Re: [Xen-devel] [PATCH v2] x86/xen: init %gs very early to avoid page faults with stack protector To: Boris Ostrovsky Cc: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Works great, tested it and it fixes booting Linux v4.15 kernel for me :) Cheers! On Thu, Feb 1, 2018 at 3:17 PM, Boris Ostrovsky wrote: > On 02/01/2018 07:40 AM, Juergen Gross wrote: >> When running as Xen pv guest %gs is initialized some time after >> C code is started. Depending on stack protector usage this might be >> too late, resulting in page faults. >> >> So setup %gs and MSR_GS_BASE in assembly code already. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Juergen Gross > > Reviewed-by: Boris Ostrovsky > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel